From e3d8dbf479e52a81b0fd54a28c180e94f15afca0 Mon Sep 17 00:00:00 2001
From: Evan Cheng <evan.cheng@apple.com>
Date: Thu, 27 Mar 2008 01:45:11 +0000
Subject: [PATCH] Code clean up.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48856 91177308-0d34-0410-b5e6-96231b3b80d8
---
 lib/Target/X86/X86InstrInfo.cpp | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/lib/Target/X86/X86InstrInfo.cpp b/lib/Target/X86/X86InstrInfo.cpp
index 07c0f4e5adb..baa41f9a6cf 100644
--- a/lib/Target/X86/X86InstrInfo.cpp
+++ b/lib/Target/X86/X86InstrInfo.cpp
@@ -734,19 +734,20 @@ unsigned X86InstrInfo::isStoreToStackSlot(MachineInstr *MI,
 }
 
 
- static bool regIsPICBase(MachineInstr *MI, unsigned BaseReg) {
-   MachineRegisterInfo &MRI = MI->getParent()->getParent()->getRegInfo();
-   bool isPICBase = false;
-   for (MachineRegisterInfo::def_iterator I = MRI.def_begin(BaseReg),
-          E = MRI.def_end(); I != E; ++I) {
-     MachineInstr *DefMI = I.getOperand().getParent();
-     if (DefMI->getOpcode() != X86::MOVPC32r)
-       return false;
-     assert(!isPICBase && "More than one PIC base?");
-     isPICBase = true;
-   }
-   return isPICBase;
- }
+/// regIsPICBase - Return true if register is PIC base (i.e.g defined by
+/// X86::MOVPC32r.
+static bool regIsPICBase(unsigned BaseReg, MachineRegisterInfo &MRI) {
+  bool isPICBase = false;
+  for (MachineRegisterInfo::def_iterator I = MRI.def_begin(BaseReg),
+         E = MRI.def_end(); I != E; ++I) {
+    MachineInstr *DefMI = I.getOperand().getParent();
+    if (DefMI->getOpcode() != X86::MOVPC32r)
+      return false;
+    assert(!isPICBase && "More than one PIC base?");
+    isPICBase = true;
+  }
+  return isPICBase;
+}
  
 bool X86InstrInfo::isReallyTriviallyReMaterializable(MachineInstr *MI) const {
   switch (MI->getOpcode()) {
@@ -799,7 +800,8 @@ bool X86InstrInfo::isReallyTriviallyReMaterializable(MachineInstr *MI) const {
          if (BaseReg == 0)
            return true;
          // Allow re-materialization of lea PICBase + x.
-         return regIsPICBase(MI, BaseReg);
+         MachineRegisterInfo &MRI = MI->getParent()->getParent()->getRegInfo();
+         return regIsPICBase(BaseReg, MRI);
        }
        return false;
      }