diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp index 3a2d24440dc..0030617fe52 100644 --- a/lib/AsmParser/LLParser.cpp +++ b/lib/AsmParser/LLParser.cpp @@ -472,29 +472,30 @@ bool LLParser::ParseMDString(MetadataBase *&MDS) { // MDNode: // ::= '!' MDNodeNumber +// FIXME: Take an MDNode*&. bool LLParser::ParseMDNode(MetadataBase *&Node) { // !{ ..., !42, ... } unsigned MID = 0; - if (ParseUInt32(MID)) return true; + if (ParseUInt32(MID)) return true; // Check existing MDNode. - std::map::iterator I = MetadataCache.find(MID); + std::map >::iterator I = MetadataCache.find(MID); if (I != MetadataCache.end()) { - Node = cast(I->second); + Node = I->second; return false; } // Check known forward references. - std::map >::iterator + std::map, LocTy> >::iterator FI = ForwardRefMDNodes.find(MID); if (FI != ForwardRefMDNodes.end()) { - Node = cast(FI->second.first); + Node = FI->second.first; return false; } // Create MDNode forward reference - SmallVector Elts; std::string FwdRefName = "llvm.mdnode.fwdref." + utostr(MID); + SmallVector Elts; Elts.push_back(MDString::get(Context, FwdRefName)); MDNode *FwdNode = MDNode::get(Context, Elts.data(), Elts.size()); ForwardRefMDNodes[MID] = std::make_pair(FwdNode, Lex.getLoc()); @@ -544,7 +545,7 @@ bool LLParser::ParseStandaloneMetadata() { unsigned MetadataID = 0; if (ParseUInt32(MetadataID)) return true; - if (MetadataCache.find(MetadataID) != MetadataCache.end()) + if (MetadataCache.count(MetadataID)) return TokError("Metadata id is already used"); if (ParseToken(lltok::equal, "expected '=' here")) return true; @@ -568,11 +569,10 @@ bool LLParser::ParseStandaloneMetadata() { MDNode *Init = MDNode::get(Context, Elts.data(), Elts.size()); MetadataCache[MetadataID] = Init; - std::map >::iterator + std::map, LocTy> >::iterator FI = ForwardRefMDNodes.find(MetadataID); if (FI != ForwardRefMDNodes.end()) { - MDNode *FwdNode = cast(FI->second.first); - FwdNode->replaceAllUsesWith(Init); + FI->second.first->replaceAllUsesWith(Init); ForwardRefMDNodes.erase(FI); } diff --git a/lib/AsmParser/LLParser.h b/lib/AsmParser/LLParser.h index eec524a5e65..7e901820527 100644 --- a/lib/AsmParser/LLParser.h +++ b/lib/AsmParser/LLParser.h @@ -17,8 +17,8 @@ #include "LLLexer.h" #include "llvm/Module.h" #include "llvm/Type.h" -#include #include "llvm/Support/ValueHandle.h" +#include namespace llvm { class Module; @@ -80,8 +80,8 @@ namespace llvm { std::map > ForwardRefTypeIDs; std::vector NumberedTypes; /// MetadataCache - This map keeps track of parsed metadata constants. - std::map MetadataCache; - std::map > ForwardRefMDNodes; + std::map > MetadataCache; + std::map, LocTy> > ForwardRefMDNodes; SmallVector, 2> MDsOnInst; struct UpRefRecord { /// Loc - This is the location of the upref.