mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2026-04-26 12:20:42 +00:00
R600/SI: add pass to mark CF live ranges as non-spillable
Spilling can insert instructions almost anywhere, and this can mess up control flow lowering in a multitude of ways, due to instruction reordering. Let's sort this out the easy way: never spill registers involved with control flow, i.e. saved EXEC masks. Unfortunately, this does not work at all with optimizations disabled, as the register allocator ignores spill weights. This should be addressed in a future commit. The test was reduced from the "stacks" shader of [1]. Some issues trigger the machine verifier while another one is checked manually. [1] http://madebyevan.com/webgl-path-tracing/ v2: only insert pass with optimizations enabled, merge test runs. Patch by: Grigori Goronzy git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@237152 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@@ -252,6 +252,15 @@ bool GCNPassConfig::addInstSelector() {
|
||||
|
||||
void GCNPassConfig::addPreRegAlloc() {
|
||||
const AMDGPUSubtarget &ST = *getAMDGPUTargetMachine().getSubtargetImpl();
|
||||
|
||||
// This needs to be run directly before register allocation because
|
||||
// earlier passes might recompute live intervals.
|
||||
// TODO: handle CodeGenOpt::None; fast RA ignores spill weights set by the pass
|
||||
if (getOptLevel() > CodeGenOpt::None) {
|
||||
initializeSIFixControlFlowLiveIntervalsPass(*PassRegistry::getPassRegistry());
|
||||
insertPass(&MachineSchedulerID, &SIFixControlFlowLiveIntervalsID);
|
||||
}
|
||||
|
||||
if (getOptLevel() > CodeGenOpt::None && ST.loadStoreOptEnabled()) {
|
||||
// Don't do this with no optimizations since it throws away debug info by
|
||||
// merging nonadjacent loads.
|
||||
|
||||
Reference in New Issue
Block a user