6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-26 07:24:25 +00:00
Code Issues Projects Releases Wiki Activity

python: Fix check for disasm creation failure

Browse Source 
Check should be for pointer being NULL, not what it points to.

Also adds a test for this case.

Reviewed By: indygreg

Differential Revision: http://llvm-reviews.chandlerc.com/D1878



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@194965 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Anders Waldenborg
2013-11-17 15:40:57 +00:00
parent 60e4d7f618
commit e8a957d2a9
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bindings/python/llvm/disassembler.py
View File

@ -75,7 +75,7 @@ class Disassembler(LLVMObject):
ptr = lib.LLVMCreateDisasm(c_char_p(triple), c_void_p(None), c_int(0), ptr = lib.LLVMCreateDisasm(c_char_p(triple), c_void_p(None), c_int(0),
callbacks['op_info'](0), callbacks['symbol_lookup'](0)) callbacks['op_info'](0), callbacks['symbol_lookup'](0))
if not ptr.contents: if not ptr:
raise Exception('Could not obtain disassembler for triple: %s' % raise Exception('Could not obtain disassembler for triple: %s' %
triple) triple)

4
bindings/python/llvm/tests/test_disassembler.py
View File

@ -16,6 +16,10 @@ class TestDisassembler(TestBase):
self.assertEqual(count, 3) self.assertEqual(count, 3)
self.assertEqual(s, '\tjcxz\t-127') self.assertEqual(s, '\tjcxz\t-127')
def test_nonexistant_triple(self):
with self.assertRaisesRegexp(Exception, "Could not obtain disassembler for triple"):
Disassembler("nonexistant-triple-raises")
def test_get_instructions(self): def test_get_instructions(self):
sequence = '\x67\xe3\x81\x01\xc7' # jcxz -127; addl %eax, %edi sequence = '\x67\xe3\x81\x01\xc7' # jcxz -127; addl %eax, %edi