diff --git a/lib/Transforms/Scalar/TailRecursionElimination.cpp b/lib/Transforms/Scalar/TailRecursionElimination.cpp index b7580255150..f8eafc845db 100644 --- a/lib/Transforms/Scalar/TailRecursionElimination.cpp +++ b/lib/Transforms/Scalar/TailRecursionElimination.cpp @@ -249,12 +249,7 @@ bool TailCallElim::markTails(Function &F, bool &AllCallsAreTailCalls) { return false; AllCallsAreTailCalls = true; - // The local stack holds all alloca instructions and all byval arguments. AllocaDerivedValueTracker Tracker; - for (Argument &Arg : F.args()) { - if (Arg.hasByValAttr()) - Tracker.walk(&Arg); - } for (auto &BB : F) { for (auto &I : BB) if (AllocaInst *AI = dyn_cast(&I)) @@ -310,9 +305,8 @@ bool TailCallElim::markTails(Function &F, bool &AllCallsAreTailCalls) { for (auto &Arg : CI->arg_operands()) { if (isa(Arg.getUser())) continue; - if (Argument *A = dyn_cast(Arg.getUser())) - if (!A->hasByValAttr()) - continue; + if (isa(Arg.getUser())) + continue; SafeToTail = false; break; } diff --git a/test/Transforms/Inline/byval-tail-call.ll b/test/Transforms/Inline/byval-tail-call.ll index 3a8906aa210..e80bae1696e 100644 --- a/test/Transforms/Inline/byval-tail-call.ll +++ b/test/Transforms/Inline/byval-tail-call.ll @@ -27,10 +27,11 @@ define internal void @qux(i32* byval %x) { tail call void @ext(i32* null) ret void } + define void @frob(i32* %x) { ; CHECK-LABEL: define void @frob( ; CHECK: alloca i32 -; CHECK: {{^ *}}call void @ext( +; CHECK: {{^ *}}tail call void @ext( ; CHECK: tail call void @ext(i32* null) ; CHECK: ret void tail call void @qux(i32* byval %x) diff --git a/test/Transforms/TailCallElim/basic.ll b/test/Transforms/TailCallElim/basic.ll index 8e9814b52bb..c7af9af5be7 100644 --- a/test/Transforms/TailCallElim/basic.ll +++ b/test/Transforms/TailCallElim/basic.ll @@ -147,7 +147,7 @@ cond_false: ; Don't tail call if a byval arg is captured. define void @test9(i32* byval %a) { ; CHECK-LABEL: define void @test9( -; CHECK: {{^ *}}call void @use( +; CHECK: {{^ *}}tail call void @use( call void @use(i32* %a) ret void } diff --git a/test/Transforms/TailCallElim/byval.ll b/test/Transforms/TailCallElim/byval.ll new file mode 100644 index 00000000000..1150f7684e9 --- /dev/null +++ b/test/Transforms/TailCallElim/byval.ll @@ -0,0 +1,34 @@ +; RUN: opt -mtriple i386 -Os -S %s -o - | FileCheck %s +; RUN: opt -mtriple x86_64 -Os -S %s -o - | FileCheck %s +; RUN: opt -mtriple armv7 -Os -S %s -o - | FileCheck %s + +%struct.D16 = type { [16 x double] } + +declare void @_Z2OpP3D16PKS_S2_(%struct.D16*, %struct.D16*, %struct.D16*) + +define void @_Z7TestRefRK3D16S1_(%struct.D16* noalias sret %agg.result, %struct.D16* %RHS, %struct.D16* %LHS) { + %1 = alloca %struct.D16*, align 8 + %2 = alloca %struct.D16*, align 8 + store %struct.D16* %RHS, %struct.D16** %1, align 8 + store %struct.D16* %LHS, %struct.D16** %2, align 8 + %3 = load %struct.D16** %1, align 8 + %4 = load %struct.D16** %2, align 8 + call void @_Z2OpP3D16PKS_S2_(%struct.D16* %agg.result, %struct.D16* %3, %struct.D16* %4) + ret void +} + +; CHECK: define void @_Z7TestRefRK3D16S1_({{.*}}) { +; CHECK: tail call void @_Z2OpP3D16PKS_S2_(%struct.D16* %agg.result, %struct.D16* %RHS, %struct.D16* %LHS) +; CHECK: ret void +; CHECK: } + +define void @_Z7TestVal3D16S_(%struct.D16* noalias sret %agg.result, %struct.D16* byval align 8 %RHS, %struct.D16* byval align 8 %LHS) { + call void @_Z2OpP3D16PKS_S2_(%struct.D16* %agg.result, %struct.D16* %RHS, %struct.D16* %LHS) + ret void +} + +; CHECK: define void @_Z7TestVal3D16S_({{.*}}) { +; CHECK: tail call void @_Z2OpP3D16PKS_S2_(%struct.D16* %agg.result, %struct.D16* %RHS, %struct.D16* %LHS) +; CHECK: ret void +; CHECK: } +