From ed1ec3aa6b646a47943fdbdf6148c342f0b5a31f Mon Sep 17 00:00:00 2001 From: Dale Johannesen Date: Fri, 23 May 2008 00:15:10 +0000 Subject: [PATCH] Make LTO expect common and weak to be represented differently. Reading .bc files from before that change will no longer work. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51457 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/lto2/LTOModule.cpp | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/tools/lto2/LTOModule.cpp b/tools/lto2/LTOModule.cpp index 2fd29be272a..c4bee714c6c 100644 --- a/tools/lto2/LTOModule.cpp +++ b/tools/lto2/LTOModule.cpp @@ -191,17 +191,7 @@ void LTOModule::addDefinedSymbol(GlobalValue* def, Mangler &mangler, // set definition part if ( def->hasWeakLinkage() || def->hasLinkOnceLinkage() ) { - // lvm bitcode does not differenciate between weak def data - // and tentative definitions! - // HACK HACK HACK - // C++ does not use tentative definitions, but does use weak symbols - // so guess that anything that looks like a C++ symbol is weak and others - // are tentative definitions - if ( (strncmp(symbolName, "__Z", 3) == 0) ) - attr |= LTO_SYMBOL_DEFINITION_WEAK; - else { - attr |= LTO_SYMBOL_DEFINITION_TENTATIVE; - } + attr |= LTO_SYMBOL_DEFINITION_WEAK; } else if ( def->hasCommonLinkage()) { attr |= LTO_SYMBOL_DEFINITION_TENTATIVE;