From efb8deb6407ef731f17f622d317b122f7c4bd0a1 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Fri, 28 Mar 2014 09:18:42 +0000 Subject: [PATCH] [Allocator Cleanup] Sink the private data members and methods to the bottom of the interface to make it easier to scan and find the public API. No functionality changed. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204996 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Support/Allocator.h | 79 ++++++++++++++++---------------- 1 file changed, 40 insertions(+), 39 deletions(-) diff --git a/include/llvm/Support/Allocator.h b/include/llvm/Support/Allocator.h index f3592f7fe96..3ef2102ae55 100644 --- a/include/llvm/Support/Allocator.h +++ b/include/llvm/Support/Allocator.h @@ -101,6 +101,46 @@ class BumpPtrAllocator { BumpPtrAllocator(const BumpPtrAllocator &) LLVM_DELETED_FUNCTION; void operator=(const BumpPtrAllocator &) LLVM_DELETED_FUNCTION; +public: + BumpPtrAllocator(size_t size = 4096, size_t threshold = 4096); + BumpPtrAllocator(size_t size, size_t threshold, SlabAllocator &allocator); + ~BumpPtrAllocator(); + + /// \brief Deallocate all but the current slab and reset the current pointer + /// to the beginning of it, freeing all memory allocated so far. + void Reset(); + + /// \brief Allocate space at the specified alignment. + void *Allocate(size_t Size, size_t Alignment); + + /// \brief Allocate space for one object without constructing it. + template T *Allocate() { + return static_cast(Allocate(sizeof(T), AlignOf::Alignment)); + } + + /// \brief Allocate space for an array of objects without constructing them. + template T *Allocate(size_t Num) { + return static_cast(Allocate(Num * sizeof(T), AlignOf::Alignment)); + } + + /// \brief Allocate space for an array of objects with the specified alignment + /// and without constructing them. + template T *Allocate(size_t Num, size_t Alignment) { + // Round EltSize up to the specified alignment. + size_t EltSize = (sizeof(T) + Alignment - 1) & (-Alignment); + return static_cast(Allocate(Num * EltSize, Alignment)); + } + + void Deallocate(const void * /*Ptr*/) {} + + size_t GetNumSlabs() const { return NumSlabs; } + + void PrintStats() const; + + /// \brief Returns the total physical memory allocated by this allocator. + size_t getTotalMemory() const; + +private: /// \brief Allocate at least this many bytes of memory in a slab. size_t SlabSize; @@ -146,45 +186,6 @@ class BumpPtrAllocator { void DeallocateSlabs(MemSlab *Slab); template friend class SpecificBumpPtrAllocator; - -public: - BumpPtrAllocator(size_t size = 4096, size_t threshold = 4096); - BumpPtrAllocator(size_t size, size_t threshold, SlabAllocator &allocator); - ~BumpPtrAllocator(); - - /// \brief Deallocate all but the current slab and reset the current pointer - /// to the beginning of it, freeing all memory allocated so far. - void Reset(); - - /// \brief Allocate space at the specified alignment. - void *Allocate(size_t Size, size_t Alignment); - - /// \brief Allocate space for one object without constructing it. - template T *Allocate() { - return static_cast(Allocate(sizeof(T), AlignOf::Alignment)); - } - - /// \brief Allocate space for an array of objects without constructing them. - template T *Allocate(size_t Num) { - return static_cast(Allocate(Num * sizeof(T), AlignOf::Alignment)); - } - - /// \brief Allocate space for an array of objects with the specified alignment - /// and without constructing them. - template T *Allocate(size_t Num, size_t Alignment) { - // Round EltSize up to the specified alignment. - size_t EltSize = (sizeof(T) + Alignment - 1) & (-Alignment); - return static_cast(Allocate(Num * EltSize, Alignment)); - } - - void Deallocate(const void * /*Ptr*/) {} - - size_t GetNumSlabs() const { return NumSlabs; } - - void PrintStats() const; - - /// \brief Returns the total physical memory allocated by this allocator. - size_t getTotalMemory() const; }; /// \brief A BumpPtrAllocator that allows only elements of a specific type to be