6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-15 04:30:12 +00:00
Code Issues Projects Releases Wiki Activity

Revert: r189565 - Add getUnrollingPreferences to TTI

Browse Source 
Revert unintentional commit (of an unreviewed change).

Original commit message:

Add getUnrollingPreferences to TTI

Allow targets to customize the default behavior of the generic loop unrolling
transformation. This will be used by the PowerPC backend when targeting the A2
core (which is in-order with a deep pipeline), and using more aggressive
defaults is important.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189566 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Hal Finkel 2013-08-29 03:33:15 +00:00
parent 32f258b96a
commit f208398528
4 changed files with 5 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
include/llvm/Analysis/TargetTransformInfo.h
View File

@ -191,20 +191,6 @@ public:
/// incurs significant execution cost.
virtual bool isLoweredToCall(const Function *F) const;
/// Parameters that control the generic loop unrolling transformation.
struct UnrollingPreferences {
unsigned Threshold; ///< The cost threshold for the unrolled loop.
unsigned OptSizeThreshold; ///< The cost threshold for the unrolled loop
///< when optimizing for size.
bool Partial; ///< Allow partial loop unrolling.
bool Runtime; ///< Perform runtime unrolling.
};
/// \brief Get target-customized preferences for the generic loop unrolling
/// transformation. Returns true if the UnrollingPreferences struct has been
/// initialized.
virtual bool getUnrollingPreferences(UnrollingPreferences &UP) const;
/// @}
/// \name Scalar Target Information

9
lib/Analysis/TargetTransformInfo.cpp
View File

@ -96,11 +96,6 @@ bool TargetTransformInfo::isLoweredToCall(const Function *F) const {
return PrevTTI->isLoweredToCall(F);
}
bool TargetTransformInfo::getUnrollingPreferences(
UnrollingPreferences &UP) const {
return PrevTTI->getUnrollingPreferences(UP);
}
bool TargetTransformInfo::isLegalAddImmediate(int64_t Imm) const {
return PrevTTI->isLegalAddImmediate(Imm);
}
@ -474,10 +469,6 @@ struct NoTTI : ImmutablePass, TargetTransformInfo {
return true;
}
virtual bool getUnrollingPreferences(UnrollingPreferences &) const {
return false;
}
bool isLegalAddImmediate(int64_t Imm) const {
return false;
}

5
lib/CodeGen/BasicTargetTransformInfo.cpp
View File

@ -84,7 +84,6 @@ public:
virtual unsigned getJumpBufSize() const;
virtual bool shouldBuildLookupTables() const;
virtual bool haveFastSqrt(Type *Ty) const;
virtual bool getUnrollingPreferences(UnrollingPreferences &UP) const;
/// @}
@ -190,10 +189,6 @@ bool BasicTTI::haveFastSqrt(Type *Ty) const {
return TLI->isTypeLegal(VT) && TLI->isOperationLegalOrCustom(ISD::FSQRT, VT);
}
bool BasicTTI::getUnrollingPreferences(UnrollingPreferences &) const {
return false;
}
//===----------------------------------------------------------------------===//
//
// Calls used by the vectorizers.

22
lib/Transforms/Scalar/LoopUnrollPass.cpp
View File

@ -55,8 +55,6 @@ namespace {
CurrentAllowPartial = (P == -1) ? UnrollAllowPartial : (bool)P;
UserThreshold = (T != -1) || (UnrollThreshold.getNumOccurrences() > 0);
UserAllowPartial = (P != -1) ||
(UnrollAllowPartial.getNumOccurrences() > 0);
initializeLoopUnrollPass(*PassRegistry::getPassRegistry());
}
@ -78,7 +76,6 @@ namespace {
unsigned CurrentThreshold;
bool CurrentAllowPartial;
bool UserThreshold; // CurrentThreshold is user-specified.
bool UserAllowPartial; // CurrentAllowPartial is user-specified.
bool runOnLoop(Loop *L, LPPassManager &LPM);
@ -148,20 +145,16 @@ bool LoopUnroll::runOnLoop(Loop *L, LPPassManager &LPM) {
<< "] Loop %" << Header->getName() << "\n");
(void)Header;
TargetTransformInfo::UnrollingPreferences UP;
bool HasUP = TTI.getUnrollingPreferences(UP);
// Determine the current unrolling threshold. While this is normally set
// from UnrollThreshold, it is overridden to a smaller value if the current
// function is marked as optimize-for-size, and the unroll threshold was
// not user specified.
unsigned Threshold = (HasUP && !UserThreshold) ? UP.Threshold :
CurrentThreshold;
unsigned Threshold = CurrentThreshold;
if (!UserThreshold &&
Header->getParent()->getAttributes().
hasAttribute(AttributeSet::FunctionIndex,
Attribute::OptimizeForSize))
Threshold = HasUP ? UP.OptSizeThreshold : OptSizeUnrollThreshold;
Threshold = OptSizeUnrollThreshold;
// Find trip count and trip multiple if count is not available
unsigned TripCount = 0;
@ -191,9 +184,6 @@ bool LoopUnroll::runOnLoop(Loop *L, LPPassManager &LPM) {
Count = TripCount;
}
bool Runtime = (HasUP && UnrollRuntime.getNumOccurrences() == 0) ?
UP.Runtime : UnrollRuntime;
// Enforce the threshold.
if (Threshold != NoThreshold) {
unsigned NumInlineCandidates;
@ -214,9 +204,7 @@ bool LoopUnroll::runOnLoop(Loop *L, LPPassManager &LPM) {
if (TripCount != 1 && Size > Threshold) {
DEBUG(dbgs() << " Too large to fully unroll with count: " << Count
<< " because size: " << Size << ">" << Threshold << "\n");
bool AllowPartial = (HasUP && !UserAllowPartial) ? UP.Partial :
CurrentAllowPartial;
if (!AllowPartial && !(Runtime && TripCount == 0)) {
if (!CurrentAllowPartial && !(UnrollRuntime && TripCount == 0)) {
DEBUG(dbgs() << " will not try to unroll partially because "
<< "-unroll-allow-partial not given\n");
return false;
@ -227,7 +215,7 @@ bool LoopUnroll::runOnLoop(Loop *L, LPPassManager &LPM) {
while (Count != 0 && TripCount%Count != 0)
Count--;
}
else if (Runtime) {
else if (UnrollRuntime) {
// Reduce unroll count to be a lower power-of-two value
while (Count != 0 && Size > Threshold) {
Count >>= 1;
@ -243,7 +231,7 @@ bool LoopUnroll::runOnLoop(Loop *L, LPPassManager &LPM) {
}
// Unroll the loop.
if (!UnrollLoop(L, Count, TripCount, Runtime, TripMultiple, LI, &LPM))
if (!UnrollLoop(L, Count, TripCount, UnrollRuntime, TripMultiple, LI, &LPM))
return false;
return true;