replace a linear scan with a symtab lookup, reduce indentation.

No functionality change.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121042 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2010-12-06 21:53:07 +00:00
parent 1dda29bdff
commit f51a6cc5bf

View File

@ -1930,47 +1930,47 @@ bool GlobalOpt::OptimizeGlobalVars(Module &M) {
/// FindGlobalCtors - Find the llvm.globalctors list, verifying that all /// FindGlobalCtors - Find the llvm.globalctors list, verifying that all
/// initializers have an init priority of 65535. /// initializers have an init priority of 65535.
GlobalVariable *GlobalOpt::FindGlobalCtors(Module &M) { GlobalVariable *GlobalOpt::FindGlobalCtors(Module &M) {
for (Module::global_iterator I = M.global_begin(), E = M.global_end(); GlobalVariable *GV = M.getGlobalVariable("llvm.global_ctors");
I != E; ++I) if (GV == 0) return 0;
if (I->getName() == "llvm.global_ctors") {
// Found it, verify it's an array of { int, void()* }. // Found it, verify it's an array of { int, void()* }.
const ArrayType *ATy =dyn_cast<ArrayType>(I->getType()->getElementType()); const ArrayType *ATy =dyn_cast<ArrayType>(GV->getType()->getElementType());
if (!ATy) return 0; if (!ATy) return 0;
const StructType *STy = dyn_cast<StructType>(ATy->getElementType()); const StructType *STy = dyn_cast<StructType>(ATy->getElementType());
if (!STy || STy->getNumElements() != 2 || if (!STy || STy->getNumElements() != 2 ||
!STy->getElementType(0)->isIntegerTy(32)) return 0; !STy->getElementType(0)->isIntegerTy(32)) return 0;
const PointerType *PFTy = dyn_cast<PointerType>(STy->getElementType(1)); const PointerType *PFTy = dyn_cast<PointerType>(STy->getElementType(1));
if (!PFTy) return 0; if (!PFTy) return 0;
const FunctionType *FTy = dyn_cast<FunctionType>(PFTy->getElementType()); const FunctionType *FTy = dyn_cast<FunctionType>(PFTy->getElementType());
if (!FTy || !FTy->getReturnType()->isVoidTy() || if (!FTy || !FTy->getReturnType()->isVoidTy() ||
FTy->isVarArg() || FTy->getNumParams() != 0) FTy->isVarArg() || FTy->getNumParams() != 0)
return 0; return 0;
// Verify that the initializer is simple enough for us to handle. We are // Verify that the initializer is simple enough for us to handle. We are
// only allowed to optimize the initializer if it is unique. // only allowed to optimize the initializer if it is unique.
if (!I->hasUniqueInitializer()) return 0; if (!GV->hasUniqueInitializer()) return 0;
ConstantArray *CA = dyn_cast<ConstantArray>(I->getInitializer());
if (!CA) return 0; ConstantArray *CA = dyn_cast<ConstantArray>(GV->getInitializer());
for (User::op_iterator i = CA->op_begin(), e = CA->op_end(); i != e; ++i) if (!CA) return 0;
if (ConstantStruct *CS = dyn_cast<ConstantStruct>(*i)) {
if (isa<ConstantPointerNull>(CS->getOperand(1))) for (User::op_iterator i = CA->op_begin(), e = CA->op_end(); i != e; ++i) {
continue; ConstantStruct *CS = dyn_cast<ConstantStruct>(*i);
if (CS == 0) return 0;
if (isa<ConstantPointerNull>(CS->getOperand(1)))
continue;
// Must have a function or null ptr. // Must have a function or null ptr.
if (!isa<Function>(CS->getOperand(1))) if (!isa<Function>(CS->getOperand(1)))
return 0; return 0;
// Init priority must be standard. // Init priority must be standard.
ConstantInt *CI = dyn_cast<ConstantInt>(CS->getOperand(0)); ConstantInt *CI = dyn_cast<ConstantInt>(CS->getOperand(0));
if (!CI || CI->getZExtValue() != 65535) if (!CI || CI->getZExtValue() != 65535)
return 0; return 0;
} else { }
return 0;
}
return I; return GV;
}
return 0;
} }
/// ParseGlobalCtors - Given a llvm.global_ctors list that we can understand, /// ParseGlobalCtors - Given a llvm.global_ctors list that we can understand,