From f52d01bbc58c116f7c83f3320a0f2dff9ac1b3d6 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 15 Sep 2003 04:35:16 +0000 Subject: [PATCH] These two conditions are not exclusive!! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@8518 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/IPA/CallGraph.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/Analysis/IPA/CallGraph.cpp b/lib/Analysis/IPA/CallGraph.cpp index 980d11961e7..d5cbe3d02b4 100644 --- a/lib/Analysis/IPA/CallGraph.cpp +++ b/lib/Analysis/IPA/CallGraph.cpp @@ -64,7 +64,7 @@ CallGraphNode *CallGraph::getNodeFor(Function *F) { void CallGraph::addToCallGraph(Function *F) { CallGraphNode *Node = getNodeFor(F); - // If this function has external linkage, + // If this function has external linkage, anything could call it... if (!F->hasInternalLinkage()) { ExternalNode->addCalledFunction(Node); @@ -75,9 +75,12 @@ void CallGraph::addToCallGraph(Function *F) { else Root = Node; // Found a main, keep track of it! } - } else if (F->isExternal()) { // Not defined in this xlation unit? - Node->addCalledFunction(ExternalNode); // It could call anything... } + + // If this function is not defined in this translation unit, it could call + // anything. + if (F->isExternal()) + Node->addCalledFunction(ExternalNode); // Loop over all of the users of the function... looking for callers... //