Tidy up. 80-column and whitespace.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@131094 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jim Grosbach
2011-05-09 20:05:25 +00:00
parent cef81b7e51
commit f5bf3cf7e2
3 changed files with 73 additions and 72 deletions

View File

@ -39,7 +39,7 @@ private:
const ByteArrayTy &Bytes; const ByteArrayTy &Bytes;
public: public:
VectorMemoryObject(const ByteArrayTy &bytes) : Bytes(bytes) {} VectorMemoryObject(const ByteArrayTy &bytes) : Bytes(bytes) {}
uint64_t getBase() const { return 0; } uint64_t getBase() const { return 0; }
uint64_t getExtent() const { return Bytes.size(); } uint64_t getExtent() const { return Bytes.size(); }
@ -57,15 +57,15 @@ static bool PrintInsts(const MCDisassembler &DisAsm,
SourceMgr &SM, raw_ostream &Out) { SourceMgr &SM, raw_ostream &Out) {
// Wrap the vector in a MemoryObject. // Wrap the vector in a MemoryObject.
VectorMemoryObject memoryObject(Bytes); VectorMemoryObject memoryObject(Bytes);
// Disassemble it to strings. // Disassemble it to strings.
uint64_t Size; uint64_t Size;
uint64_t Index; uint64_t Index;
for (Index = 0; Index < Bytes.size(); Index += Size) { for (Index = 0; Index < Bytes.size(); Index += Size) {
MCInst Inst; MCInst Inst;
if (DisAsm.getInstruction(Inst, Size, memoryObject, Index, if (DisAsm.getInstruction(Inst, Size, memoryObject, Index,
/*REMOVE*/ nulls())) { /*REMOVE*/ nulls())) {
Printer.printInst(&Inst, Out); Printer.printInst(&Inst, Out);
Out << "\n"; Out << "\n";
@ -76,12 +76,12 @@ static bool PrintInsts(const MCDisassembler &DisAsm,
Size = 1; // skip illegible bytes Size = 1; // skip illegible bytes
} }
} }
return false; return false;
} }
static bool ByteArrayFromString(ByteArrayTy &ByteArray, static bool ByteArrayFromString(ByteArrayTy &ByteArray,
StringRef &Str, StringRef &Str,
SourceMgr &SM) { SourceMgr &SM) {
while (!Str.empty()) { while (!Str.empty()) {
// Strip horizontal whitespace. // Strip horizontal whitespace.
@ -89,7 +89,7 @@ static bool ByteArrayFromString(ByteArrayTy &ByteArray,
Str = Str.substr(Pos); Str = Str.substr(Pos);
continue; continue;
} }
// If this is the end of a line or start of a comment, remove the rest of // If this is the end of a line or start of a comment, remove the rest of
// the line. // the line.
if (Str[0] == '\n' || Str[0] == '#') { if (Str[0] == '\n' || Str[0] == '#') {
@ -104,11 +104,11 @@ static bool ByteArrayFromString(ByteArrayTy &ByteArray,
} }
continue; continue;
} }
// Get the current token. // Get the current token.
size_t Next = Str.find_first_of(" \t\n\r#"); size_t Next = Str.find_first_of(" \t\n\r#");
StringRef Value = Str.substr(0, Next); StringRef Value = Str.substr(0, Next);
// Convert to a byte and add to the byte vector. // Convert to a byte and add to the byte vector.
unsigned ByteVal; unsigned ByteVal;
if (Value.getAsInteger(0, ByteVal) || ByteVal > 255) { if (Value.getAsInteger(0, ByteVal) || ByteVal > 255) {
@ -119,11 +119,11 @@ static bool ByteArrayFromString(ByteArrayTy &ByteArray,
ByteArray.clear(); ByteArray.clear();
continue; continue;
} }
ByteArray.push_back(std::make_pair((unsigned char)ByteVal, Value.data())); ByteArray.push_back(std::make_pair((unsigned char)ByteVal, Value.data()));
Str = Str.substr(Next); Str = Str.substr(Next);
} }
return false; return false;
} }
@ -133,18 +133,18 @@ int Disassembler::disassemble(const Target &T, TargetMachine &TM,
raw_ostream &Out) { raw_ostream &Out) {
// Set up disassembler. // Set up disassembler.
OwningPtr<const MCAsmInfo> AsmInfo(T.createAsmInfo(Triple)); OwningPtr<const MCAsmInfo> AsmInfo(T.createAsmInfo(Triple));
if (!AsmInfo) { if (!AsmInfo) {
errs() << "error: no assembly info for target " << Triple << "\n"; errs() << "error: no assembly info for target " << Triple << "\n";
return -1; return -1;
} }
OwningPtr<const MCDisassembler> DisAsm(T.createMCDisassembler()); OwningPtr<const MCDisassembler> DisAsm(T.createMCDisassembler());
if (!DisAsm) { if (!DisAsm) {
errs() << "error: no disassembler for target " << Triple << "\n"; errs() << "error: no disassembler for target " << Triple << "\n";
return -1; return -1;
} }
int AsmPrinterVariant = AsmInfo->getAssemblerDialect(); int AsmPrinterVariant = AsmInfo->getAssemblerDialect();
OwningPtr<MCInstPrinter> IP(T.createMCInstPrinter(TM, AsmPrinterVariant, OwningPtr<MCInstPrinter> IP(T.createMCInstPrinter(TM, AsmPrinterVariant,
*AsmInfo)); *AsmInfo));
@ -152,67 +152,67 @@ int Disassembler::disassemble(const Target &T, TargetMachine &TM,
errs() << "error: no instruction printer for target " << Triple << '\n'; errs() << "error: no instruction printer for target " << Triple << '\n';
return -1; return -1;
} }
bool ErrorOccurred = false; bool ErrorOccurred = false;
SourceMgr SM; SourceMgr SM;
SM.AddNewSourceBuffer(&Buffer, SMLoc()); SM.AddNewSourceBuffer(&Buffer, SMLoc());
// Convert the input to a vector for disassembly. // Convert the input to a vector for disassembly.
ByteArrayTy ByteArray; ByteArrayTy ByteArray;
StringRef Str = Buffer.getBuffer(); StringRef Str = Buffer.getBuffer();
ErrorOccurred |= ByteArrayFromString(ByteArray, Str, SM); ErrorOccurred |= ByteArrayFromString(ByteArray, Str, SM);
if (!ByteArray.empty()) if (!ByteArray.empty())
ErrorOccurred |= PrintInsts(*DisAsm, *IP, ByteArray, SM, Out); ErrorOccurred |= PrintInsts(*DisAsm, *IP, ByteArray, SM, Out);
return ErrorOccurred; return ErrorOccurred;
} }
static int byteArrayReader(uint8_t *B, uint64_t A, void *Arg) { static int byteArrayReader(uint8_t *B, uint64_t A, void *Arg) {
ByteArrayTy &ByteArray = *((ByteArrayTy*)Arg); ByteArrayTy &ByteArray = *((ByteArrayTy*)Arg);
if (A >= ByteArray.size()) if (A >= ByteArray.size())
return -1; return -1;
*B = ByteArray[A].first; *B = ByteArray[A].first;
return 0; return 0;
} }
static int verboseEvaluator(uint64_t *V, unsigned R, void *Arg) { static int verboseEvaluator(uint64_t *V, unsigned R, void *Arg) {
EDDisassembler &disassembler = *(EDDisassembler *)((void **)Arg)[0]; EDDisassembler &disassembler = *(EDDisassembler *)((void **)Arg)[0];
raw_ostream &Out = *(raw_ostream *)((void **)Arg)[1]; raw_ostream &Out = *(raw_ostream *)((void **)Arg)[1];
if (const char *regName = disassembler.nameWithRegisterID(R)) if (const char *regName = disassembler.nameWithRegisterID(R))
Out << "[" << regName << "/" << R << "]"; Out << "[" << regName << "/" << R << "]";
if (disassembler.registerIsStackPointer(R)) if (disassembler.registerIsStackPointer(R))
Out << "(sp)"; Out << "(sp)";
if (disassembler.registerIsProgramCounter(R)) if (disassembler.registerIsProgramCounter(R))
Out << "(pc)"; Out << "(pc)";
*V = 0; *V = 0;
return 0; return 0;
} }
int Disassembler::disassembleEnhanced(const std::string &TS, int Disassembler::disassembleEnhanced(const std::string &TS,
MemoryBuffer &Buffer, MemoryBuffer &Buffer,
raw_ostream &Out) { raw_ostream &Out) {
ByteArrayTy ByteArray; ByteArrayTy ByteArray;
StringRef Str = Buffer.getBuffer(); StringRef Str = Buffer.getBuffer();
SourceMgr SM; SourceMgr SM;
SM.AddNewSourceBuffer(&Buffer, SMLoc()); SM.AddNewSourceBuffer(&Buffer, SMLoc());
if (ByteArrayFromString(ByteArray, Str, SM)) { if (ByteArrayFromString(ByteArray, Str, SM)) {
return -1; return -1;
} }
Triple T(TS); Triple T(TS);
EDDisassembler::AssemblySyntax AS; EDDisassembler::AssemblySyntax AS;
switch (T.getArch()) { switch (T.getArch()) {
default: default:
errs() << "error: no default assembly syntax for " << TS.c_str() << "\n"; errs() << "error: no default assembly syntax for " << TS.c_str() << "\n";
@ -226,53 +226,53 @@ int Disassembler::disassembleEnhanced(const std::string &TS,
AS = EDDisassembler::kEDAssemblySyntaxX86ATT; AS = EDDisassembler::kEDAssemblySyntaxX86ATT;
break; break;
} }
EDDisassembler::initialize(); EDDisassembler::initialize();
OwningPtr<EDDisassembler> OwningPtr<EDDisassembler>
disassembler(EDDisassembler::getDisassembler(TS.c_str(), AS)); disassembler(EDDisassembler::getDisassembler(TS.c_str(), AS));
if (disassembler == 0) { if (disassembler == 0) {
errs() << "error: couldn't get disassembler for " << TS << '\n'; errs() << "error: couldn't get disassembler for " << TS << '\n';
return -1; return -1;
} }
while (ByteArray.size()) { while (ByteArray.size()) {
OwningPtr<EDInst> OwningPtr<EDInst>
inst(disassembler->createInst(byteArrayReader, 0, &ByteArray)); inst(disassembler->createInst(byteArrayReader, 0, &ByteArray));
if (inst == 0) { if (inst == 0) {
errs() << "error: Didn't get an instruction\n"; errs() << "error: Didn't get an instruction\n";
return -1; return -1;
} }
ByteArray.erase (ByteArray.begin(), ByteArray.begin() + inst->byteSize()); ByteArray.erase (ByteArray.begin(), ByteArray.begin() + inst->byteSize());
unsigned numTokens = inst->numTokens(); unsigned numTokens = inst->numTokens();
if ((int)numTokens < 0) { if ((int)numTokens < 0) {
errs() << "error: couldn't count the instruction's tokens\n"; errs() << "error: couldn't count the instruction's tokens\n";
return -1; return -1;
} }
for (unsigned tokenIndex = 0; tokenIndex != numTokens; ++tokenIndex) { for (unsigned tokenIndex = 0; tokenIndex != numTokens; ++tokenIndex) {
EDToken *token; EDToken *token;
if (inst->getToken(token, tokenIndex)) { if (inst->getToken(token, tokenIndex)) {
errs() << "error: Couldn't get token\n"; errs() << "error: Couldn't get token\n";
return -1; return -1;
} }
const char *buf; const char *buf;
if (token->getString(buf)) { if (token->getString(buf)) {
errs() << "error: Couldn't get string for token\n"; errs() << "error: Couldn't get string for token\n";
return -1; return -1;
} }
Out << '['; Out << '[';
int operandIndex = token->operandID(); int operandIndex = token->operandID();
if (operandIndex >= 0) if (operandIndex >= 0)
Out << operandIndex << "-"; Out << operandIndex << "-";
switch (token->type()) { switch (token->type()) {
default: Out << "?"; break; default: Out << "?"; break;
case EDToken::kTokenWhitespace: Out << "w"; break; case EDToken::kTokenWhitespace: Out << "w"; break;
@ -281,9 +281,9 @@ int Disassembler::disassembleEnhanced(const std::string &TS,
case EDToken::kTokenLiteral: Out << "l"; break; case EDToken::kTokenLiteral: Out << "l"; break;
case EDToken::kTokenRegister: Out << "r"; break; case EDToken::kTokenRegister: Out << "r"; break;
} }
Out << ":" << buf; Out << ":" << buf;
if (token->type() == EDToken::kTokenLiteral) { if (token->type() == EDToken::kTokenLiteral) {
Out << "="; Out << "=";
if (token->literalSign()) if (token->literalSign())
@ -303,33 +303,34 @@ int Disassembler::disassembleEnhanced(const std::string &TS,
} }
Out << "r" << regID; Out << "r" << regID;
} }
Out << "]"; Out << "]";
} }
Out << " "; Out << " ";
if (inst->isBranch()) if (inst->isBranch())
Out << "<br> "; Out << "<br> ";
if (inst->isMove()) if (inst->isMove())
Out << "<mov> "; Out << "<mov> ";
unsigned numOperands = inst->numOperands(); unsigned numOperands = inst->numOperands();
if ((int)numOperands < 0) { if ((int)numOperands < 0) {
errs() << "error: Couldn't count operands\n"; errs() << "error: Couldn't count operands\n";
return -1; return -1;
} }
for (unsigned operandIndex = 0; operandIndex != numOperands; ++operandIndex) { for (unsigned operandIndex = 0; operandIndex != numOperands;
++operandIndex) {
Out << operandIndex << ":"; Out << operandIndex << ":";
EDOperand *operand; EDOperand *operand;
if (inst->getOperand(operand, operandIndex)) { if (inst->getOperand(operand, operandIndex)) {
errs() << "error: couldn't get operand\n"; errs() << "error: couldn't get operand\n";
return -1; return -1;
} }
uint64_t evaluatedResult; uint64_t evaluatedResult;
void *Arg[] = { disassembler.get(), &Out }; void *Arg[] = { disassembler.get(), &Out };
if (operand->evaluate(evaluatedResult, verboseEvaluator, Arg)) { if (operand->evaluate(evaluatedResult, verboseEvaluator, Arg)) {
@ -338,10 +339,10 @@ int Disassembler::disassembleEnhanced(const std::string &TS,
} }
Out << "=" << evaluatedResult << " "; Out << "=" << evaluatedResult << " ";
} }
Out << '\n'; Out << '\n';
} }
return 0; return 0;
} }

View File

@ -31,12 +31,12 @@ public:
const std::string &tripleString, const std::string &tripleString,
MemoryBuffer &buffer, MemoryBuffer &buffer,
raw_ostream &Out); raw_ostream &Out);
static int disassembleEnhanced(const std::string &tripleString, static int disassembleEnhanced(const std::string &tripleString,
MemoryBuffer &buffer, MemoryBuffer &buffer,
raw_ostream &Out); raw_ostream &Out);
}; };
} // namespace llvm } // namespace llvm
#endif #endif

View File

@ -183,10 +183,10 @@ static int AsLexInput(const char *ProgName) {
MemoryBuffer *Buffer = BufferPtr.take(); MemoryBuffer *Buffer = BufferPtr.take();
SourceMgr SrcMgr; SourceMgr SrcMgr;
// Tell SrcMgr about this buffer, which is what TGParser will pick up. // Tell SrcMgr about this buffer, which is what TGParser will pick up.
SrcMgr.AddNewSourceBuffer(Buffer, SMLoc()); SrcMgr.AddNewSourceBuffer(Buffer, SMLoc());
// Record the location of the include directories so that the lexer can find // Record the location of the include directories so that the lexer can find
// it later. // it later.
SrcMgr.setIncludeDirs(IncludeDirs); SrcMgr.setIncludeDirs(IncludeDirs);
@ -279,7 +279,7 @@ static int AsLexInput(const char *ProgName) {
// Keep output if no errors. // Keep output if no errors.
if (Error == 0) Out->keep(); if (Error == 0) Out->keep();
return Error; return Error;
} }
@ -294,20 +294,20 @@ static int AssembleInput(const char *ProgName) {
return 1; return 1;
} }
MemoryBuffer *Buffer = BufferPtr.take(); MemoryBuffer *Buffer = BufferPtr.take();
SourceMgr SrcMgr; SourceMgr SrcMgr;
// Tell SrcMgr about this buffer, which is what the parser will pick up. // Tell SrcMgr about this buffer, which is what the parser will pick up.
SrcMgr.AddNewSourceBuffer(Buffer, SMLoc()); SrcMgr.AddNewSourceBuffer(Buffer, SMLoc());
// Record the location of the include directories so that the lexer can find // Record the location of the include directories so that the lexer can find
// it later. // it later.
SrcMgr.setIncludeDirs(IncludeDirs); SrcMgr.setIncludeDirs(IncludeDirs);
llvm::OwningPtr<MCAsmInfo> MAI(TheTarget->createAsmInfo(TripleName)); llvm::OwningPtr<MCAsmInfo> MAI(TheTarget->createAsmInfo(TripleName));
assert(MAI && "Unable to create target asm info!"); assert(MAI && "Unable to create target asm info!");
// Package up features to be passed to target/subtarget // Package up features to be passed to target/subtarget
std::string FeaturesStr; std::string FeaturesStr;
if (MCPU.size()) { if (MCPU.size()) {
@ -378,7 +378,7 @@ static int AssembleInput(const char *ProgName) {
*Str.get(), *MAI)); *Str.get(), *MAI));
OwningPtr<TargetAsmParser> TAP(TheTarget->createAsmParser(*Parser, *TM)); OwningPtr<TargetAsmParser> TAP(TheTarget->createAsmParser(*Parser, *TM));
if (!TAP) { if (!TAP) {
errs() << ProgName errs() << ProgName
<< ": error: this target does not support assembly parsing.\n"; << ": error: this target does not support assembly parsing.\n";
return 1; return 1;
} }
@ -404,7 +404,7 @@ static int DisassembleInput(const char *ProgName, bool Enhanced) {
errs() << ProgName << ": " << ec.message() << '\n'; errs() << ProgName << ": " << ec.message() << '\n';
return 1; return 1;
} }
OwningPtr<tool_output_file> Out(GetOutputStream()); OwningPtr<tool_output_file> Out(GetOutputStream());
if (!Out) if (!Out)
return 1; return 1;
@ -459,7 +459,7 @@ int main(int argc, char **argv) {
llvm::InitializeAllAsmPrinters(); llvm::InitializeAllAsmPrinters();
llvm::InitializeAllAsmParsers(); llvm::InitializeAllAsmParsers();
llvm::InitializeAllDisassemblers(); llvm::InitializeAllDisassemblers();
cl::ParseCommandLineOptions(argc, argv, "llvm machine code playground\n"); cl::ParseCommandLineOptions(argc, argv, "llvm machine code playground\n");
TripleName = Triple::normalize(TripleName); TripleName = Triple::normalize(TripleName);
@ -474,7 +474,7 @@ int main(int argc, char **argv) {
case AC_EDisassemble: case AC_EDisassemble:
return DisassembleInput(argv[0], true); return DisassembleInput(argv[0], true);
} }
return 0; return 0;
} }