From f5ce2678f63f5776fddcfc34ae63ecdec622938c Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 20 Oct 2005 06:06:30 +0000 Subject: [PATCH] Refactor some code, pulling it out into a function. No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@23839 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/LiveInterval.cpp | 41 +++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/lib/CodeGen/LiveInterval.cpp b/lib/CodeGen/LiveInterval.cpp index 2cbb46b082e..93d32d8edba 100644 --- a/lib/CodeGen/LiveInterval.cpp +++ b/lib/CodeGen/LiveInterval.cpp @@ -101,6 +101,29 @@ bool LiveInterval::overlapsFrom(const LiveInterval& other, return false; } +/// NontrivialOverlap - Check to see if the two live ranges specified by i and j +/// overlap. If so, check to see if they have value numbers that are not +/// iIdx/jIdx respectively. If both conditions are true, return true. +static inline bool NontrivialOverlap(LiveInterval::Ranges::const_iterator i, + LiveInterval::Ranges::const_iterator j, + unsigned iIdx, unsigned jIdx) { + if (i->start == j->start) { + // If this is not the allowed value merge, we cannot join. + if (i->ValId != iIdx || j->ValId != jIdx) + return true; + } else if (i->start < j->start) { + if (i->end > j->start && i->ValId != iIdx || j->ValId != jIdx) { + return true; + } + } else { + if (j->end > i->start && + i->ValId != iIdx || j->ValId != jIdx) + return true; + } + + return false; +} + /// joinable - Two intervals are joinable if the either don't overlap at all /// or if the destination of the copy is a single assignment value, and it /// only overlaps with one value in the source interval. @@ -125,21 +148,9 @@ bool LiveInterval::joinable(const LiveInterval &other, unsigned CopyIdx) const { } while (i != ie && j != je) { - if (i->start == j->start) { - // If this is not the allowed value merge, we cannot join. - if (i->ValId != ThisValIdx || j->ValId != OtherValIdx) - return false; - } else if (i->start < j->start) { - if (i->end > j->start) { - if (i->ValId != ThisValIdx || j->ValId != OtherValIdx) - return false; - } - } else { - if (j->end > i->start) { - if (i->ValId != ThisValIdx || j->ValId != OtherValIdx) - return false; - } - } + if (NontrivialOverlap(i, j, ThisValIdx, OtherValIdx)) + return false; + if (i->end < j->end) ++i; else