diff --git a/include/llvm/MC/MCSymbol.h b/include/llvm/MC/MCSymbol.h index ca22248876f..cf99c919281 100644 --- a/include/llvm/MC/MCSymbol.h +++ b/include/llvm/MC/MCSymbol.h @@ -15,7 +15,7 @@ #define LLVM_MC_MCSYMBOL_H #include "llvm/ADT/PointerIntPair.h" -#include "llvm/ADT/StringRef.h" +#include "llvm/ADT/StringMap.h" #include "llvm/MC/MCExpr.h" #include "llvm/Support/Compiler.h" @@ -145,7 +145,7 @@ class MCSymbol { /// Name - The name of the symbol. The referred-to string data is actually /// held by the StringMap that lives in MCContext. - StringRef Name; + const StringMapEntry *Name; /// The section the symbol is defined in. This is null for undefined symbols, /// and the special AbsolutePseudoSection value for absolute symbols. If this @@ -176,8 +176,8 @@ class MCSymbol { private: // MCContext creates and uniques these. friend class MCExpr; friend class MCContext; - MCSymbol(StringRef name, bool isTemporary) - : Name(name), Section(nullptr), Value(nullptr), IsTemporary(isTemporary), + MCSymbol(const StringMapEntry *Name, bool isTemporary) + : Name(Name), Section(nullptr), Value(nullptr), IsTemporary(isTemporary), IsRedefinable(false), IsUsed(false), HasData(false), Index(0) {} MCSymbol(const MCSymbol &) = delete; @@ -190,7 +190,7 @@ private: // MCContext creates and uniques these. public: /// getName - Get the symbol name. - StringRef getName() const { return Name; } + StringRef getName() const { return Name ? Name->first() : ""; } bool hasData() const { return HasData; } diff --git a/lib/MC/MCContext.cpp b/lib/MC/MCContext.cpp index f3ea3cc1691..968fd26f326 100644 --- a/lib/MC/MCContext.cpp +++ b/lib/MC/MCContext.cpp @@ -125,7 +125,7 @@ MCSymbol *MCContext::getOrCreateSectionSymbol(const MCSectionELF &Section) { } auto NameIter = UsedNames.insert(std::make_pair(Name, true)).first; - Sym = new (*this) MCSymbol(NameIter->getKey(), /*isTemporary*/ false); + Sym = new (*this) MCSymbol(&*NameIter, /*isTemporary*/ false); if (!OldSym) OldSym = Sym; @@ -156,7 +156,7 @@ MCSymbol *MCContext::CreateSymbol(StringRef Name, bool AlwaysAddSuffix) { IsTemporary = Name.startswith(MAI->getPrivateGlobalPrefix()); if (IsTemporary && AlwaysAddSuffix && !UseNamesOnTempLabels) - return new (*this) MCSymbol("", true); + return new (*this) MCSymbol(nullptr, true); SmallString<128> NewName = Name; bool AddSuffix = AlwaysAddSuffix; @@ -170,8 +170,7 @@ MCSymbol *MCContext::CreateSymbol(StringRef Name, bool AlwaysAddSuffix) { if (NameEntry.second) { // Ok, we found a name. Have the MCSymbol object itself refer to the copy // of the string that is embedded in the UsedNames entry. - MCSymbol *Result = - new (*this) MCSymbol(NameEntry.first->getKey(), IsTemporary); + MCSymbol *Result = new (*this) MCSymbol(&*NameEntry.first, IsTemporary); return Result; } assert(IsTemporary && "Cannot rename non-temporary symbols");