From f660802f348e4e57ef9df8d30be74b894259badb Mon Sep 17 00:00:00 2001 From: David Greene Date: Mon, 21 Dec 2009 21:21:34 +0000 Subject: [PATCH] Fix a bug in !subst where TableGen would go and resubstitute text it had just substituted. This could cause infinite looping in certain pathological cases. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@91843 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/TableGen/subst2.td | 15 +++++++++++++++ utils/TableGen/Record.cpp | 4 +++- 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 test/TableGen/subst2.td diff --git a/test/TableGen/subst2.td b/test/TableGen/subst2.td new file mode 100644 index 00000000000..3366c9d9cf7 --- /dev/null +++ b/test/TableGen/subst2.td @@ -0,0 +1,15 @@ +// RUN: tblgen %s | FileCheck %s +// CHECK: No subst +// CHECK: No foo +// CHECK: RECURSE foo + +class Recurse { + string Text = t; +} + +class Text : + Recurse; + +def Ok1 : Text<"No subst">; +def Ok2 : Text<"No NORECURSE">; +def Trouble : Text<"RECURSE NORECURSE">; diff --git a/utils/TableGen/Record.cpp b/utils/TableGen/Record.cpp index 53f90146a75..542735e88b4 100644 --- a/utils/TableGen/Record.cpp +++ b/utils/TableGen/Record.cpp @@ -945,11 +945,13 @@ Init *TernOpInit::Fold(Record *CurRec, MultiClass *CurMultiClass) { std::string Val = RHSs->getValue(); std::string::size_type found; + std::string::size_type idx = 0; do { - found = Val.find(LHSs->getValue()); + found = Val.find(LHSs->getValue(), idx); if (found != std::string::npos) { Val.replace(found, LHSs->getValue().size(), MHSs->getValue()); } + idx = found + MHSs->getValue().size(); } while (found != std::string::npos); return new StringInit(Val);