Fix cmp emission on msp430: we definitely should turn stuff like

"icmp lhs, rhs" into "cmp rhs, lhs". This should fix PR5979.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93496 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Anton Korobeynikov
2010-01-15 01:29:49 +00:00
parent c9b16cc108
commit f7ed979257
2 changed files with 26 additions and 24 deletions

View File

@@ -660,16 +660,16 @@ static SDValue EmitCMP(SDValue &LHS, SDValue &RHS, SDValue &TargetCC,
default: llvm_unreachable("Invalid integer condition!");
case ISD::SETEQ:
TCC = MSP430CC::COND_E; // aka COND_Z
// Minor optimization: if RHS is a constant, swap operands, then the
// Minor optimization: if LHS is a constant, swap operands, then the
// constant can be folded into comparison.
if (RHS.getOpcode() == ISD::Constant)
if (LHS.getOpcode() == ISD::Constant)
std::swap(LHS, RHS);
break;
case ISD::SETNE:
TCC = MSP430CC::COND_NE; // aka COND_NZ
// Minor optimization: if RHS is a constant, swap operands, then the
// Minor optimization: if LHS is a constant, swap operands, then the
// constant can be folded into comparison.
if (RHS.getOpcode() == ISD::Constant)
if (LHS.getOpcode() == ISD::Constant)
std::swap(LHS, RHS);
break;
case ISD::SETULE:
@@ -1014,8 +1014,8 @@ MSP430TargetLowering::EmitShiftInstr(MachineInstr *MI,
// BB:
// cmp 0, N
// je RemBB
BuildMI(BB, dl, TII.get(MSP430::CMP8ir))
.addImm(0).addReg(ShiftAmtSrcReg);
BuildMI(BB, dl, TII.get(MSP430::CMP8ri))
.addReg(ShiftAmtSrcReg).addImm(0);
BuildMI(BB, dl, TII.get(MSP430::JCC))
.addMBB(RemBB)
.addImm(MSP430CC::COND_E);