6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-07-21 18:29:45 +00:00
Code Issues Projects Releases Wiki Activity

musttail: Don't eliminate varargs packs if there is a forwarding call

Browse Source 
Also clean up and beef up this grep test for the feature.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216425 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Reid Kleckner 2014-08-26 00:59:51 +00:00
parent 18637beefe
commit fad8d818db
2 changed files with 37 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Transforms/IPO/DeadArgumentElimination.cpp
View File

@ -199,10 +199,15 @@ bool DAE::DeleteDeadVarargs(Function &Fn) {
return false;
// Okay, we know we can transform this function if safe. Scan its body
// looking for calls to llvm.vastart.
// looking for calls marked musttail or calls to llvm.vastart.
for (Function::iterator BB = Fn.begin(), E = Fn.end(); BB != E; ++BB) {
for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I) {
if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I)) {
CallInst *CI = dyn_cast<CallInst>(I);
if (!CI)
continue;
if (CI->isMustTailCall())
return false;
if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(CI)) {
if (II->getIntrinsicID() == Intrinsic::vastart)
return false;
}

34
test/Transforms/DeadArgElim/dead_vaargs.ll
View File

@ -1,12 +1,36 @@
; RUN: opt < %s -deadargelim -S | not grep 47
; RUN: opt < %s -deadargelim -S | not grep 1.0
; RUN: opt < %s -deadargelim -S | FileCheck %s
define i32 @bar(i32 %A) {
%tmp4 = tail call i32 (i32, ...)* @foo( i32 %A, i32 %A, i32 %A, i32 %A, i64 47, double 1.000000e+00 ) ; <i32> [#uses=1]
ret i32 %tmp4
call void (i32, ...)* @thunk(i32 %A, i64 47, double 1.000000e+00)
%a = call i32 (i32, ...)* @has_vastart(i32 %A, i64 47, double 1.000000e+00)
%b = call i32 (i32, ...)* @no_vastart( i32 %A, i32 %A, i32 %A, i32 %A, i64 47, double 1.000000e+00 )
%c = add i32 %a, %b
ret i32 %c
}
; CHECK-LABEL: define i32 @bar
; CHECK: call void (i32, ...)* @thunk(i32 %A, i64 47, double 1.000000e+00)
; CHECK: call i32 (i32, ...)* @has_vastart(i32 %A, i64 47, double 1.000000e+00)
; CHECK: call i32 @no_vastart(i32 %A)
define internal i32 @foo(i32 %X, ...) {
declare void @thunk_target(i32 %X, ...)
define internal void @thunk(i32 %X, ...) {
musttail call void(i32, ...)* @thunk_target(i32 %X, ...)
ret void
}
; CHECK-LABEL: define internal void @thunk(i32 %X, ...)
; CHECK: musttail call void (i32, ...)* @thunk_target(i32 %X, ...)
define internal i32 @has_vastart(i32 %X, ...) {
%valist = alloca i8
call void @llvm.va_start(i8* %valist)
ret i32 %X
}
; CHECK-LABEL: define internal i32 @has_vastart(i32 %X, ...)
declare void @llvm.va_start(i8*)
define internal i32 @no_vastart(i32 %X, ...) {
ret i32 %X
}
; CHECK-LABEL: define internal i32 @no_vastart(i32 %X)