From fc272c3b9e92e21ea3b4b060547e2f0ebb3036a7 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 31 Jul 2014 20:26:42 +0000 Subject: [PATCH] DWOHolder takes ownership of the argument constructor, use std::unique_ptr. Thanks to David Blaikie for noticing it. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214434 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/DebugInfo/DWARFUnit.cpp | 9 +++++---- lib/DebugInfo/DWARFUnit.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/DebugInfo/DWARFUnit.cpp b/lib/DebugInfo/DWARFUnit.cpp index 197d347090d..d52821602d2 100644 --- a/lib/DebugInfo/DWARFUnit.cpp +++ b/lib/DebugInfo/DWARFUnit.cpp @@ -235,9 +235,10 @@ size_t DWARFUnit::extractDIEsIfNeeded(bool CUDieOnly) { return DieArray.size(); } -DWARFUnit::DWOHolder::DWOHolder(object::ObjectFile *DWOFile) - : DWOFile(DWOFile), - DWOContext(cast(DIContext::getDWARFContext(*DWOFile))), +DWARFUnit::DWOHolder::DWOHolder(std::unique_ptr DWOFile) + : DWOFile(std::move(DWOFile)), + DWOContext( + cast(DIContext::getDWARFContext(*this->DWOFile))), DWOU(nullptr) { if (DWOContext->getNumDWOCompileUnits() > 0) DWOU = DWOContext->getDWOCompileUnitAtIndex(0); @@ -265,7 +266,7 @@ bool DWARFUnit::parseDWO() { if (!DWOFile) return false; // Reset DWOHolder. - DWO.reset(new DWOHolder(DWOFile.get().get())); + DWO = llvm::make_unique(std::move(*DWOFile)); DWARFUnit *DWOCU = DWO->getUnit(); // Verify that compile unit in .dwo file is valid. if (!DWOCU || DWOCU->getDWOId() != getDWOId()) { diff --git a/lib/DebugInfo/DWARFUnit.h b/lib/DebugInfo/DWARFUnit.h index 471da36af1c..b4073f99d3f 100644 --- a/lib/DebugInfo/DWARFUnit.h +++ b/lib/DebugInfo/DWARFUnit.h @@ -52,7 +52,7 @@ class DWARFUnit { std::unique_ptr DWOContext; DWARFUnit *DWOU; public: - DWOHolder(object::ObjectFile *DWOFile); + DWOHolder(std::unique_ptr DWOFile); DWARFUnit *getUnit() const { return DWOU; } }; std::unique_ptr DWO;