6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-13 08:26:02 +00:00
Code Issues Projects Releases Wiki Activity

Add a check to ensure that only PHI nodes are self referential. Code

Browse Source 
input to instruction combination was broken, which caused it to explode.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@1870 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2002-03-14 16:53:48 +00:00
parent 754cf415f6
commit fdec2468ce
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/VMCore/Verifier.cpp
View File

@@ -17,7 +17,7 @@
// . It should be illegal to put a label into any other type (like a structure) // . It should be illegal to put a label into any other type (like a structure)
// or to return one. [except constant arrays!] // or to return one. [except constant arrays!]
// . Right now 'add bool 0, 0' is valid. This isn't particularly good. // . Right now 'add bool 0, 0' is valid. This isn't particularly good.
// . Only phi nodes can be self referential: 'add int %0, %0 ; <int>:0' is bad // * Only phi nodes can be self referential: 'add int %0, %0 ; <int>:0' is bad
// * PHI nodes must have an entry for each predecessor, with no extras. // * PHI nodes must have an entry for each predecessor, with no extras.
// * All basic blocks should only end with terminator insts, not contain them // * All basic blocks should only end with terminator insts, not contain them
// * The entry node to a method must not have predecessors // * The entry node to a method must not have predecessors
@@ -119,7 +119,14 @@ static bool verifyInstruction(const Instruction *I) {
E = Preds.end(); I != E; ++I) E = Preds.end(); I != E; ++I)
Assert2(0, "PHI node does not have entry for a predecessor basic block!", Assert2(0, "PHI node does not have entry for a predecessor basic block!",
PN, *I); PN, *I);
} else {
// Check that non-phi nodes are not self referential...
for (Value::use_const_iterator UI = I->use_begin(), UE = I->use_end();
UI != UE; ++UI)
Assert1(*UI != (const User*)I,
"Only PHI nodes may reference their own value!", I);
} }
return Broken; return Broken;
} }