Rafael Espindola
826e95913b
Delete dead code.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@243015 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-23 13:42:16 +00:00
Rafael Espindola
a7616cd14c
Add a version of getSymbol with an explicit symbol table. Use it. NFC.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@243011 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-23 12:49:40 +00:00
Rafael Espindola
a95022a4f3
Refactor duplicated code and check for invalid symbol table size.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242981 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-23 03:24:22 +00:00
Rafael Espindola
55b052ae66
Delete ELFEntityIterator. NFC.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242901 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-22 14:09:20 +00:00
Michael J. Spencer
3f6881efa5
[Object][ELF] Handle files with no section header string table.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242839 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 21:40:33 +00:00
Rafael Espindola
c22eb2bea6
Don't iterate over the program headers in the constructor of ELFFile.
...
Not every program needs this information.
In particular, it is necessary and sufficient for a static linker to scan the
section table.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242833 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 20:50:53 +00:00
Rafael Espindola
961b7c2b52
Remove always null argument.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242828 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 19:38:32 +00:00
Rafael Espindola
d8a62d931e
Remove getDynamicSymbolName.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242821 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 18:20:17 +00:00
Rafael Espindola
9ed0d629ce
Remove getStaticSymbolName.
...
Every user now keeps track of the correct string table to use.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242818 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 18:04:29 +00:00
Rafael Espindola
746609067c
Remove dead code.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242804 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 16:50:57 +00:00
Rafael Espindola
7eeb71ddc3
Replace the last uses of ELF::getSymbolName in llvm-readobj.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242798 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 16:26:21 +00:00
Rafael Espindola
fcadda639e
llvm-readobj: use the associated string table to print symbols. NFI.
...
This just removes some cases that require ELFFile to eagerly parse the ELF
file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242794 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 16:02:10 +00:00
Rafael Espindola
ab466de617
Remove unused variable.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242789 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 14:45:56 +00:00
Rafael Espindola
04d208815c
Don't do a walk over the dynamic table just to find DT_SONAME.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242752 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-21 01:01:29 +00:00
Rafael Espindola
0377a22491
Simplify now that we can iterate backwards. NFC.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242715 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-20 21:45:56 +00:00
Rafael Espindola
d94e17bde9
Simplify iterating over the dynamic section and report broken ones.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242712 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-20 21:23:29 +00:00
Rafael Espindola
1c12cc02fd
Remove Elf_Rela_Iter and Elf_Rel_Iter.
...
Use just the pointers and check for invalid relocation sections.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242700 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-20 20:07:50 +00:00
Rafael Espindola
96d9043a78
Report errors an invalid virtual addresses.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242676 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-20 14:45:03 +00:00
Rafael Espindola
3c7642e230
Remove unnecessary code.
...
We were locating the dynamic string table via both the section and segment
headers.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242674 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-20 14:29:00 +00:00
Rafael Espindola
96a1f00376
Simplify the search for which segment has a virtual address. NFC.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242672 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-20 14:15:38 +00:00
Rafael Espindola
9a4133e1ee
Simplify iterating over program headers and detect corrupt ones.
...
We now use a simple pointer and have range loops.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242669 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-20 13:35:33 +00:00
Hans Wennborg
a69b1311b2
Allocate the IntervalMap in ELF.h on the heap to work around MSVC alignment bug (PR24113)
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242157 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-14 16:27:16 +00:00
Michael J. Spencer
d37a9dfc0b
[Object][ELF] Handle the dynamic string table in files without a section table.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241937 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-10 20:11:57 +00:00
NAKAMURA Takumi
89a6fba75e
llvm/Object/ELF.h: Appease g++-4.7.2.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241895 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-10 08:43:41 +00:00
Michael J. Spencer
478d483d7e
Fix shadowing.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241870 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-09 22:42:21 +00:00
Michael J. Spencer
8109763d68
[Object][ELF] Support dumping hash-tables from files with no section table.
...
This time without breaking the bots.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241869 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-09 22:32:24 +00:00
Adrian Prantl
2efb9f7c3e
Temporarily reverting 241765, 241768, and 241772 to unbreak the build bots.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241781 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-09 02:14:49 +00:00
Michael J. Spencer
43dce9c732
Fix typename issues.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241768 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-09 00:46:24 +00:00
Michael J. Spencer
7d0e4c73d4
[Object][ELF] Support dumping hash-tables from files with no section table.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241765 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-09 00:21:06 +00:00
Rafael Espindola
cca9ef3247
Delete dead code.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241353 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-03 14:46:17 +00:00
Rafael Espindola
abdd9e7330
Continue to remove the notion that ELF has dynamic and static symbols.
...
The ELFObjectFile now just reasons about a section/index pair, removing
one of the users that force ELF.h to maintain the difference.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241344 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-03 12:00:05 +00:00
Rafael Espindola
3a27979633
Handle .dynsym a bit more like we handle .symtab.
...
They have the same format and we find them in the same way, no reason to handle
them differently.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241280 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-02 16:03:38 +00:00
Rafael Espindola
adc9db9825
Use default member initializes. NFC.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241277 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-02 15:48:05 +00:00
Rafael Espindola
e4e6f29c93
Improve error message.
...
Thanks to Sean Silva for the suggestion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241255 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-02 11:48:48 +00:00
Rafael Espindola
df3edb6d36
Return ErrorOr from getSection.
...
This also improves the logic of what is an error:
* getSection(uint_32): only return an error if the index is out of bounds. The
index 0 corresponds to a perfectly valid entry.
* getSection(Elf_Sym): Returns null for symbols that normally don't have
sections and error for out of bound indexes.
In many places this just moves the report_fatal_error up the stack, but those
can then be fixed in smaller patches.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241156 91177308-0d34-0410-b5e6-96231b3b80d8
2015-07-01 12:56:27 +00:00
Rafael Espindola
4a04da337e
Remove Elf_Shdr_Iter. Diagnose files with invalid section header sizes.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241109 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-30 19:58:10 +00:00
Rafael Espindola
28bec63a7e
Fix the name of the iterator functions to match the coding standards.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241074 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-30 15:33:44 +00:00
Rafael Espindola
e8ff062325
Report an error on invalid sh_entsize.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241070 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-30 14:59:20 +00:00
NAKAMURA Takumi
d6751a82b3
ELF.h: Prune obsolete comments removed in r240996. [-Wdocumentation]
...
FIXME: Should they be moved onto Elf_Sym_Impl::getNmae()?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241044 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-30 05:59:13 +00:00
Rafael Espindola
3d176ae165
Convert obj->getSymbolName to sym->getName.
...
I doesn't depend on the object anymore.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240996 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-29 21:24:55 +00:00
Rafael Espindola
9a6c902332
Factor out the checking of string tables.
...
This moves the error checking for string tables to getStringTable which returns
an ErrorOr<StringRef>.
This improves error checking, makes it uniform across all string tables and
makes it possible to check them once instead of once per name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240950 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-29 14:39:25 +00:00
Rafael Espindola
db89b93b44
Convert an assert that can fail into error checking.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240944 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-29 14:02:24 +00:00
Rafael Espindola
e8f07a7eb3
Remove Elf_Sym_Iter.
...
It was a fairly broken concept for an ELF only class.
An ELF file can have two symbol tables, but they have exactly the same
format. There is no concept of a dynamic or a static symbol. Storing this
on the iterator also makes us do more work per symbol than necessary. To fetch
a name we would:
* Find if we had a static or a dynamic symbol.
* Look at the corresponding symbol table and find the string table section.
* Look at the string table section to fetch its contents.
* Compute the name as a substring of the string table.
All but the last step can be done per symbol table instead of per symbol. This
is a step in that direction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240939 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-29 12:38:31 +00:00
Rafael Espindola
aaaa38cb95
Fix error handling in getString and simplify callers.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240810 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-26 18:42:17 +00:00
Rafael Espindola
b82800d00e
Delete dead code. NFC.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240807 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-26 18:32:53 +00:00
Michael J. Spencer
7358cbc837
[ELF] Add some accessors for lld.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240730 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-25 23:40:41 +00:00
Michael J. Spencer
4cbb2db3ab
[Object][ELF] Add support for dumping dynamic relocations when sections are stripped.
...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240703 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-25 21:47:32 +00:00
Rafael Espindola
1e6b8f552c
Don't get confused with sections whose section number is reserved.
...
It is perfectly possible for SHNDX to contain indexes that have the same value
as reserved st_shndx values.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240544 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-24 14:48:54 +00:00
Alexey Samsonov
85529a57b4
Revert "[Object, ELF] Fix segmentation fault in ELFFile::getSectionName()."
...
This reverts commit r239124.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@239125 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-04 23:58:31 +00:00
Alexey Samsonov
83f903f352
[Object, ELF] Fix segmentation fault in ELFFile::getSectionName().
...
Don't do a null dereference if .shstrtab section is missing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@239124 91177308-0d34-0410-b5e6-96231b3b80d8
2015-06-04 23:40:23 +00:00