mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-07-19 19:30:10 +00:00
5e179a23e3
The SimplifyCFG pass looks at basic blocks that contain only phi nodes, followed by an unconditional branch. In a lot of cases, such a block (BB) can be merged into their successor (Succ). This merging is performed by TryToSimplifyUncondBranchFromEmptyBlock. It does this by taking all phi nodes in the succesor block Succ and expanding them to include the predecessors of BB. Furthermore, any phi nodes in BB are moved to Succ and expanded to include the predecessors of Succ as well. Before attempting this merge, CanPropagatePredecessorsForPHIs checks to see if all phi nodes can be properly merged. All functional changes are made to this function, only comments were updated in TryToSimplifyUncondBranchFromEmptyBlock. In the original code, CanPropagatePredecessorsForPHIs looks quite convoluted and more like stack of checks added to handle different kinds of situations than a comprehensive check. In particular the first check in the function did some value checking for the case that BB and Succ have a common predecessor, while the last check in the function simply rejected all cases where BB and Succ have a common predecessor. The first check was still useful in the case that BB did not contain any phi nodes at all, though, so it was not completely useless. Now, CanPropagatePredecessorsForPHIs is restructured to to look a lot more similar to the code that actually performs the merge. Both functions now look at the same phi nodes in about the same order. Any conflicts (phi nodes with different values for the same source) that could arise from merging or moving phi nodes are detected. If no conflicts are found, the merge can happen. Apart from only restructuring the checks, two main changes in functionality happened. Firstly, the old code rejected blocks with common predecessors in most cases. The new code performs some extra checks so common predecessors can be handled in a lot of cases. Wherever common predecessors still pose problems, the blocks are left untouched. Secondly, the old code rejected the merge when values (phi nodes) from BB were used in any other place than Succ. However, it does not seem that there is any situation that would require this check. Even more, this can be proven. Consider that BB is a block containing of a single phi node "%a" and a branch to Succ. Now, since the definition of %a will dominate all of its uses, BB will dominate all blocks that use %a. Furthermore, since the branch from BB to Succ is unconditional, Succ will also dominate all uses of %a. Now, assume that one predecessor of Succ is not dominated by BB (and thus not dominated by Succ). Since at least one use of %a (but in reality all of them) is reachable from Succ, you could end up at a use of %a without passing through it's definition in BB (by coming from X through Succ). This is a contradiction, meaning that our original assumption is wrong. Thus, all predecessors of Succ must also be dominated by BB (and thus also by Succ). This means that moving the phi node %a from BB to Succ does not pose any problems when the two blocks are merged, and any use checks are not needed. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51478 91177308-0d34-0410-b5e6-96231b3b80d8 |
||
|---|---|---|
| .. | ||
| 2002-05-05-EmptyBlockMerge.ll | ||
| 2002-05-21-PHIElimination.ll | ||
| 2002-06-24-PHINode.ll | ||
| 2002-09-24-PHIAssertion.ll | ||
| 2003-03-07-DominateProblem.ll | ||
| 2003-08-05-InvokeCrash.ll | ||
| 2003-08-05-MishandleInvoke.ll | ||
| 2003-08-17-BranchFold.ll | ||
| 2003-08-17-BranchFoldOrdering.ll | ||
| 2003-08-17-FoldSwitch.ll | ||
| 2004-12-10-SimplifyCFGCrash.ll | ||
| 2005-06-16-PHICrash.ll | ||
| 2005-08-01-PHIUpdateFail.ll | ||
| 2005-08-03-PHIFactorCrash.ll | ||
| 2005-10-02-InvokeSimplify.ll | ||
| 2005-12-03-IncorrectPHIFold.ll | ||
| 2006-02-17-InfiniteUnroll.ll | ||
| 2006-06-12-InfLoop.ll | ||
| 2006-08-03-Crash.ll | ||
| 2006-10-19-UncondDiv.ll | ||
| 2006-10-29-InvokeCrash.ll | ||
| 2006-12-08-Ptr-ICmp-Branch.ll | ||
| 2007-11-22-InvokeNoUnwind.ll | ||
| 2007-12-21-Crash.ll | ||
| 2008-01-02-hoist-fp-add.ll | ||
| 2008-04-23-MergeMultipleResultRet.ll | ||
| 2008-04-27-MultipleReturnCrash.ll | ||
| 2008-05-16-PHIBlockMerge.ll | ||
| basictest.ll | ||
| branch-cond-merge.ll | ||
| branch-cond-prop.ll | ||
| branch-fold-test.ll | ||
| branch-fold.ll | ||
| branch-phi-thread.ll | ||
| BrUnwind.ll | ||
| DeadSetCC.ll | ||
| dg.exp | ||
| EqualPHIEdgeBlockMerge.ll | ||
| hoist-common-code.ll | ||
| HoistCode.ll | ||
| InvokeEliminate.ll | ||
| iterative-simplify.ll | ||
| noreturn-call.ll | ||
| PhiBlockMerge2.ll | ||
| PhiBlockMerge.ll | ||
| PhiEliminate2.ll | ||
| PhiEliminate.ll | ||
| PhiNoEliminate.ll | ||
| return-merge.ll | ||
| switch_create.ll | ||
| switch_formation.ll | ||
| switch_switch_fold.ll | ||
| switch_thread.ll | ||
| switch-simplify-crash.ll | ||
| two-entry-phi-return.ll | ||
| UncondBranchToReturn.ll | ||
| UnreachableEliminate.ll | ||