mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-11-04 06:09:05 +00:00
cf8b959e8d
`BlockAddress`es are interesting in that they can reference basic blocks
from *outside* the block's function. Since basic blocks are not global
values, this presents particular challenges for lazy parsing.
One corner case was found in PR11677 and fixed in r147425. In that
case, a global variable references a block address. It's necessary to
load the relevant function to resolve the forward reference before doing
anything with the module.
By inspection, I found (and have fixed here) two other cases:
- An instruction from one function references a block address from
another function, and only the first function is lazily loaded.
I fixed this the same way as PR11677: by eagerly loading the
referenced function.
- A function whose block address is taken is dematerialized, leaving
invalid references to it.
I fixed this by refusing to dematerialize functions whose block
addresses are taken (if you have to load it, you can't unload it).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214559 91177308-0d34-0410-b5e6-96231b3b80d8
144 lines
4.8 KiB
C++
144 lines
4.8 KiB
C++
//===- llvm/unittest/Bitcode/BitReaderTest.cpp - Tests for BitReader ------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/SmallString.h"
|
|
#include "llvm/Bitcode/BitstreamWriter.h"
|
|
#include "llvm/Bitcode/ReaderWriter.h"
|
|
#include "llvm/AsmParser/Parser.h"
|
|
#include "llvm/IR/Constants.h"
|
|
#include "llvm/IR/Instructions.h"
|
|
#include "llvm/IR/LLVMContext.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "llvm/IR/Verifier.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/MemoryBuffer.h"
|
|
#include "llvm/Support/SourceMgr.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
std::unique_ptr<Module> parseAssembly(const char *Assembly) {
|
|
auto M = make_unique<Module>("Module", getGlobalContext());
|
|
|
|
SMDiagnostic Error;
|
|
bool Parsed =
|
|
ParseAssemblyString(Assembly, M.get(), Error, M->getContext()) == M.get();
|
|
|
|
std::string ErrMsg;
|
|
raw_string_ostream OS(ErrMsg);
|
|
Error.print("", OS);
|
|
|
|
// A failure here means that the test itself is buggy.
|
|
if (!Parsed)
|
|
report_fatal_error(OS.str().c_str());
|
|
|
|
return M;
|
|
}
|
|
|
|
static void writeModuleToBuffer(std::unique_ptr<Module> Mod,
|
|
SmallVectorImpl<char> &Buffer) {
|
|
raw_svector_ostream OS(Buffer);
|
|
WriteBitcodeToFile(Mod.get(), OS);
|
|
}
|
|
|
|
static std::unique_ptr<Module> getLazyModuleFromAssembly(LLVMContext &Context,
|
|
SmallString<1024> &Mem,
|
|
const char *Assembly) {
|
|
writeModuleToBuffer(parseAssembly(Assembly), Mem);
|
|
MemoryBuffer *Buffer = MemoryBuffer::getMemBuffer(Mem.str(), "test", false);
|
|
ErrorOr<Module *> ModuleOrErr = getLazyBitcodeModule(Buffer, Context);
|
|
return std::unique_ptr<Module>(ModuleOrErr.get());
|
|
}
|
|
|
|
TEST(BitReaderTest, MaterializeFunctionsForBlockAddr) { // PR11677
|
|
SmallString<1024> Mem;
|
|
|
|
LLVMContext Context;
|
|
std::unique_ptr<Module> M = getLazyModuleFromAssembly(
|
|
Context, Mem, "@table = constant i8* blockaddress(@func, %bb)\n"
|
|
"define void @func() {\n"
|
|
" unreachable\n"
|
|
"bb:\n"
|
|
" unreachable\n"
|
|
"}\n");
|
|
EXPECT_FALSE(verifyModule(*M, &dbgs()));
|
|
|
|
// Try (and fail) to dematerialize @func.
|
|
M->getFunction("func")->Dematerialize();
|
|
EXPECT_FALSE(M->getFunction("func")->empty());
|
|
}
|
|
|
|
TEST(BitReaderTest, MaterializeFunctionsForBlockAddrInFunctionBefore) {
|
|
SmallString<1024> Mem;
|
|
|
|
LLVMContext Context;
|
|
std::unique_ptr<Module> M = getLazyModuleFromAssembly(
|
|
Context, Mem, "define i8* @before() {\n"
|
|
" ret i8* blockaddress(@func, %bb)\n"
|
|
"}\n"
|
|
"define void @other() {\n"
|
|
" unreachable\n"
|
|
"}\n"
|
|
"define void @func() {\n"
|
|
" unreachable\n"
|
|
"bb:\n"
|
|
" unreachable\n"
|
|
"}\n");
|
|
EXPECT_TRUE(M->getFunction("before")->empty());
|
|
EXPECT_TRUE(M->getFunction("func")->empty());
|
|
EXPECT_FALSE(verifyModule(*M, &dbgs()));
|
|
|
|
// Materialize @before, pulling in @func.
|
|
EXPECT_FALSE(M->getFunction("before")->Materialize());
|
|
EXPECT_FALSE(M->getFunction("func")->empty());
|
|
EXPECT_TRUE(M->getFunction("other")->empty());
|
|
EXPECT_FALSE(verifyModule(*M, &dbgs()));
|
|
|
|
// Try (and fail) to dematerialize @func.
|
|
M->getFunction("func")->Dematerialize();
|
|
EXPECT_FALSE(M->getFunction("func")->empty());
|
|
EXPECT_FALSE(verifyModule(*M, &dbgs()));
|
|
}
|
|
|
|
TEST(BitReaderTest, MaterializeFunctionsForBlockAddrInFunctionAfter) {
|
|
SmallString<1024> Mem;
|
|
|
|
LLVMContext Context;
|
|
std::unique_ptr<Module> M = getLazyModuleFromAssembly(
|
|
Context, Mem, "define void @func() {\n"
|
|
" unreachable\n"
|
|
"bb:\n"
|
|
" unreachable\n"
|
|
"}\n"
|
|
"define void @other() {\n"
|
|
" unreachable\n"
|
|
"}\n"
|
|
"define i8* @after() {\n"
|
|
" ret i8* blockaddress(@func, %bb)\n"
|
|
"}\n");
|
|
EXPECT_TRUE(M->getFunction("after")->empty());
|
|
EXPECT_TRUE(M->getFunction("func")->empty());
|
|
EXPECT_FALSE(verifyModule(*M, &dbgs()));
|
|
|
|
// Materialize @after, pulling in @func.
|
|
EXPECT_FALSE(M->getFunction("after")->Materialize());
|
|
EXPECT_FALSE(M->getFunction("func")->empty());
|
|
EXPECT_TRUE(M->getFunction("other")->empty());
|
|
EXPECT_FALSE(verifyModule(*M, &dbgs()));
|
|
|
|
// Try (and fail) to dematerialize @func.
|
|
M->getFunction("func")->Dematerialize();
|
|
EXPECT_FALSE(M->getFunction("func")->empty());
|
|
EXPECT_FALSE(verifyModule(*M, &dbgs()));
|
|
}
|
|
|
|
} // end namespace
|