Chris Lattner 120fce5540 Be far more careful when splitting a loop header, either to form a preheader ... or when splitting loops with a common header into multiple loops. In particular the old code would always insert the preheader before the old loop header. This is disasterous in cases where the loop hasn't been rotated. For example, it can produce code like: .. outside the loop... jmp LBB1_2 #bb13.outer LBB1_1: #bb1 movsd 8(%esp,%esi,8), %xmm1 mulsd (%edi), %xmm1 addsd %xmm0, %xmm1 addl $24, %edi incl %esi jmp LBB1_3 #bb13 LBB1_2: #bb13.outer leal (%edx,%eax,8), %edi pxor %xmm1, %xmm1 xorl %esi, %esi LBB1_3: #bb13 movapd %xmm1, %xmm0 cmpl $4, %esi jl LBB1_1 #bb1 Note that the loop body is actually LBB1_1 + LBB1_3, which means that the loop now contains an uncond branch WITHIN it to jump around the inserted loop header (LBB1_2). Doh. This patch changes the preheader insertion code to insert it in the right spot, producing this code: ... outside the loop, fall into the header ... LBB1_1: #bb13.outer leal (%edx,%eax,8), %esi pxor %xmm0, %xmm0 xorl %edi, %edi jmp LBB1_3 #bb13 LBB1_2: #bb1 movsd 8(%esp,%edi,8), %xmm0 mulsd (%esi), %xmm0 addsd %xmm1, %xmm0 addl $24, %esi incl %edi LBB1_3: #bb13 movapd %xmm0, %xmm1 cmpl $4, %edi jl LBB1_2 #bb1 Totally crazy, no branch in the loop! :) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@30587 91177308-0d34-0410-b5e6-96231b3b80d8		2006-09-23 08:19:21 +00:00
..
Hello	eliminate RegisterOpt. It does the same thing as RegisterPass.	2006-08-27 22:42:52 +00:00
Instrumentation	simplify AnalysisGroup registration, eliminating one typeid call.	2006-08-28 00:42:29 +00:00
IPO	Implement a trivial optzn: of vastart is never called in a function that takes	2006-09-18 07:02:31 +00:00
Scalar	Fix Transforms/IndVarsSimplify/2006-09-20-LFTR-Crash.ll	2006-09-21 05:12:20 +00:00
Utils	Be far more careful when splitting a loop header, either to form a preheader	2006-09-23 08:19:21 +00:00
ExprTypeConvert.cpp	Remove dead stuff	2006-05-12 23:32:01 +00:00
LevelRaise.cpp	eliminate RegisterOpt. It does the same thing as RegisterPass.	2006-08-27 22:42:52 +00:00
Makefile	DONT_BUILD_RELINKED is gone and implied by BUILD_ARCHIVE now	2005-10-24 02:26:13 +00:00
TransformInternals.cpp	Remove dead #include	2005-10-29 04:41:30 +00:00
TransformInternals.h	ConvertibleToGEP always returns 0, remove some old crufty code which	2005-07-26 16:38:28 +00:00