mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-15 20:29:48 +00:00
198d8baafb
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230786 91177308-0d34-0410-b5e6-96231b3b80d8
86 lines
3.5 KiB
LLVM
86 lines
3.5 KiB
LLVM
; RUN: llc %s -mcpu=core2 -o - | FileCheck %s
|
|
; This test was failing while tracking the liveness in the register scavenger
|
|
; during the branching folding pass. The allocation of the subregisters was
|
|
; incorrect.
|
|
; I.e., the faulty pattern looked like:
|
|
; CH = movb 64
|
|
; ECX = movl 3 <- CH was killed here.
|
|
; CH = subb CH, ...
|
|
;
|
|
; This reduced test case triggers the crash before the fix, but does not
|
|
; strictly speaking check that the resulting code is correct.
|
|
; To check that the code is actually correct we would need to check the
|
|
; liveness of the produced code.
|
|
;
|
|
; Currently, we check that after ECX = movl 3, we do not have subb CH,
|
|
; whereas CH could have been redefine in between and that would have been
|
|
; totally fine.
|
|
; <rdar://problem/16582185>
|
|
target datalayout = "e-m:o-p:32:32-f64:32:64-f80:128-n8:16:32-S128"
|
|
target triple = "i386-apple-macosx10.9"
|
|
|
|
%struct.A = type { %struct.B, %struct.C, %struct.D*, [1 x i8*] }
|
|
%struct.B = type { i32, [4 x i8] }
|
|
%struct.C = type { i128 }
|
|
%struct.D = type { {}*, [0 x i32] }
|
|
%union.E = type { i32 }
|
|
|
|
; CHECK-LABEL: __XXX1:
|
|
; CHECK: movl $3, %ecx
|
|
; CHECK-NOT: subb %{{[a-z]+}}, %ch
|
|
; Function Attrs: nounwind optsize ssp
|
|
define fastcc void @__XXX1(%struct.A* %ht) #0 {
|
|
entry:
|
|
%const72 = bitcast i128 72 to i128
|
|
%const3 = bitcast i128 3 to i128
|
|
switch i32 undef, label %if.end196 [
|
|
i32 1, label %sw.bb.i
|
|
i32 3, label %sw.bb2.i
|
|
]
|
|
|
|
sw.bb.i: ; preds = %entry
|
|
%call.i.i.i = tail call i32 undef(%struct.A* %ht, i8 zeroext 22, i32 undef, i32 0, %struct.D* undef)
|
|
%bf.load.i.i = load i128* undef, align 4
|
|
%bf.lshr.i.i = lshr i128 %bf.load.i.i, %const72
|
|
%shl1.i.i = shl nuw nsw i128 %bf.lshr.i.i, 8
|
|
%shl.i.i = trunc i128 %shl1.i.i to i32
|
|
br i1 undef, label %cond.false10.i.i, label %__XXX2.exit.i.i
|
|
|
|
__XXX2.exit.i.i: ; preds = %sw.bb.i
|
|
%extract11.i.i.i = lshr i128 %bf.load.i.i, %const3
|
|
%extract.t12.i.i.i = trunc i128 %extract11.i.i.i to i32
|
|
%bf.cast7.i.i.i = and i32 %extract.t12.i.i.i, 3
|
|
%arrayidx.i.i.i = getelementptr inbounds %struct.A, %struct.A* %ht, i32 0, i32 3, i32 %bf.cast7.i.i.i
|
|
br label %cond.end12.i.i
|
|
|
|
cond.false10.i.i: ; preds = %sw.bb.i
|
|
%arrayidx.i6.i.i = getelementptr inbounds %struct.A, %struct.A* %ht, i32 0, i32 3, i32 0
|
|
br label %cond.end12.i.i
|
|
|
|
cond.end12.i.i: ; preds = %cond.false10.i.i, %__XXX2.exit.i.i
|
|
%.sink.in.i.i = phi i8** [ %arrayidx.i.i.i, %__XXX2.exit.i.i ], [ %arrayidx.i6.i.i, %cond.false10.i.i ]
|
|
%.sink.i.i = load i8** %.sink.in.i.i, align 4
|
|
%tmp = bitcast i8* %.sink.i.i to %union.E*
|
|
br i1 undef, label %for.body.i.i, label %if.end196
|
|
|
|
for.body.i.i: ; preds = %for.body.i.i, %cond.end12.i.i
|
|
%weak.i.i = getelementptr inbounds %union.E, %union.E* %tmp, i32 undef, i32 0
|
|
%tmp1 = load i32* %weak.i.i, align 4
|
|
%cmp36.i.i = icmp ne i32 %tmp1, %shl.i.i
|
|
%or.cond = and i1 %cmp36.i.i, false
|
|
br i1 %or.cond, label %for.body.i.i, label %if.end196
|
|
|
|
sw.bb2.i: ; preds = %entry
|
|
%bf.lshr.i85.i = lshr i128 undef, %const72
|
|
br i1 undef, label %if.end196, label %__XXX2.exit.i95.i
|
|
|
|
__XXX2.exit.i95.i: ; preds = %sw.bb2.i
|
|
%extract11.i.i91.i = lshr i128 undef, %const3
|
|
br label %if.end196
|
|
|
|
if.end196: ; preds = %__XXX2.exit.i95.i, %sw.bb2.i, %for.body.i.i, %cond.end12.i.i, %entry
|
|
ret void
|
|
}
|
|
|
|
attributes #0 = { nounwind optsize ssp "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" }
|