mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-24 22:32:47 +00:00
6da21c0e33
That causes references to them to be weak references which can collapse to null if no definition is provided. We call these functions unconditionally, so a definition *must* be provided. Make the definitions provided in the .cpp file weak by re-declaring them as weak just prior to defining them. This should keep compilers which cannot attach the weak attribute to the definition happy while actually resolving the symbols correctly during the link. You might ask yourself upon reading this commit log: how did *any* of this work before? Well, fun story. It turns out we have some code in Support (BumpPtrAllocator) which both uses virtual dispatch and has out-of-line vtables used by that virtual dispatch. If you move the virtual dispatch into its header in *just* the right way, the optimizer gets to devirtualize, and remove all references to the vtable. Then the sad part: the references to this one vtable were the only strong symbol uses in the support library for llvm-tblgen AFAICT. At least, after doing something just like this, these symbols stopped getting their weak definition and random calls to them would segfault instead. Yay software. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205137 91177308-0d34-0410-b5e6-96231b3b80d8
74 lines
2.6 KiB
C++
74 lines
2.6 KiB
C++
//===- llvm/Support/Valgrind.h - Communication with Valgrind -----*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Methods for communicating with a valgrind instance this program is running
|
|
// under. These are all no-ops unless LLVM was configured on a system with the
|
|
// valgrind headers installed and valgrind is controlling this process.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_SUPPORT_VALGRIND_H
|
|
#define LLVM_SUPPORT_VALGRIND_H
|
|
|
|
#include "llvm/Config/llvm-config.h"
|
|
#include "llvm/Support/Compiler.h"
|
|
#include <stddef.h>
|
|
|
|
#if LLVM_ENABLE_THREADS != 0 && !defined(NDEBUG)
|
|
// tsan (Thread Sanitizer) is a valgrind-based tool that detects these exact
|
|
// functions by name.
|
|
extern "C" {
|
|
void AnnotateHappensAfter(const char *file, int line, const volatile void *cv);
|
|
void AnnotateHappensBefore(const char *file, int line, const volatile void *cv);
|
|
void AnnotateIgnoreWritesBegin(const char *file, int line);
|
|
void AnnotateIgnoreWritesEnd(const char *file, int line);
|
|
}
|
|
#endif
|
|
|
|
namespace llvm {
|
|
namespace sys {
|
|
// True if Valgrind is controlling this process.
|
|
bool RunningOnValgrind();
|
|
|
|
// Discard valgrind's translation of code in the range [Addr .. Addr + Len).
|
|
// Otherwise valgrind may continue to execute the old version of the code.
|
|
void ValgrindDiscardTranslations(const void *Addr, size_t Len);
|
|
|
|
#if LLVM_ENABLE_THREADS != 0 && !defined(NDEBUG)
|
|
// Thread Sanitizer is a valgrind tool that finds races in code.
|
|
// See http://code.google.com/p/data-race-test/wiki/DynamicAnnotations .
|
|
|
|
// This marker is used to define a happens-before arc. The race detector will
|
|
// infer an arc from the begin to the end when they share the same pointer
|
|
// argument.
|
|
#define TsanHappensBefore(cv) \
|
|
AnnotateHappensBefore(__FILE__, __LINE__, cv)
|
|
|
|
// This marker defines the destination of a happens-before arc.
|
|
#define TsanHappensAfter(cv) \
|
|
AnnotateHappensAfter(__FILE__, __LINE__, cv)
|
|
|
|
// Ignore any races on writes between here and the next TsanIgnoreWritesEnd.
|
|
#define TsanIgnoreWritesBegin() \
|
|
AnnotateIgnoreWritesBegin(__FILE__, __LINE__)
|
|
|
|
// Resume checking for racy writes.
|
|
#define TsanIgnoreWritesEnd() \
|
|
AnnotateIgnoreWritesEnd(__FILE__, __LINE__)
|
|
#else
|
|
#define TsanHappensBefore(cv)
|
|
#define TsanHappensAfter(cv)
|
|
#define TsanIgnoreWritesBegin()
|
|
#define TsanIgnoreWritesEnd()
|
|
#endif
|
|
}
|
|
}
|
|
|
|
#endif
|