mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-11-02 22:23:10 +00:00
b0d0a65e1d
Check that the `MDLocalVariable::getInlinedAt()` in a debug info
intrinsic's variable always matches the `MDLocation::getInlinedAt()` of
its `!dbg` attachment.
The goal here is to get rid of `MDLocalVariable::getInlinedAt()`
entirely (PR22778), since it's expensive and unnecessary, but I'll let
this verifier check bake for a while (a week maybe?) first. I've
updated the testcases that had the wrong value for `inlinedAt:`.
This checks that things are sane in the IR, but currently things go out
of whack in a few places in the backend. I'll follow shortly with
assertions in the backend (with code fixes).
If you have out-of-tree testcases that just started failing, here's how
I updated these ones:
1. The verifier check gives you the basic block, function, instruction,
and relevant metadata arguments (metadata numbering doesn't
necessarily match the source file, unfortunately).
2. Look at the `@llvm.dbg.*()` instruction, and compare the
`inlinedAt:` fields of the variable argument (second `metadata`
argument) and the `!dbg` attachment.
3. Figure out based on the variable `scope:` chain and the functions in
the file whether the variable has been inlined (and into what), so
you can determine which `inlinedAt:` is actually correct. In all of
the in-tree testcases, the `!MDLocation()` was correct and the
`!MDLocalVariable()` was wrong, but YMMV.
4. Duplicate the metadata that you're going to change, and add/drop the
`inlinedAt:` field from one of them. Be careful that the other
references to the same metadata node point at the correct one.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@234021 91177308-0d34-0410-b5e6-96231b3b80d8
62 lines
3.3 KiB
LLVM
62 lines
3.3 KiB
LLVM
; RUN: llc -mtriple mips-linux-gnu -O2 %s -o - | FileCheck %s
|
|
; Check struct X for dead variable xyz from inlined function foo.
|
|
|
|
; CHECK: section_info
|
|
; CHECK: DW_TAG_structure_type
|
|
; CHECK-NEXT: info_string
|
|
|
|
|
|
@i = common global i32 0 ; <i32*> [#uses=2]
|
|
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) nounwind readnone
|
|
|
|
declare void @llvm.dbg.value(metadata, i64, metadata, metadata) nounwind readnone
|
|
|
|
define i32 @bar() nounwind ssp {
|
|
entry:
|
|
%0 = load i32, i32* @i, align 4, !dbg !17 ; <i32> [#uses=2]
|
|
tail call void @llvm.dbg.value(metadata i32 %0, i64 0, metadata !59, metadata !MDExpression()), !dbg !19
|
|
tail call void @llvm.dbg.declare(metadata !29, metadata !60, metadata !MDExpression()), !dbg !21
|
|
%1 = mul nsw i32 %0, %0, !dbg !22 ; <i32> [#uses=2]
|
|
store i32 %1, i32* @i, align 4, !dbg !17
|
|
ret i32 %1, !dbg !23
|
|
}
|
|
|
|
!llvm.dbg.cu = !{!2}
|
|
!llvm.module.flags = !{!28}
|
|
|
|
!0 = !MDSubprogram(name: "foo", line: 9, isLocal: true, isDefinition: true, virtualIndex: 6, isOptimized: true, scopeLine: 9, file: !27, scope: !1, type: !3, variables: !24)
|
|
!1 = !MDFile(filename: "bar.c", directory: "/tmp/")
|
|
!2 = !MDCompileUnit(language: DW_LANG_C89, producer: "4.2.1 (Based on Apple Inc. build 5658) (LLVM build)", isOptimized: true, emissionKind: 0, file: !27, enums: !20, retainedTypes: !20, subprograms: !25, globals: !26, imports: !20)
|
|
!3 = !MDSubroutineType(types: !4)
|
|
!4 = !{!5, !5}
|
|
!5 = !MDBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!6 = !MDSubprogram(name: "bar", linkageName: "bar", line: 14, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: true, file: !27, scope: !1, type: !7, function: i32 ()* @bar)
|
|
!7 = !MDSubroutineType(types: !8)
|
|
!8 = !{!5}
|
|
!9 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "j", line: 9, arg: 0, scope: !0, file: !1, type: !5)
|
|
!10 = !MDLocalVariable(tag: DW_TAG_auto_variable, name: "xyz", line: 10, scope: !11, file: !1, type: !12)
|
|
|
|
!59 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "j", line: 9, arg: 0, scope: !0, file: !1, type: !5, inlinedAt: !17)
|
|
!60 = !MDLocalVariable(tag: DW_TAG_auto_variable, name: "xyz", line: 10, scope: !11, file: !1, type: !12, inlinedAt: !17)
|
|
|
|
!11 = distinct !MDLexicalBlock(line: 9, column: 0, file: !1, scope: !0)
|
|
!12 = !MDCompositeType(tag: DW_TAG_structure_type, name: "X", line: 10, size: 64, align: 32, file: !27, scope: !0, elements: !13)
|
|
!13 = !{!14, !15}
|
|
!14 = !MDDerivedType(tag: DW_TAG_member, name: "a", line: 10, size: 32, align: 32, file: !27, scope: !12, baseType: !5)
|
|
!15 = !MDDerivedType(tag: DW_TAG_member, name: "b", line: 10, size: 32, align: 32, offset: 32, file: !27, scope: !12, baseType: !5)
|
|
!16 = !MDGlobalVariable(name: "i", line: 5, isLocal: false, isDefinition: true, scope: !1, file: !1, type: !5, variable: i32* @i)
|
|
!17 = !MDLocation(line: 15, scope: !18)
|
|
!18 = distinct !MDLexicalBlock(line: 14, column: 0, file: !1, scope: !6)
|
|
!19 = !MDLocation(line: 9, scope: !0, inlinedAt: !17)
|
|
!20 = !{}
|
|
!21 = !MDLocation(line: 9, scope: !11, inlinedAt: !17)
|
|
!22 = !MDLocation(line: 11, scope: !11, inlinedAt: !17)
|
|
!23 = !MDLocation(line: 16, scope: !18)
|
|
!24 = !{!9, !10}
|
|
!25 = !{!0, !6}
|
|
!26 = !{!16}
|
|
!27 = !MDFile(filename: "bar.c", directory: "/tmp/")
|
|
!28 = !{i32 1, !"Debug Info Version", i32 3}
|
|
!29 = !{null}
|