mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-15 04:30:12 +00:00
8f2a85e099
This commit adds a weak variant of the cmpxchg operation, as described
in C++11. A cmpxchg instruction with this modifier is permitted to
fail to store, even if the comparison indicated it should.
As a result, cmpxchg instructions must return a flag indicating
success in addition to their original iN value loaded. Thus, for
uniformity *all* cmpxchg instructions now return "{ iN, i1 }". The
second flag is 1 when the store succeeded.
At the DAG level, a new ATOMIC_CMP_SWAP_WITH_SUCCESS node has been
added as the natural representation for the new cmpxchg instructions.
It is a strong cmpxchg.
By default this gets Expanded to the existing ATOMIC_CMP_SWAP during
Legalization, so existing backends should see no change in behaviour.
If they wish to deal with the enhanced node instead, they can call
setOperationAction on it. Beware: as a node with 2 results, it cannot
be selected from TableGen.
Currently, no use is made of the extra information provided in this
patch. Test updates are almost entirely adapting the input IR to the
new scheme.
Summary for out of tree users:
------------------------------
+ Legacy Bitcode files are upgraded during read.
+ Legacy assembly IR files will be invalid.
+ Front-ends must adapt to different type for "cmpxchg".
+ Backends should be unaffected by default.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@210903 91177308-0d34-0410-b5e6-96231b3b80d8
28 lines
927 B
LLVM
28 lines
927 B
LLVM
; RUN: llc < %s -march=x86 -mtriple=i386-apple-darwin | FileCheck %s
|
|
; PR8297
|
|
;
|
|
; On i386, i64 cmpxchg is lowered during legalize types to extract the
|
|
; 64-bit result into a pair of fixed regs. So creation of the DAG node
|
|
; happens in a different place. See
|
|
; X86TargetLowering::ReplaceNodeResults, case ATOMIC_CMP_SWAP.
|
|
;
|
|
; Neither Atomic-xx.ll nor atomic_op.ll cover this. Those tests were
|
|
; autogenerated from C source before 64-bit variants were supported.
|
|
;
|
|
; Note that this case requires a loop around the cmpxchg to force
|
|
; machine licm to query alias anlysis, exposing a bad
|
|
; MachineMemOperand.
|
|
define void @foo(i64* %ptr) nounwind inlinehint {
|
|
entry:
|
|
br label %loop
|
|
loop:
|
|
; CHECK: lock
|
|
; CHECK-NEXT: cmpxchg8b
|
|
%pair = cmpxchg i64* %ptr, i64 0, i64 1 monotonic monotonic
|
|
%r = extractvalue { i64, i1 } %pair, 0
|
|
%stored1 = icmp eq i64 %r, 0
|
|
br i1 %stored1, label %loop, label %continue
|
|
continue:
|
|
ret void
|
|
}
|