mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-07-21 18:29:45 +00:00
415b33f161
The function verifyFunction() in lib/IR/Verifier.cpp misses some calls. It creates a temporary FunctionPassManager that will run a single Verifier pass. Unfortunately, FunctionPassManager is no PassManager and does not call doInitialization() and doFinalization() by itself. Verifier does important tasks in doInitialization() such as collecting type information used to check DebugInfo metadata and doFinalization() does some additional checks. Therefore these checks were missed and debug info couldn't be verified at all, it just crashed if the function had some. verifyFunction() is currently not used in llvm unless -debug option is enabled, and in unittests/IR/VerifierTest.cpp VerifierTest had to be changed to create the function in a module from which the type debug info can be collected. Patch by Michael Kruse. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@193719 91177308-0d34-0410-b5e6-96231b3b80d8
82 lines
2.9 KiB
C++
82 lines
2.9 KiB
C++
//===- llvm/unittest/IR/VerifierTest.cpp - Verifier unit tests ------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Analysis/Verifier.h"
|
|
#include "llvm/ADT/OwningPtr.h"
|
|
#include "llvm/IR/Constants.h"
|
|
#include "llvm/IR/DerivedTypes.h"
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/IR/GlobalAlias.h"
|
|
#include "llvm/IR/GlobalVariable.h"
|
|
#include "llvm/IR/Instructions.h"
|
|
#include "llvm/IR/LLVMContext.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
namespace llvm {
|
|
namespace {
|
|
|
|
TEST(VerifierTest, Branch_i1) {
|
|
LLVMContext &C = getGlobalContext();
|
|
Module M("M", C);
|
|
FunctionType *FTy = FunctionType::get(Type::getVoidTy(C), /*isVarArg=*/false);
|
|
Function *F = cast<Function>(M.getOrInsertFunction("foo", FTy));
|
|
BasicBlock *Entry = BasicBlock::Create(C, "entry", F);
|
|
BasicBlock *Exit = BasicBlock::Create(C, "exit", F);
|
|
ReturnInst::Create(C, Exit);
|
|
|
|
// To avoid triggering an assertion in BranchInst::Create, we first create
|
|
// a branch with an 'i1' condition ...
|
|
|
|
Constant *False = ConstantInt::getFalse(C);
|
|
BranchInst *BI = BranchInst::Create(Exit, Exit, False, Entry);
|
|
|
|
// ... then use setOperand to redirect it to a value of different type.
|
|
|
|
Constant *Zero32 = ConstantInt::get(IntegerType::get(C, 32), 0);
|
|
BI->setOperand(0, Zero32);
|
|
|
|
EXPECT_TRUE(verifyFunction(*F, ReturnStatusAction));
|
|
}
|
|
|
|
TEST(VerifierTest, AliasUnnamedAddr) {
|
|
LLVMContext &C = getGlobalContext();
|
|
Module M("M", C);
|
|
Type *Ty = Type::getInt8Ty(C);
|
|
Constant *Init = Constant::getNullValue(Ty);
|
|
GlobalVariable *Aliasee = new GlobalVariable(M, Ty, true,
|
|
GlobalValue::ExternalLinkage,
|
|
Init, "foo");
|
|
GlobalAlias *GA = new GlobalAlias(Type::getInt8PtrTy(C),
|
|
GlobalValue::ExternalLinkage,
|
|
"bar", Aliasee, &M);
|
|
GA->setUnnamedAddr(true);
|
|
std::string Error;
|
|
EXPECT_TRUE(verifyModule(M, ReturnStatusAction, &Error));
|
|
EXPECT_TRUE(StringRef(Error).startswith("Alias cannot have unnamed_addr"));
|
|
}
|
|
|
|
TEST(VerifierTest, InvalidRetAttribute) {
|
|
LLVMContext &C = getGlobalContext();
|
|
Module M("M", C);
|
|
FunctionType *FTy = FunctionType::get(Type::getInt32Ty(C), /*isVarArg=*/false);
|
|
Function *F = cast<Function>(M.getOrInsertFunction("foo", FTy));
|
|
AttributeSet AS = F->getAttributes();
|
|
F->setAttributes(AS.addAttribute(C, AttributeSet::ReturnIndex,
|
|
Attribute::UWTable));
|
|
|
|
std::string Error;
|
|
EXPECT_TRUE(verifyModule(M, ReturnStatusAction, &Error));
|
|
EXPECT_TRUE(StringRef(Error).
|
|
startswith("Attribute 'uwtable' only applies to functions!"));
|
|
}
|
|
|
|
}
|
|
}
|