llvm-6502

mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-21 21:29:41 +00:00

History

Chandler Carruth 36b699f2b1 [C++11] Add range based accessors for the Use-Def chain of a Value.

This requires a number of steps.
1) Move value_use_iterator into the Value class as an implementation
detail
2) Change it to actually be a *Use* iterator rather than a *User*
iterator.
3) Add an adaptor which is a User iterator that always looks through the
Use to the User.
4) Wrap these in Value::use_iterator and Value::user_iterator typedefs.
5) Add the range adaptors as Value::uses() and Value::users().
6) Update *all* of the callers to correctly distinguish between whether
they wanted a use_iterator (and to explicitly dig out the User when
needed), or a user_iterator which makes the Use itself totally
opaque.

Because #6 requires churning essentially everything that walked the
Use-Def chains, I went ahead and added all of the range adaptors and
switched them to range-based loops where appropriate. Also because the
renaming requires at least churning every line of code, it didn't make
any sense to split these up into multiple commits -- all of which would
touch all of the same lies of code.

The result is still not quite optimal. The Value::use_iterator is a nice
regular iterator, but Value::user_iterator is an iterator over User*s
rather than over the User objects themselves. As a consequence, it fits
a bit awkwardly into the range-based world and it has the weird
extra-dereferencing 'operator->' that so many of our iterators have.
I think this could be fixed by providing something which transforms
a range of T&s into a range of T*s, but that *can* be separated into
another patch, and it isn't yet 100% clear whether this is the right
move.

However, this change gets us most of the benefit and cleans up
a substantial amount of code around Use and User. =]

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203364 91177308-0d34-0410-b5e6-96231b3b80d8

2014-03-09 03:16:01 +00:00

IPA

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

AliasAnalysis.cpp

[C++11] Make this interface accept const Use pointers and use override

2014-03-05 10:21:48 +00:00

AliasAnalysisCounter.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

AliasAnalysisEvaluator.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

AliasDebugger.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

AliasSetTracker.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

Analysis.cpp

[cleanup] Re-sort all the includes with utils/sort_includes.py.

2014-03-04 10:07:28 +00:00

BasicAliasAnalysis.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

BlockFrequencyInfo.cpp

[Modules] Move CFG.h to the IR library as it defines graph traits over

2014-03-04 11:45:46 +00:00

BranchProbabilityInfo.cpp

[Modules] Move CFG.h to the IR library as it defines graph traits over

2014-03-04 11:45:46 +00:00

CaptureTracking.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

CFG.cpp

Make succ_iterator a real random access iterator and clean up a couple of users.

2014-02-10 14:17:42 +00:00

CFGPrinter.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

CMakeLists.txt

[PM] Add a new "lazy" call graph analysis pass for the new pass manager.

2014-02-06 04:37:03 +00:00

CodeMetrics.cpp

[Modules] Move CallSite into the IR library where it belogs. It is

2014-03-04 11:01:28 +00:00

ConstantFolding.cpp

Allow constant folding of round function whenever feasible

2014-03-07 04:36:21 +00:00

CostModel.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

Delinearization.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

DependenceAnalysis.cpp

[Modules] Move InstIterator out of the Support library, where it had no

2014-03-04 10:30:26 +00:00

DominanceFrontier.cpp

[PM] Split DominatorTree into a concrete analysis result object which

2014-01-13 13:07:17 +00:00

DomPrinter.cpp

[PM] Split DominatorTree into a concrete analysis result object which

2014-01-13 13:07:17 +00:00

InstCount.cpp

[Layering] Move InstVisitor.h into the IR library as it is pretty

2014-03-06 03:23:41 +00:00

InstructionSimplify.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

Interval.cpp

[Modules] Move CFG.h to the IR library as it defines graph traits over

2014-03-04 11:45:46 +00:00

IntervalPartition.cpp

…

IVUsers.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

LazyCallGraph.cpp

[Layering] Move InstVisitor.h into the IR library as it is pretty

2014-03-06 03:23:41 +00:00

LazyValueInfo.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

LibCallAliasAnalysis.cpp

Move all of the header files which are involved in modelling the LLVM IR

2013-01-02 11:36:10 +00:00

LibCallSemantics.cpp

Move all of the header files which are involved in modelling the LLVM IR

2013-01-02 11:36:10 +00:00

Lint.cpp

Teach lint about address spaces

2014-03-06 17:33:55 +00:00

LLVMBuild.txt

LLVMBuild: Introduce a common section which currently has a list of the

2011-12-12 22:45:54 +00:00

Loads.cpp

Change GetPointerBaseWithConstantOffset's DataLayout argument from a

2013-01-31 02:00:45 +00:00

LoopInfo.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

LoopPass.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

Makefile

…

MemDepPrinter.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

MemoryBuiltins.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

MemoryDependenceAnalysis.cpp

Replace OwningPtr<T> with std::unique_ptr<T>.

2014-03-06 05:51:42 +00:00

ModuleDebugInfoPrinter.cpp

[Layering] Move DebugInfo.h into the IR library where its implementation

2014-03-06 00:46:21 +00:00

NoAliasAnalysis.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

PHITransAddr.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

PostDominators.cpp

[Modules] Move CFG.h to the IR library as it defines graph traits over

2014-03-04 11:45:46 +00:00

PtrUseVisitor.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

README.txt

…

RegionInfo.cpp

[C++11] Add a basic block range view for RegionInfo

2014-03-03 13:00:39 +00:00

RegionPass.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

RegionPrinter.cpp

[C++11] Add a basic block range view for RegionInfo

2014-03-03 13:00:39 +00:00

ScalarEvolution.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

ScalarEvolutionAliasAnalysis.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

ScalarEvolutionExpander.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

ScalarEvolutionNormalization.cpp

[cleanup] Move the Dominators.h and Verifier.h headers into the IR

2014-01-13 09:26:24 +00:00

SparsePropagation.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

TargetTransformInfo.cpp

[Modules] Move CallSite into the IR library where it belogs. It is

2014-03-04 11:01:28 +00:00

Trace.cpp

Put the functionality for printing a value to a raw_ostream as an

2014-01-09 02:29:41 +00:00

TypeBasedAliasAnalysis.cpp

[C++11] Add 'override' keyword to virtual methods that override their base class.

2014-03-05 07:30:04 +00:00

ValueTracking.cpp

[C++11] Add range based accessors for the Use-Def chain of a Value.

2014-03-09 03:16:01 +00:00

README.txt

Analysis Opportunities:

//===---------------------------------------------------------------------===//

In test/Transforms/LoopStrengthReduce/quadradic-exit-value.ll, the
ScalarEvolution expression for %r is this:

  {1,+,3,+,2}<loop>

Outside the loop, this could be evaluated simply as (%n * %n), however
ScalarEvolution currently evaluates it as

  (-2 + (2 * (trunc i65 (((zext i64 (-2 + %n) to i65) * (zext i64 (-1 + %n) to i65)) /u 2) to i64)) + (3 * %n))

In addition to being much more complicated, it involves i65 arithmetic,
which is very inefficient when expanded into code.

//===---------------------------------------------------------------------===//

In formatValue in test/CodeGen/X86/lsr-delayed-fold.ll,

ScalarEvolution is forming this expression:

((trunc i64 (-1 * %arg5) to i32) + (trunc i64 %arg5 to i32) + (-1 * (trunc i64 undef to i32)))

This could be folded to

(-1 * (trunc i64 undef to i32))

//===---------------------------------------------------------------------===//