mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-01-21 03:32:21 +00:00
b0d0a65e1d
Check that the `MDLocalVariable::getInlinedAt()` in a debug info
intrinsic's variable always matches the `MDLocation::getInlinedAt()` of
its `!dbg` attachment.
The goal here is to get rid of `MDLocalVariable::getInlinedAt()`
entirely (PR22778), since it's expensive and unnecessary, but I'll let
this verifier check bake for a while (a week maybe?) first. I've
updated the testcases that had the wrong value for `inlinedAt:`.
This checks that things are sane in the IR, but currently things go out
of whack in a few places in the backend. I'll follow shortly with
assertions in the backend (with code fixes).
If you have out-of-tree testcases that just started failing, here's how
I updated these ones:
1. The verifier check gives you the basic block, function, instruction,
and relevant metadata arguments (metadata numbering doesn't
necessarily match the source file, unfortunately).
2. Look at the `@llvm.dbg.*()` instruction, and compare the
`inlinedAt:` fields of the variable argument (second `metadata`
argument) and the `!dbg` attachment.
3. Figure out based on the variable `scope:` chain and the functions in
the file whether the variable has been inlined (and into what), so
you can determine which `inlinedAt:` is actually correct. In all of
the in-tree testcases, the `!MDLocation()` was correct and the
`!MDLocalVariable()` was wrong, but YMMV.
4. Duplicate the metadata that you're going to change, and add/drop the
`inlinedAt:` field from one of them. Be careful that the other
references to the same metadata node point at the correct one.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@234021 91177308-0d34-0410-b5e6-96231b3b80d8
74 lines
3.4 KiB
LLVM
74 lines
3.4 KiB
LLVM
; RUN: llc -mtriple=x86_64-linux-gnu -fast-isel=false -filetype=obj < %s -o - | llvm-dwarfdump -debug-dump=info - | FileCheck %s
|
|
; RUN: llc -mtriple=x86_64-linux-gnu -fast-isel=false -filetype=asm < %s -o - | FileCheck --check-prefix=ASM %s
|
|
|
|
; Generated from:
|
|
; clang-tot -c -S -emit-llvm -g inline-seldag-test.c
|
|
; inline int __attribute__((always_inline)) f(int y) {
|
|
; return y ? 4 : 7;
|
|
; }
|
|
; void func() {
|
|
; volatile int x;
|
|
; x = f(x);
|
|
; }
|
|
|
|
; CHECK: DW_TAG_inlined_subroutine
|
|
; CHECK-NEXT: DW_AT_abstract_origin {{.*}} "f"
|
|
|
|
|
|
; Make sure the condition test is attributed to the inline function, not the
|
|
; location of the test's operands within the caller.
|
|
|
|
; ASM: # inline-seldag-test.c:2:0
|
|
; ASM-NOT: .loc
|
|
; ASM: testl
|
|
|
|
; Function Attrs: nounwind uwtable
|
|
define void @func() #0 {
|
|
entry:
|
|
%y.addr.i = alloca i32, align 4
|
|
%x = alloca i32, align 4
|
|
call void @llvm.dbg.declare(metadata i32* %x, metadata !15, metadata !MDExpression()), !dbg !17
|
|
%0 = load volatile i32, i32* %x, align 4, !dbg !18
|
|
store i32 %0, i32* %y.addr.i, align 4
|
|
call void @llvm.dbg.declare(metadata i32* %y.addr.i, metadata !19, metadata !MDExpression()), !dbg !20
|
|
%1 = load i32, i32* %y.addr.i, align 4, !dbg !21
|
|
%tobool.i = icmp ne i32 %1, 0, !dbg !21
|
|
%cond.i = select i1 %tobool.i, i32 4, i32 7, !dbg !21
|
|
store volatile i32 %cond.i, i32* %x, align 4, !dbg !18
|
|
ret void, !dbg !22
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) #1
|
|
|
|
attributes #0 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
attributes #1 = { nounwind readnone }
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!12, !13}
|
|
!llvm.ident = !{!14}
|
|
|
|
!0 = !MDCompileUnit(language: DW_LANG_C99, producer: "clang version 3.5.0 ", isOptimized: false, emissionKind: 1, file: !1, enums: !2, retainedTypes: !2, subprograms: !3, globals: !2, imports: !2)
|
|
!1 = !MDFile(filename: "inline-seldag-test.c", directory: "/tmp/dbginfo")
|
|
!2 = !{}
|
|
!3 = !{!4, !8}
|
|
!4 = !MDSubprogram(name: "func", line: 4, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: false, scopeLine: 4, file: !1, scope: !5, type: !6, function: void ()* @func, variables: !2)
|
|
!5 = !MDFile(filename: "inline-seldag-test.c", directory: "/tmp/dbginfo")
|
|
!6 = !MDSubroutineType(types: !7)
|
|
!7 = !{null}
|
|
!8 = !MDSubprogram(name: "f", line: 1, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, scopeLine: 1, file: !1, scope: !5, type: !9, variables: !2)
|
|
!9 = !MDSubroutineType(types: !10)
|
|
!10 = !{!11, !11}
|
|
!11 = !MDBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!12 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!13 = !{i32 1, !"Debug Info Version", i32 3}
|
|
!14 = !{!"clang version 3.5.0 "}
|
|
!15 = !MDLocalVariable(tag: DW_TAG_auto_variable, name: "x", line: 5, scope: !4, file: !5, type: !16)
|
|
!16 = !MDDerivedType(tag: DW_TAG_volatile_type, baseType: !11)
|
|
!17 = !MDLocation(line: 5, scope: !4)
|
|
!18 = !MDLocation(line: 6, column: 7, scope: !4)
|
|
!19 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "y", line: 1, arg: 1, scope: !8, file: !5, type: !11, inlinedAt: !18)
|
|
!20 = !MDLocation(line: 1, scope: !8, inlinedAt: !18)
|
|
!21 = !MDLocation(line: 2, scope: !8, inlinedAt: !18)
|
|
!22 = !MDLocation(line: 7, scope: !4)
|