mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-17 18:31:04 +00:00
c9ad3ab624
The pass used to be enabled by default with CodeGenOpt::Less (-O1). This is too aggressive, considering the pass indiscriminately merges all globals together. Currently, performance doesn't always improve, and, on code that uses few globals (e.g., the odd file- or function- static), more often than not is degraded by the optimization. Lengthy discussion can be found on llvmdev (AArch64-focused; ARM has similar problems): http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-February/082800.html Also, it makes tooling and debuggers less useful when dealing with globals and data sections. GlobalMerge needs to better identify those cases that benefit, and this will be done separately. In the meantime, move the pass to run with -O3 rather than -O1, on both ARM and AArch64. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@233024 91177308-0d34-0410-b5e6-96231b3b80d8
28 lines
1.2 KiB
LLVM
28 lines
1.2 KiB
LLVM
; RUN: llc %s -mtriple=aarch64-none-linux-gnu -O3 -enable-global-merge -o - | FileCheck %s
|
|
; RUN: llc %s -mtriple=aarch64-none-linux-gnu -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s
|
|
|
|
; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -o - | FileCheck %s
|
|
; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s
|
|
|
|
; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS
|
|
; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS
|
|
|
|
@m = internal global i32 0, align 4
|
|
@n = internal global i32 0, align 4
|
|
|
|
define void @f1(i32 %a1, i32 %a2) {
|
|
;CHECK-APPLE-IOS-NOT: adrp
|
|
;CHECK-APPLE-IOS: adrp x8, __MergedGlobals@PAGE
|
|
;CHECK-APPLE-IOS-NOT: adrp
|
|
;CHECK-APPLE-IOS: add x8, x8, __MergedGlobals@PAGEOFF
|
|
store i32 %a1, i32* @m, align 4
|
|
store i32 %a2, i32* @n, align 4
|
|
ret void
|
|
}
|
|
|
|
;CHECK: .type _MergedGlobals,@object // @_MergedGlobals
|
|
;CHECK: .local _MergedGlobals
|
|
;CHECK: .comm _MergedGlobals,8,8
|
|
|
|
;CHECK-APPLE-IOS: .zerofill __DATA,__bss,__MergedGlobals,8,3 ; @_MergedGlobals
|