mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-15 04:30:12 +00:00
b0d0a65e1d
Check that the `MDLocalVariable::getInlinedAt()` in a debug info
intrinsic's variable always matches the `MDLocation::getInlinedAt()` of
its `!dbg` attachment.
The goal here is to get rid of `MDLocalVariable::getInlinedAt()`
entirely (PR22778), since it's expensive and unnecessary, but I'll let
this verifier check bake for a while (a week maybe?) first. I've
updated the testcases that had the wrong value for `inlinedAt:`.
This checks that things are sane in the IR, but currently things go out
of whack in a few places in the backend. I'll follow shortly with
assertions in the backend (with code fixes).
If you have out-of-tree testcases that just started failing, here's how
I updated these ones:
1. The verifier check gives you the basic block, function, instruction,
and relevant metadata arguments (metadata numbering doesn't
necessarily match the source file, unfortunately).
2. Look at the `@llvm.dbg.*()` instruction, and compare the
`inlinedAt:` fields of the variable argument (second `metadata`
argument) and the `!dbg` attachment.
3. Figure out based on the variable `scope:` chain and the functions in
the file whether the variable has been inlined (and into what), so
you can determine which `inlinedAt:` is actually correct. In all of
the in-tree testcases, the `!MDLocation()` was correct and the
`!MDLocalVariable()` was wrong, but YMMV.
4. Duplicate the metadata that you're going to change, and add/drop the
`inlinedAt:` field from one of them. Be careful that the other
references to the same metadata node point at the correct one.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@234021 91177308-0d34-0410-b5e6-96231b3b80d8
144 lines
6.2 KiB
LLVM
144 lines
6.2 KiB
LLVM
; REQUIRES: object-emission
|
|
|
|
; RUN: %llc_dwarf -O0 -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck -implicit-check-not=DW_TAG %s
|
|
; RUN: %llc_dwarf -dwarf-accel-tables=Enable -O0 -filetype=obj < %s | llvm-dwarfdump - | FileCheck --check-prefix=CHECK-ACCEL --check-prefix=CHECK %s
|
|
|
|
; Build from source:
|
|
; $ clang++ a.cpp b.cpp -g -c -emit-llvm
|
|
; $ llvm-link a.bc b.bc -o ab.bc
|
|
; $ opt -inline ab.bc -o ab-opt.bc
|
|
; $ cat a.cpp
|
|
; extern int i;
|
|
; int func(int);
|
|
; int main() {
|
|
; return func(i);
|
|
; }
|
|
; $ cat b.cpp
|
|
; int __attribute__((always_inline)) func(int x) {
|
|
; return x * 2;
|
|
; }
|
|
|
|
; Ensure that func inlined into main is described and references the abstract
|
|
; definition in b.cpp's CU.
|
|
|
|
; CHECK: DW_TAG_compile_unit
|
|
; CHECK: DW_AT_name {{.*}} "a.cpp"
|
|
; CHECK: DW_TAG_subprogram
|
|
; CHECK: DW_AT_type [DW_FORM_ref_addr] (0x00000000[[INT:.*]])
|
|
; CHECK: 0x[[INLINED:[0-9a-f]*]]:{{.*}}DW_TAG_inlined_subroutine
|
|
; CHECK: DW_AT_abstract_origin {{.*}}[[ABS_FUNC:........]] "_Z4funci"
|
|
; CHECK: DW_TAG_formal_parameter
|
|
; CHECK: DW_AT_abstract_origin {{.*}}[[ABS_VAR:........]] "x"
|
|
|
|
; Check the abstract definition is in the 'b.cpp' CU and doesn't contain any
|
|
; concrete information (address range or variable location)
|
|
; CHECK: DW_TAG_compile_unit
|
|
; CHECK: DW_AT_name {{.*}} "b.cpp"
|
|
; CHECK: 0x[[ABS_FUNC]]: DW_TAG_subprogram
|
|
; CHECK-NOT: DW_AT_low_pc
|
|
; CHECK: 0x[[ABS_VAR]]: DW_TAG_formal_parameter
|
|
; CHECK-NOT: DW_AT_location
|
|
; CHECK: DW_AT_type [DW_FORM_ref4] {{.*}} {0x[[INT]]}
|
|
; CHECK-NOT: DW_AT_location
|
|
|
|
; CHECK: 0x[[INT]]: DW_TAG_base_type
|
|
; CHECK: DW_AT_name {{.*}} "int"
|
|
|
|
; Check the concrete out of line definition references the abstract and
|
|
; provides the address range and variable location
|
|
; CHECK: 0x[[FUNC:[0-9a-f]*]]{{.*}}DW_TAG_subprogram
|
|
; CHECK: DW_AT_low_pc
|
|
; CHECK: DW_AT_abstract_origin {{.*}} {0x[[ABS_FUNC]]} "_Z4funci"
|
|
; CHECK: DW_TAG_formal_parameter
|
|
; CHECK: DW_AT_location
|
|
; CHECK: DW_AT_abstract_origin {{.*}} {0x[[ABS_VAR]]} "x"
|
|
|
|
; Check that both the inline and the non out of line version of func are
|
|
; correctly referenced in the accelerator table. Before r221837, the one
|
|
; in the second compilation unit had a wrong offset
|
|
; CHECK-ACCEL: .apple_names contents:
|
|
; CHECK-ACCEL: Name{{.*}}"func"
|
|
; CHECK-ACCEL-NOT: Name
|
|
; CHECK-ACCEL: Atom[0]{{.*}}[[INLINED]]
|
|
; CHECK-ACCEL-NOT: Name
|
|
; CHECK-ACCEL: Atom[0]{{.*}}[[FUNC]]
|
|
|
|
@i = external global i32
|
|
|
|
; Function Attrs: uwtable
|
|
define i32 @main() #0 {
|
|
entry:
|
|
%x.addr.i = alloca i32, align 4
|
|
%retval = alloca i32, align 4
|
|
store i32 0, i32* %retval
|
|
%0 = load i32, i32* @i, align 4, !dbg !19
|
|
%1 = bitcast i32* %x.addr.i to i8*
|
|
call void @llvm.lifetime.start(i64 4, i8* %1)
|
|
store i32 %0, i32* %x.addr.i, align 4
|
|
call void @llvm.dbg.declare(metadata i32* %x.addr.i, metadata !120, metadata !MDExpression()), !dbg !21
|
|
%2 = load i32, i32* %x.addr.i, align 4, !dbg !22
|
|
%mul.i = mul nsw i32 %2, 2, !dbg !22
|
|
%3 = bitcast i32* %x.addr.i to i8*, !dbg !22
|
|
call void @llvm.lifetime.end(i64 4, i8* %3), !dbg !22
|
|
ret i32 %mul.i, !dbg !19
|
|
}
|
|
|
|
; Function Attrs: alwaysinline nounwind uwtable
|
|
define i32 @_Z4funci(i32 %x) #1 {
|
|
entry:
|
|
%x.addr = alloca i32, align 4
|
|
store i32 %x, i32* %x.addr, align 4
|
|
call void @llvm.dbg.declare(metadata i32* %x.addr, metadata !20, metadata !MDExpression()), !dbg !23
|
|
%0 = load i32, i32* %x.addr, align 4, !dbg !24
|
|
%mul = mul nsw i32 %0, 2, !dbg !24
|
|
ret i32 %mul, !dbg !24
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) #2
|
|
|
|
; Function Attrs: nounwind
|
|
declare void @llvm.lifetime.start(i64, i8* nocapture) #3
|
|
|
|
; Function Attrs: nounwind
|
|
declare void @llvm.lifetime.end(i64, i8* nocapture) #3
|
|
|
|
attributes #0 = { uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
attributes #1 = { alwaysinline nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
attributes #2 = { nounwind readnone }
|
|
attributes #3 = { nounwind }
|
|
|
|
!llvm.dbg.cu = !{!0, !9}
|
|
!llvm.module.flags = !{!16, !17}
|
|
!llvm.ident = !{!18, !18}
|
|
|
|
!0 = !MDCompileUnit(language: DW_LANG_C_plus_plus, producer: "clang version 3.5.0 ", isOptimized: false, emissionKind: 1, file: !1, enums: !2, retainedTypes: !2, subprograms: !3, globals: !2, imports: !2)
|
|
!1 = !MDFile(filename: "a.cpp", directory: "/tmp/dbginfo")
|
|
!2 = !{}
|
|
!3 = !{!4}
|
|
!4 = !MDSubprogram(name: "main", line: 3, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, scopeLine: 3, file: !1, scope: !5, type: !6, function: i32 ()* @main, variables: !2)
|
|
!5 = !MDFile(filename: "a.cpp", directory: "/tmp/dbginfo")
|
|
!6 = !MDSubroutineType(types: !7)
|
|
!7 = !{!8}
|
|
!8 = !MDBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!9 = !MDCompileUnit(language: DW_LANG_C_plus_plus, producer: "clang version 3.5.0 ", isOptimized: false, emissionKind: 1, file: !10, enums: !2, retainedTypes: !2, subprograms: !11, globals: !2, imports: !2)
|
|
!10 = !MDFile(filename: "b.cpp", directory: "/tmp/dbginfo")
|
|
!11 = !{!12}
|
|
!12 = !MDSubprogram(name: "func", linkageName: "_Z4funci", line: 1, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, scopeLine: 1, file: !10, scope: !13, type: !14, function: i32 (i32)* @_Z4funci, variables: !2)
|
|
!13 = !MDFile(filename: "b.cpp", directory: "/tmp/dbginfo")
|
|
!14 = !MDSubroutineType(types: !15)
|
|
!15 = !{!8, !8}
|
|
!16 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!17 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!18 = !{!"clang version 3.5.0 "}
|
|
!19 = !MDLocation(line: 4, scope: !4)
|
|
!20 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "x", line: 1, arg: 1, scope: !12, file: !13, type: !8)
|
|
|
|
!120 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "x", line: 1, arg: 1, scope: !12, file: !13, type: !8, inlinedAt: !19)
|
|
|
|
!21 = !MDLocation(line: 1, scope: !12, inlinedAt: !19)
|
|
!22 = !MDLocation(line: 2, scope: !12, inlinedAt: !19)
|
|
!23 = !MDLocation(line: 1, scope: !12)
|
|
!24 = !MDLocation(line: 2, scope: !12)
|
|
|