mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-02-25 03:30:37 +00:00
5e195a4c8d
When MC was first added, targets could use hasRawTextSupport to keep features working before they were added to the MC interface. The design goal of MC is to provide an uniform api for printing assembly and object files. Short of relaxations and other corner cases, a object file is just another representation of the assembly. It was never the intention that targets would keep doing things like if (hasRawTextSupport()) Set flags in one way. else Set flags in another way. When they do that they create two code paths and the object file is no longer just another representation of the assembly. This also then requires testing with llc -filetype=obj, which is extremelly brittle. This patch removes some of these hacks by replacing them with smaller ones. The ARM flag setting is trivial, so I just moved it to the constructor. For Mips, the patch adds two temporary hack directives that allow the assembly to represent the same things as the object file was already able to. The hope is that the mips developers will replace the hack directives with the same ones that gas uses and drop the -print-hack-directives flag. I will also try to implement a target streamer interface, so that we can move this out of the common code. In summary, for any new work, two rules of the thumb are * Don't use "llc -filetype=obj" in tests. * Don't add calls to hasRawTextSupport. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192035 91177308-0d34-0410-b5e6-96231b3b80d8
56 lines
1.8 KiB
C++
56 lines
1.8 KiB
C++
//===-- MipsELFStreamer.cpp - MipsELFStreamer ---------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===-------------------------------------------------------------------===//
|
|
#include "MipsSubtarget.h"
|
|
#include "llvm/MC/MCAssembler.h"
|
|
#include "llvm/MC/MCELF.h"
|
|
#include "llvm/MC/MCELFStreamer.h"
|
|
#include "llvm/MC/MCELFSymbolFlags.h"
|
|
#include "llvm/MC/MCSymbol.h"
|
|
#include "llvm/Support/ELF.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
class MipsELFStreamer : public MCELFStreamer {
|
|
public:
|
|
MipsELFStreamer(MCContext &Context, MCAsmBackend &TAB, raw_ostream &OS,
|
|
MCCodeEmitter *Emitter, bool RelaxAll, bool NoExecStack)
|
|
: MCELFStreamer(Context, TAB, OS, Emitter) {}
|
|
|
|
~MipsELFStreamer() {}
|
|
void emitMipsHackELFFlags(unsigned Flags);
|
|
void emitMipsHackSTOCG(MCSymbol *Sym, unsigned Val);
|
|
};
|
|
}
|
|
|
|
namespace llvm {
|
|
MCELFStreamer *createMipsELFStreamer(MCContext &Context, MCAsmBackend &TAB,
|
|
raw_ostream &OS, MCCodeEmitter *Emitter,
|
|
bool RelaxAll, bool NoExecStack) {
|
|
MipsELFStreamer *S =
|
|
new MipsELFStreamer(Context, TAB, OS, Emitter, RelaxAll, NoExecStack);
|
|
return S;
|
|
}
|
|
} // namespace llvm
|
|
|
|
void MipsELFStreamer::emitMipsHackELFFlags(unsigned Flags) {
|
|
MCAssembler &MCA = getAssembler();
|
|
|
|
MCA.setELFHeaderEFlags(Flags);
|
|
}
|
|
|
|
// Set a symbol's STO flags
|
|
void MipsELFStreamer::emitMipsHackSTOCG(MCSymbol *Sym, unsigned Val) {
|
|
MCSymbolData &Data = getOrCreateSymbolData(Sym);
|
|
// The "other" values are stored in the last 6 bits of the second byte
|
|
// The traditional defines for STO values assume the full byte and thus
|
|
// the shift to pack it.
|
|
MCELF::setOther(Data, Val >> 2);
|
|
}
|