Chandler Carruth b3dca3f50e Revert the business end of r164636 and try again. I'll come in again. ;] ... This should really, really fix PR13916. For real this time. The underlying bug is... a bit more subtle than I had imagined. The setup is a code pattern that leads to an @llvm.memcpy call with two equal pointers to an alloca in the source and dest. Now, not any pattern will do. The alloca needs to be formed just so, and both pointers should be wrapped in different bitcasts etc. When this precise pattern hits, a funny sequence of events transpires. First, we correctly detect the potential for overlap, and correctly optimize the memcpy. The first time. However, we do simplify the set of users of the alloca, and that causes us to run the alloca back through the SROA pass in case there are knock-on simplifications. At this point, a curious thing has happened. If we happen to have an i8 alloca, we have direct i8 pointer values. So we don't bother creating a cast, we rewrite the arguments to the memcpy to dircetly refer to the alloca. Now, in an unrelated area of the pass, we have clever logic which ensures that when visiting each User of a particular pointer derived from an alloca, we only visit that User once, and directly inspect all of its operands which refer to that particular pointer value. However, the mechanism used to detect memcpy's with the potential to overlap relied upon getting visited once per *Use*, not once per *User*. This is always true *unless* the same exact value is both source and dest. It turns out that almost nothing actually produces that pattern though. We can hand craft test cases that more directly test this behavior of course, and those are included. Also, note that there is a significant missed optimization here -- we prove in many cases that there is a non-volatile memcpy call with identical source and dest addresses. We shouldn't prevent splitting the alloca in that case, and in fact we should just remove such memcpy calls eagerly. I'll address that in a subsequent commit. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@164669 91177308-0d34-0410-b5e6-96231b3b80d8		2012-09-26 07:41:40 +00:00
..
Hello
InstCombine	Move Attribute::typeIncompatible inside of the Attributes class.	2012-09-25 20:38:59 +00:00
Instrumentation	s/__llvm_gcov_flush/__gcov_flush/g	2012-09-17 17:57:05 +00:00
IPO	Move Attribute::typeIncompatible inside of the Attributes class.	2012-09-25 20:38:59 +00:00
Scalar	Revert the business end of r164636 and try again. I'll come in again. ;]	2012-09-26 07:41:40 +00:00
Utils	Rename virtual table anchors from Anchor() to anchor() for consistency with the rest of the tree.	2012-09-26 06:36:36 +00:00
Vectorize	Make MemoryBuiltins aware of TargetLibraryInfo.	2012-08-29 15:32:21 +00:00
CMakeLists.txt
LLVMBuild.txt
Makefile