llvm-6502/test/MC/ARM/directive-arch_extension-crc.s
Saleem Abdulrasool 77b9fc127b ARM: correct handling of features in arch_extension
The subtarget information is the ultimate source of truth for the feature set
that is enabled at this point.  We would previously not propagate the feature
information to the subtarget.  While this worked for the most part (features
would be enabled/disabled as requested), if another operation that changed the
feature bits was encountered (such as a mode switch via a .arm or .thumb
directive), we would end up resetting the behaviour of the architectural
extensions.

Handling this properly requires a slightly more complicated handling.  We need
to check if the feature is now being toggled.  If so, only then do we toggle the
features.  In return, we no longer have to calculate the feature bits ourselves.

The test changes are mostly to the diagnosis, which is now more uniform (a nice
side effect!).  Add an additional test to ensure that we handle this case
properly.

Thanks to Nico Weber for alerting me to this issue!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214057 91177308-0d34-0410-b5e6-96231b3b80d8
2014-07-27 19:07:09 +00:00

58 lines
1.8 KiB
ArmAsm

@ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
@ RUN: | FileCheck %s -check-prefix CHECK-V7
@ RUN: not llvm-mc -triple armv8-eabi -filetype asm -o /dev/null 2>&1 %s \
@ RUN: | FileCheck %s -check-prefix CHECK-V8
.syntax unified
.arm
.arch_extension crc
@ CHECK-V7: error: architectural extension 'crc' is not allowed for the current base architecture
@ CHECK-V7-NEXT: .arch_extension crc
@ CHECK-V7-NEXT: ^
.type crc,%function
crc:
crc32b r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
crc32h r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
crc32w r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
crc32cb r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
crc32ch r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
crc32cw r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
.arch_extension nocrc
@ CHECK-V7: error: architectural extension 'crc' is not allowed for the current base architecture
@ CHECK-V7-NEXT: .arch_extension nocrc
@ CHECK-V7-NEXT: ^
.type nocrc,%function
nocrc:
crc32b r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
@ CHECK-V8: error: instruction requires: crc
crc32h r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
@ CHECK-V8: error: instruction requires: crc
crc32w r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
@ CHECK-V8: error: instruction requires: crc
crc32cb r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
@ CHECK-V8: error: instruction requires: crc
crc32ch r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
@ CHECK-V8: error: instruction requires: crc
crc32cw r0, r1, r2
@ CHECK-V7: error: instruction requires: crc armv8
@ CHECK-V8: error: instruction requires: crc