Hal Finkel 8f609696e0 Improve BasicAA CS-CS queries (redux) ... This reverts, "r213024 - Revert r212572 "improve BasicAA CS-CS queries", it causes PR20303." with a fix for the bug in pr20303. As it turned out, the relevant code was both wrong and over-conservative (because, as with the code it replaced, it would return the overall ModRef mask even if just Ref had been implied by the argument aliasing results). Hopefully, this correctly fixes both problems. Thanks to Nick Lewycky for reducing the test case for pr20303 (which I've cleaned up a little and added in DSE's test directory). The BasicAA test has also been updated to check for this error. Original commit message: BasicAA contains knowledge of certain intrinsics, such as memcpy and memset, and uses that information to form more-accurate answers to CallSite vs. Loc ModRef queries. Unfortunately, it did not use this information when answering CallSite vs. CallSite queries. Generically, when an intrinsic takes one or more pointers and the intrinsic is marked only to read/write from its arguments, the offset/size is unknown. As a result, the generic code that answers CallSite vs. CallSite (and CallSite vs. Loc) queries in AA uses UnknownSize when forming Locs from an intrinsic's arguments. While BasicAA's CallSite vs. Loc override could use more-accurate size information for some intrinsics, it did not do the same for CallSite vs. CallSite queries. This change refactors the intrinsic-specific logic in BasicAA into a generic AA query function: getArgLocation, which is overridden by BasicAA to supply the intrinsic-specific knowledge, and used by AA's generic implementation. This allows the intrinsic-specific knowledge to be used by both CallSite vs. Loc and CallSite vs. CallSite queries, and simplifies the BasicAA implementation. Currently, only one function, Mac's memset_pattern16, is handled by BasicAA (all the rest are intrinsics). As a side-effect of this refactoring, BasicAA's getModRefBehavior override now also returns OnlyAccessesArgumentPointees for this function (which is an improvement). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@213219 91177308-0d34-0410-b5e6-96231b3b80d8		2014-07-17 01:28:25 +00:00
..
AliasAnalysis.h	Improve BasicAA CS-CS queries (redux)	2014-07-17 01:28:25 +00:00
AliasSetTracker.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
BlockFrequencyInfo.h	blockfreq: Remove unnecessary template parameters	2014-04-11 23:21:02 +00:00
BlockFrequencyInfoImpl.h	BFI: Add constructor for Weight	2014-07-12 00:26:00 +00:00
BranchProbabilityInfo.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
CallGraph.h	Replace OwningPtr<T> with std::unique_ptr<T>.	2014-03-06 05:51:42 +00:00
CallGraphSCCPass.h	[C++11] Add 'override' keyword to virtual methods that override their base class.	2014-03-05 07:30:04 +00:00
CallPrinter.h	Added -view-callgraph module pass.	2013-01-11 17:28:14 +00:00
CaptureTracking.h	[C++11] Make this interface accept const Use pointers and use override	2014-03-05 10:21:48 +00:00
CFG.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
CFGPrinter.h	Revert "Introduce a string_ostream string builder facilty"	2014-06-26 22:52:05 +00:00
CGSCCPassManager.h	[LCG] Normalize the post-order SCC iterator to just iterate over the SCC	2014-04-23 23:51:07 +00:00
CodeMetrics.h	[Modules] Move CallSite into the IR library where it belogs. It is	2014-03-04 11:01:28 +00:00
ConstantFolding.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-14 00:51:57 +00:00
ConstantsScanner.h	[Modules] Move InstIterator out of the Support library, where it had no	2014-03-04 10:30:26 +00:00
DependenceAnalysis.h	remove constant terms	2014-05-27 22:41:45 +00:00
DominanceFrontier.h	Try to fix MSVC build	2014-07-12 22:19:49 +00:00
DominanceFrontierImpl.h	Try to fix MSVC warning.	2014-07-12 23:16:26 +00:00
DomPrinter.h
DOTGraphTraitsPass.h	raw_ostream: Forward declare OpenFlags and include FileSystem.h only where necessary.	2014-04-29 23:26:49 +00:00
FindUsedTypes.h	[C++11] Add 'override' keyword to virtual methods that override their base class.	2014-03-05 07:30:04 +00:00
InlineCost.h	[C++11] Add 'override' keyword to virtual methods that override their base class.	2014-03-05 07:30:04 +00:00
InstructionSimplify.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-14 00:51:57 +00:00
Interval.h	Remove copy ctors that did the same thing as the default one.	2014-03-11 11:32:49 +00:00
IntervalIterator.h	[Modules] Move CFG.h to the IR library as it defines graph traits over	2014-03-04 11:45:46 +00:00
IntervalPartition.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
IVUsers.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
JumpInstrTableInfo.h	Add a new attribute called 'jumptable' that creates jump-instruction tables for functions marked with this attribute.	2014-06-05 19:29:43 +00:00
LazyCallGraph.h	Fix typos	2014-05-15 01:52:21 +00:00
LazyValueInfo.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
LibCallAliasAnalysis.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
LibCallSemantics.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
Lint.h
Loads.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
LoopInfo.h	Add optimization remarks to the loop unroller and vectorizer.	2014-04-29 14:27:31 +00:00
LoopInfoImpl.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-14 00:51:57 +00:00
LoopIterator.h	Remove unneeded #includes.	2013-02-09 13:29:10 +00:00
LoopPass.h	[C++11] Add 'override' keyword to virtual methods that override their base class.	2014-03-05 07:30:04 +00:00
MemoryBuiltins.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
MemoryDependenceAnalysis.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
Passes.h	Add a new attribute called 'jumptable' that creates jump-instruction tables for functions marked with this attribute.	2014-06-05 19:29:43 +00:00
PHITransAddr.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
PostDominators.h	[C++11] Add 'override' keyword to virtual methods that override their base class.	2014-03-05 07:30:04 +00:00
PtrUseVisitor.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
RegionInfo.h	DominanceInfo is strongly preferred over RegionInfo	2014-07-08 22:51:03 +00:00
RegionIterator.h	[Modules] Move CFG.h to the IR library as it defines graph traits over	2014-03-04 11:45:46 +00:00
RegionPass.h	[C++11] Add 'override' keyword to virtual methods that override their base class.	2014-03-05 07:30:04 +00:00
RegionPrinter.h
ScalarEvolution.h	Partially fix PR20058: reduce compile time for loop unrolling with very high count by reducing calls to SE->forgetLoop	2014-07-10 23:30:06 +00:00
ScalarEvolutionExpander.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
ScalarEvolutionExpressions.h	removed circular definitions in comments	2014-07-14 21:51:59 +00:00
ScalarEvolutionNormalization.h	Fix include guards so they exactly match file names.	2013-01-10 00:45:19 +00:00
SparsePropagation.h	[C++11] More 'nullptr' conversion. In some cases just using a boolean check instead of comparing to nullptr.	2014-04-15 04:59:12 +00:00
TargetFolder.h	Add CreatePointerBitCastOrAddrSpaceCast to IRBuilder and co.	2014-07-14 17:24:35 +00:00
TargetTransformInfo.h	Add Support to Recognize and Vectorize NON SIMD instructions in SLPVectorizer.	2014-06-20 04:32:48 +00:00
Trace.h	Fix include guards so they exactly match file names.	2013-01-10 00:45:19 +00:00
ValueTracking.h	[ValueTracking] Extend range metadata to call/invoke	2014-06-19 16:50:16 +00:00