llvm-6502/lib/AsmParser
Duncan P. N. Exon Smith 9b18dbfe83 Optimize metadata node fields for CHECK-ability
While gaining practical experience hand-updating CHECK lines (for moving
the new debug info hierarchy into place),  I learnt a few things about
CHECK-ability of the specialized node assembly output.

  - The first part of a `CHECK:` is to identify the "right" node (this
    is especially true if you intend to use the new `CHECK-SAME`
    feature, since the first CHECK needs to identify the node correctly
    before you can split the line).
      - If there's a `tag:`, it should go first.
      - If there's a `name:`, it should go next (followed by the
        `linkageName:`, if any).
      - If there's a `scope:`, it should follow after that.
  - When a node type supports multiple DW_TAGs, but one is implied by
    its name and is overwhelmingly more common, the `tag:` field is
    terribly uninteresting unless it's different.
      - `MDBasicType` is almost always `DW_TAG_base_type`.
      - `MDTemplateValueParameter` is almost always
        `DW_TAG_template_value_parameter`.
  - Printing `name: ""` doesn't improve CHECK-ability, and there are far
    more nodes than I realized that are commonly nameless.
  - There are a few other fields that similarly aren't very interesting
    when they're empty.

This commit updates the `AsmWriter` as suggested above (and makes
necessary changes in `LLParser` for round-tripping).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230877 91177308-0d34-0410-b5e6-96231b3b80d8
2015-02-28 23:21:38 +00:00
..
CMakeLists.txt Use ADDITIONAL_HEADER_DIRS in all LLVM CMake projects. 2015-02-11 03:28:02 +00:00
LLLexer.cpp AsmParser/Writer: Handle symbolic constants in DI 'flags:' 2015-02-21 01:02:18 +00:00
LLLexer.h AsmParser: Don't crash if a null byte is inside a quoted string 2014-12-10 00:43:17 +00:00
LLParser.cpp Optimize metadata node fields for CHECK-ability 2015-02-28 23:21:38 +00:00
LLParser.h AsmWriter/Bitcode: MDSubprogram 2015-02-13 01:26:47 +00:00
LLToken.h AsmParser/Writer: Handle symbolic constants in DI 'flags:' 2015-02-21 01:02:18 +00:00
LLVMBuild.txt
Makefile
module.modulemap [modules] Add module maps for LLVM. These are not quite ready for prime-time 2014-05-21 02:46:14 +00:00
Parser.cpp Remove std::move that was preventing return value optimization. 2015-01-17 00:46:44 +00:00