Chandler Carruth ed1951e79f Fix an issue where SROA computed different results based on the relative ... order of slices of the alloca which have exactly the same size and other properties. This was found by a perniciously unstable sort implementation used to flush out buggy uses of the algorithm. The fundamental idea is that findCommonType should return the best common type it can find across all of the slices in the range. There were two bugs here previously: 1) We would accept an integer type smaller than a byte-width multiple, and if there were different bit-width integer types, we would accept the first one. This caused an actual failure in the testcase updated here when the sort order changed. 2) If we found a bad combination of types or a non-load, non-store use before an integer typed load or store we would bail, but if we found the integere typed load or store, we would use it. The correct behavior is to always use an integer typed operation which covers the partition if one exists. While a clever debugging sort algorithm found problem #1 in our existing test cases, I have no useful test case ideas for #2. I spotted in by inspection when looking at this code. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195118 91177308-0d34-0410-b5e6-96231b3b80d8		2013-11-19 09:03:18 +00:00
..
alignment.ll
basictest.ll	Fix an issue where SROA computed different results based on the relative	2013-11-19 09:03:18 +00:00
big-endian.ll
fca.ll
phi-and-select.ll
vector-conversion.ll	SROA: Handle casts involving vectors of pointers and integer scalars.	2013-09-21 20:36:04 +00:00
vector-promotion.ll
vectors-of-pointers.ll