mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-21 00:32:23 +00:00
d761cc1dfa
Consider this use from the new testcase:
LSR Use: Kind=ICmpZero, Offsets={0}, widest fixup type: i32
reg({1000,+,-1}<nw><%for.body>)
-3003 + reg({3,+,3}<nw><%for.body>)
-1001 + reg({1,+,1}<nuw><nsw><%for.body>)
-1000 + reg({0,+,1}<nw><%for.body>)
-3000 + reg({0,+,3}<nuw><%for.body>)
reg({-1000,+,1}<nw><%for.body>)
reg({-3000,+,3}<nsw><%for.body>)
This is the last use we consider for a solution in SolveRecurse, so CurRegs is
a large set. (CurRegs is the set of registers that are needed by the
previously visited uses in the in-progress solution.)
ReqRegs is {
{3,+,3}<nw><%for.body>,
{1,+,1}<nuw><nsw><%for.body>
}
This is the intersection of the regs used by any of the formulas for the
current use and CurRegs.
Now, the code requires a formula to contain *all* these regs (the comment is
simply wrong), otherwise the formula is immediately disqualified. Obviously,
no formula for this use contains two regs so they will all get disqualified.
The fix modifies the check to allow the formula in this case. The idea is
that neither of these formulae is introducing any new registers which is the
point of this early pruning as far as I understand.
In terms of set arithmetic, we now allow formulas whose used regs are a subset
of the required regs not just the other way around.
There are few more loops in the test-suite that are now successfully LSRed. I
have benchmarked those and found very minimal change.
Fixes <rdar://problem/13965777>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@207271 91177308-0d34-0410-b5e6-96231b3b80d8
|
||
|---|---|---|
| .. | ||
| ARM | ||
| ARM64 | ||
| X86 | ||
| 2005-08-15-AddRecIV.ll | ||
| 2005-08-17-OutOfLoopVariant.ll | ||
| 2005-09-12-UsesOutOutsideOfLoop.ll | ||
| 2007-04-23-UseIterator.ll | ||
| 2008-08-13-CmpStride.ll | ||
| 2008-09-09-Overflow.ll | ||
| 2009-01-13-nonconstant-stride-outside-loop.ll | ||
| 2009-04-28-no-reduce-mul.ll | ||
| 2011-07-19-CritEdgeBreakCrash.ll | ||
| 2011-10-03-CritEdgeMerge.ll | ||
| 2011-10-06-ReusePhi.ll | ||
| 2011-10-13-SCEVChain.ll | ||
| 2011-10-14-IntPtr.ll | ||
| 2011-12-19-PostincQuadratic.ll | ||
| 2012-01-02-nopreheader.ll | ||
| 2012-01-16-nopreheader.ll | ||
| 2012-03-15-nopreheader.ll | ||
| 2012-03-26-constexpr.ll | ||
| 2012-07-13-ExpandUDiv.ll | ||
| 2012-07-18-LimitReassociate.ll | ||
| 2013-01-05-IndBr.ll | ||
| 2013-01-14-ReuseCast.ll | ||
| addrec-gep-address-space.ll | ||
| addrec-gep.ll | ||
| address-space-loop.ll | ||
| count-to-zero.ll | ||
| dead-phi.ll | ||
| different-type-ivs.ll | ||
| dominate-assert.ll | ||
| dont_insert_redundant_ops.ll | ||
| dont_reduce_bytes.ll | ||
| dont_reverse.ll | ||
| dont-hoist-simple-loop-constants.ll | ||
| exit_compare_live_range.ll | ||
| hoist-parent-preheader.ll | ||
| invariant_value_first_arg.ll | ||
| invariant_value_first.ll | ||
| ivchain.ll | ||
| lsr-expand-quadratic.ll | ||
| nested-reduce.ll | ||
| nonlinear-postinc.ll | ||
| ops_after_indvar.ll | ||
| phi_node_update_multiple_preds.ll | ||
| post-inc-icmpzero.ll | ||
| pr2537.ll | ||
| pr2570.ll | ||
| pr3086.ll | ||
| pr3399.ll | ||
| pr3571.ll | ||
| pr12018.ll | ||
| pr12048.ll | ||
| pr12691.ll | ||
| pr18165.ll | ||
| preserve-gep-loop-variant.ll | ||
| quadradic-exit-value.ll | ||
| related_indvars.ll | ||
| remove_indvar.ll | ||
| scaling_factor_cost_crash.ll | ||
| share_code_in_preheader.ll | ||
| share_ivs.ll | ||
| uglygep-address-space.ll | ||
| uglygep.ll | ||
| use_postinc_value_outside_loop.ll | ||
| var_stride_used_by_compare.ll | ||
| variable_stride.ll | ||