mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-07-21 02:29:22 +00:00
14fc08301c
This fixes a regression introduced at revision 231243. The target-independent selection algorithm in FastISel knows how to select a SINT_TO_FP if the target is SSE but not AVX. That is because on X86, the tablegen'd 'fastEmit' functions know how to select CVTSI2SSrr and CVTSI2SDrr. Method X86FastISel::X86SelectSIToFP was therefore working under the wrong assumption that the target was AVX. That assumption was incorrect since we can have a target that is neither AVX nor SSE. So, rather than asserting for the presence of AVX, we should have had an early exit from 'X86SelectSIToFP' if the target was not AVX. This patch fixes the issue replacing the invalid assertion with an early exit. Thanks to Dimitry Andric for reporting this problem and for providing a small reproducible testcase. Added test pr23273.ll. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235295 91177308-0d34-0410-b5e6-96231b3b80d8
18 lines
535 B
LLVM
18 lines
535 B
LLVM
; RUN: llc -mtriple=i386-unknown-unknown -mcpu=generic -march=x86 -mattr=-sse2 -fast-isel < %s
|
|
|
|
; Verify that the backend doesn't crash during fast-isel with an assertion
|
|
; failure when selecting a int-to-double conversion. The fast selection routine
|
|
; for SINT_TO_FP wrongly assumed that the target had at least SSE2.
|
|
|
|
@a = common global i32 0, align 4
|
|
|
|
define i32 @pr23273() {
|
|
entry:
|
|
%0 = load i32, i32* @a, align 4
|
|
%conv = sitofp i32 %0 to double
|
|
%call = call i32 @fn1(double %conv)
|
|
ret i32 0
|
|
}
|
|
|
|
declare i32 @fn1(double) #1
|