mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-15 04:30:12 +00:00
b0d0a65e1d
Check that the `MDLocalVariable::getInlinedAt()` in a debug info
intrinsic's variable always matches the `MDLocation::getInlinedAt()` of
its `!dbg` attachment.
The goal here is to get rid of `MDLocalVariable::getInlinedAt()`
entirely (PR22778), since it's expensive and unnecessary, but I'll let
this verifier check bake for a while (a week maybe?) first. I've
updated the testcases that had the wrong value for `inlinedAt:`.
This checks that things are sane in the IR, but currently things go out
of whack in a few places in the backend. I'll follow shortly with
assertions in the backend (with code fixes).
If you have out-of-tree testcases that just started failing, here's how
I updated these ones:
1. The verifier check gives you the basic block, function, instruction,
and relevant metadata arguments (metadata numbering doesn't
necessarily match the source file, unfortunately).
2. Look at the `@llvm.dbg.*()` instruction, and compare the
`inlinedAt:` fields of the variable argument (second `metadata`
argument) and the `!dbg` attachment.
3. Figure out based on the variable `scope:` chain and the functions in
the file whether the variable has been inlined (and into what), so
you can determine which `inlinedAt:` is actually correct. In all of
the in-tree testcases, the `!MDLocation()` was correct and the
`!MDLocalVariable()` was wrong, but YMMV.
4. Duplicate the metadata that you're going to change, and add/drop the
`inlinedAt:` field from one of them. Be careful that the other
references to the same metadata node point at the correct one.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@234021 91177308-0d34-0410-b5e6-96231b3b80d8
|
||
|---|---|---|
| .. | ||
| AsmWriter.cpp | ||
| AttributeImpl.h | ||
| Attributes.cpp | ||
| AutoUpgrade.cpp | ||
| BasicBlock.cpp | ||
| CMakeLists.txt | ||
| Comdat.cpp | ||
| ConstantFold.cpp | ||
| ConstantFold.h | ||
| ConstantRange.cpp | ||
| Constants.cpp | ||
| ConstantsContext.h | ||
| Core.cpp | ||
| DataLayout.cpp | ||
| DebugInfo.cpp | ||
| DebugInfoMetadata.cpp | ||
| DebugLoc.cpp | ||
| DiagnosticInfo.cpp | ||
| DiagnosticPrinter.cpp | ||
| DIBuilder.cpp | ||
| Dominators.cpp | ||
| Function.cpp | ||
| GCOV.cpp | ||
| Globals.cpp | ||
| GVMaterializer.cpp | ||
| InlineAsm.cpp | ||
| Instruction.cpp | ||
| Instructions.cpp | ||
| IntrinsicInst.cpp | ||
| IRBuilder.cpp | ||
| IRPrintingPasses.cpp | ||
| LegacyPassManager.cpp | ||
| LLVMBuild.txt | ||
| LLVMContext.cpp | ||
| LLVMContextImpl.cpp | ||
| LLVMContextImpl.h | ||
| Makefile | ||
| Mangler.cpp | ||
| MDBuilder.cpp | ||
| Metadata.cpp | ||
| MetadataImpl.h | ||
| MetadataTracking.cpp | ||
| Module.cpp | ||
| module.modulemap | ||
| Pass.cpp | ||
| PassManager.cpp | ||
| PassRegistry.cpp | ||
| Statepoint.cpp | ||
| SymbolTableListTraitsImpl.h | ||
| Type.cpp | ||
| TypeFinder.cpp | ||
| Use.cpp | ||
| UseListOrder.cpp | ||
| User.cpp | ||
| Value.cpp | ||
| ValueSymbolTable.cpp | ||
| ValueTypes.cpp | ||
| Verifier.cpp | ||