llvm-6502/invalid-mdnode-badref.ll at b11d8102cfb0bbe2480ea239393cfa261e55a1d6 - llvm-6502 - Applefritter: Git

6502/llvm-6502

mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-13 04:30:23 +00:00

Duncan P. N. Exon Smith 003346177c IR: Update references to temporaries before deleting

During `MDNode::deleteTemporary()`, call `replaceAllUsesWith(nullptr)`
to update all tracking references to `nullptr`.

This fixes PR22280, where inverted destruction order between tracking
references and the temporaries themselves caused a use-after-free in
`LLParser`.

An alternative fix would be to add an assertion that there are no users,
and continue to fix inverted destruction order in clients (like
`LLParser`), but instead I decided to make getting-teardown-right easy.
(If someone disagrees let me know.)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@226866 91177308-0d34-0410-b5e6-96231b3b80d8

2015-01-22 21:36:45 +00:00

6 lines

154 B

LLVM

Raw Blame History

 ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
 !named = !{!0}
 ; CHECK: [[@LINE+1]]:14: error: use of undefined metadata '!1'
 !0 = !{!0, !1}