Kevin Enderby bf2712ae43 To allow the X86 verbose assembly to print its informative comments ... when used with symbolic disassembly, add a check that the operand is an immediate and has not been symbolicated to MCExpr operand. I’m trying to enable the ‘C’ disassembly API option LLVMDisassembler_Option_SetInstrComments for darwin’s otool(1) that uses the llvm disassembler API. The problem is that the disassembler API can change an immediate operand to an MCExpr operand if it symbolicates it with the call backs. And if it does the code in llvm::EmitAnyX86InstComments() will crash when it assumes these operands are immediates. The fix for this is very straight forward to just protect the call to getImm() with a check of isImm(). So if the immediate for an instruction is symbolicated it simply doesn’t get the X86 verbose assembly comments: % otool -tV test_asm.o test_asm.o: (__TEXT,__text) section _t1: 0000000000000000 vpshufd $_t1, %xmm1, %xmm0 0000000000000005 retq 0000000000000006 nopw %cs:_t1(%rax,%rax) _t2: 0000000000000010 vpshufd $-0x1, %xmm0, %xmm0 ## xmm0 = xmm0[3,3,3,3] 0000000000000015 retq 0000000000000016 nopw %cs:_t1(%rax,%rax) _t3: 0000000000000020 vpshufd $_t1, %xmm1, %xmm0 0000000000000025 retq 0000000000000026 nopw %cs:_t1(%rax,%rax) _t4: 0000000000000030 vpshufd $0x2d, %xmm0, %xmm0 ## xmm0 = xmm0[1,3,2,0] 0000000000000035 retq The fact that the immediate $0x0 is being symbolicated at all in this case is a different problem which my next patch will address. rdar://10989286 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199697 91177308-0d34-0410-b5e6-96231b3b80d8		2014-01-21 00:18:51 +00:00
..
Analysis	[PM] Make the verifier work independently of any pass manager.	2014-01-19 02:22:18 +00:00
AsmParser	Add an inalloca flag to allocas	2014-01-17 23:58:17 +00:00
Bitcode	Make parseBitcodeFile return an ErrorOr<Module *>.	2014-01-15 01:08:23 +00:00
CodeGen	Update StackProtector when coloring merges stack slots	2014-01-20 19:49:14 +00:00
DebugInfo	llvm-dwarfdump: type unit dwo support	2014-01-09 05:08:24 +00:00
ExecutionEngine	Attempt to fix the MSVC build.	2014-01-16 05:09:32 +00:00
IR	[PM] Wire up the Verifier for the new pass manager and connect it to the	2014-01-20 11:34:08 +00:00
IRReader	Make parseBitcodeFile return an ErrorOr<Module *>.	2014-01-15 01:08:23 +00:00
Linker	Reapply r194218 with fix:	2014-01-16 06:29:36 +00:00
LTO	[LTO] Add a hook to map LLVM diagnostics into the clients of LTO.	2014-01-15 22:04:35 +00:00
MC	ARM: add tlsldo relocation	2014-01-20 11:00:40 +00:00
Object	80-column.	2014-01-17 22:11:27 +00:00
Option
Support	[x86] Support i386-*-*-code16 triple for emitting 16-bit code	2014-01-20 12:02:25 +00:00
TableGen	[TableGen] Correctly generate implicit anonymous prototype defs in multiclasses	2014-01-02 20:47:09 +00:00
Target	To allow the X86 verbose assembly to print its informative comments	2014-01-21 00:18:51 +00:00
Transforms	Fix all the remaining lost-fast-math-flags bugs I've been able to find. The most important of these are cases in the generic logic for combining BinaryOperators.	2014-01-20 07:44:53 +00:00
CMakeLists.txt
LLVMBuild.txt
Makefile