mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-27 15:29:51 +00:00
713aa9431d
This is essentially a ground up re-think of the SROA pass in LLVM. It was initially inspired by a few problems with the existing pass: - It is subject to the bane of my existence in optimizations: arbitrary thresholds. - It is overly conservative about which constructs can be split and promoted. - The vector value replacement aspect is separated from the splitting logic, missing many opportunities where splitting and vector value formation can work together. - The splitting is entirely based around the underlying type of the alloca, despite this type often having little to do with the reality of how that memory is used. This is especially prevelant with unions and base classes where we tail-pack derived members. - When splitting fails (often due to the thresholds), the vector value replacement (again because it is separate) can kick in for preposterous cases where we simply should have split the value. This results in forming i1024 and i2048 integer "bit vectors" that tremendously slow down subsequnet IR optimizations (due to large APInts) and impede the backend's lowering. The new design takes an approach that fundamentally is not susceptible to many of these problems. It is the result of a discusison between myself and Duncan Sands over IRC about how to premptively avoid these types of problems and how to do SROA in a more principled way. Since then, it has evolved and grown, but this remains an important aspect: it fixes real world problems with the SROA process today. First, the transform of SROA actually has little to do with replacement. It has more to do with splitting. The goal is to take an aggregate alloca and form a composition of scalar allocas which can replace it and will be most suitable to the eventual replacement by scalar SSA values. The actual replacement is performed by mem2reg (and in the future SSAUpdater). The splitting is divided into four phases. The first phase is an analysis of the uses of the alloca. This phase recursively walks uses, building up a dense datastructure representing the ranges of the alloca's memory actually used and checking for uses which inhibit any aspects of the transform such as the escape of a pointer. Once we have a mapping of the ranges of the alloca used by individual operations, we compute a partitioning of the used ranges. Some uses are inherently splittable (such as memcpy and memset), while scalar uses are not splittable. The goal is to build a partitioning that has the minimum number of splits while placing each unsplittable use in its own partition. Overlapping unsplittable uses belong to the same partition. This is the target split of the aggregate alloca, and it maximizes the number of scalar accesses which become accesses to their own alloca and candidates for promotion. Third, we re-walk the uses of the alloca and assign each specific memory access to all the partitions touched so that we have dense use-lists for each partition. Finally, we build a new, smaller alloca for each partition and rewrite each use of that partition to use the new alloca. During this phase the pass will also work very hard to transform uses of an alloca into a form suitable for promotion, including forming vector operations, speculating loads throguh PHI nodes and selects, etc. After splitting is complete, each newly refined alloca that is a candidate for promotion to a scalar SSA value is run through mem2reg. There are lots of reasonably detailed comments in the source code about the design and algorithms, and I'm going to be trying to improve them in subsequent commits to ensure this is well documented, as the new pass is in many ways more complex than the old one. Some of this is still a WIP, but the current state is reasonbly stable. It has passed bootstrap, the nightly test suite, and Duncan has run it successfully through the ACATS and DragonEgg test suites. That said, it remains behind a default-off flag until the last few pieces are in place, and full testing can be done. Specific areas I'm looking at next: - Improved comments and some code cleanup from reviews. - SSAUpdater and enabling this pass inside the CGSCC pass manager. - Some datastructure tuning and compile-time measurements. - More aggressive FCA splitting and vector formation. Many thanks to Duncan Sands for the thorough final review, as well as Benjamin Kramer for lots of review during the process of writing this pass, and Daniel Berlin for reviewing the data structures and algorithms and general theory of the pass. Also, several other people on IRC, over lunch tables, etc for lots of feedback and advice. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163883 91177308-0d34-0410-b5e6-96231b3b80d8 |
||
|---|---|---|
| .. | ||
| ADT | ||
| Analysis | ||
| Assembly | ||
| Bitcode | ||
| CodeGen | ||
| Config | ||
| DebugInfo | ||
| ExecutionEngine | ||
| MC | ||
| Object | ||
| Support | ||
| TableGen | ||
| Target | ||
| Transforms | ||
| Argument.h | ||
| Attributes.h | ||
| AutoUpgrade.h | ||
| BasicBlock.h | ||
| CallGraphSCCPass.h | ||
| CallingConv.h | ||
| CMakeLists.txt | ||
| Constant.h | ||
| Constants.h | ||
| DebugInfo.h | ||
| DefaultPasses.h | ||
| DerivedTypes.h | ||
| DIBuilder.h | ||
| Function.h | ||
| GlobalAlias.h | ||
| GlobalValue.h | ||
| GlobalVariable.h | ||
| GVMaterializer.h | ||
| InitializePasses.h | ||
| InlineAsm.h | ||
| InstrTypes.h | ||
| Instruction.def | ||
| Instruction.h | ||
| Instructions.h | ||
| IntrinsicInst.h | ||
| Intrinsics.h | ||
| Intrinsics.td | ||
| IntrinsicsARM.td | ||
| IntrinsicsCellSPU.td | ||
| IntrinsicsHexagon.td | ||
| IntrinsicsMips.td | ||
| IntrinsicsNVVM.td | ||
| IntrinsicsPowerPC.td | ||
| IntrinsicsX86.td | ||
| IntrinsicsXCore.td | ||
| IRBuilder.h | ||
| LinkAllPasses.h | ||
| LinkAllVMCore.h | ||
| Linker.h | ||
| LLVMContext.h | ||
| MDBuilder.h | ||
| Metadata.h | ||
| Module.h | ||
| OperandTraits.h | ||
| Operator.h | ||
| Pass.h | ||
| PassAnalysisSupport.h | ||
| PassManager.h | ||
| PassManagers.h | ||
| PassRegistry.h | ||
| PassSupport.h | ||
| SymbolTableListTraits.h | ||
| Type.h | ||
| TypeBuilder.h | ||
| TypeFinder.h | ||
| Use.h | ||
| User.h | ||
| Value.h | ||
| ValueSymbolTable.h | ||