mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-01-04 05:31:06 +00:00
0956ae5ac2
std::string to a StringRef. Moreover, the method being called accepts a Twine to simplify these patterns. Fixes this ASan failure: ==6312== ERROR: AddressSanitizer: heap-use-after-free on address 0x7fd558b1af58 at pc 0xcb7529 bp 0x7fffff572080 sp 0x7fffff572078 READ of size 1 at 0x7fd558b1af58 thread T0 #0 0xcb7528 .../llvm/include/llvm/ADT/StringRef.h:192 llvm::StringRef::operator[]() #1 0x1d53c0a .../llvm/include/llvm/ADT/StringExtras.h:128 llvm::HashString() #2 0x1d53878 .../llvm/lib/Support/StringMap.cpp:64 llvm::StringMapImpl::LookupBucketFor() #3 0x1b6872f .../llvm/include/llvm/ADT/StringMap.h:352 llvm::StringMap<>::GetOrCreateValue<>() #4 0x1b61836 .../llvm/lib/MC/MCContext.cpp:109 llvm::MCContext::GetOrCreateSymbol() #5 0xe9fd47 .../llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:154 (anonymous namespace)::ARMELFStreamer::EmitMappingSymbol() #6 0xea01dd .../llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:133 (anonymous namespace)::ARMELFStreamer::EmitDataMappingSymbol() #7 0xe9f78b .../llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:91 (anonymous namespace)::ARMELFStreamer::EmitBytes() #8 0x1b15d82 .../llvm/lib/MC/MCStreamer.cpp:89 llvm::MCStreamer::EmitIntValue() #9 0xcc0f9b .../llvm/lib/Target/ARM/ARMAsmPrinter.cpp:713 llvm::ARMAsmPrinter::emitAttributes() #10 0xcc0d44 .../llvm/lib/Target/ARM/ARMAsmPrinter.cpp:632 llvm::ARMAsmPrinter::EmitStartOfAsmFile() #11 0x14692ad .../llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:162 llvm::AsmPrinter::doInitialization() #12 0x1bc4677 .../llvm/lib/VMCore/PassManager.cpp:1561 llvm::FPPassManager::doInitialization() #13 0x1bc4990 .../llvm/lib/VMCore/PassManager.cpp:1595 llvm::MPPassManager::runOnModule() #14 0x1bc55e5 .../llvm/lib/VMCore/PassManager.cpp:1705 llvm::PassManagerImpl::run() #15 0x1bc5878 .../llvm/lib/VMCore/PassManager.cpp:1740 llvm::PassManager::run() #16 0xc3954d .../llvm/tools/llc/llc.cpp:378 compileModule() #17 0xc38001 .../llvm/tools/llc/llc.cpp:194 main #18 0x7fd557d6a11c __libc_start_main 0x7fd558b1af58 is located 24 bytes inside of 29-byte region [0x7fd558b1af40,0x7fd558b1af5d) freed by thread T0 here: #0 0xc337da .../llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:56 operator delete() #1 0x1ee9cef .../libstdc++-v3/include/bits/basic_string.h:535 std::string::~string() #2 0xea01dd .../llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:133 (anonymous namespace)::ARMELFStreamer::EmitDataMappingSymbol() #3 0xe9f78b .../llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:91 (anonymous namespace)::ARMELFStreamer::EmitBytes() #4 0x1b15d82 .../llvm/lib/MC/MCStreamer.cpp:89 llvm::MCStreamer::EmitIntValue() #5 0xcc0f9b .../llvm/lib/Target/ARM/ARMAsmPrinter.cpp:713 llvm::ARMAsmPrinter::emitAttributes() #6 0xcc0d44 .../llvm/lib/Target/ARM/ARMAsmPrinter.cpp:632 llvm::ARMAsmPrinter::EmitStartOfAsmFile() #7 0x14692ad .../llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:162 llvm::AsmPrinter::doInitialization() #8 0x1bc4677 .../llvm/lib/VMCore/PassManager.cpp:1561 llvm::FPPassManager::doInitialization() #9 0x1bc4990 .../llvm/lib/VMCore/PassManager.cpp:1595 llvm::MPPassManager::runOnModule() #10 0x1bc55e5 .../llvm/lib/VMCore/PassManager.cpp:1705 llvm::PassManagerImpl::run() #11 0x1bc5878 .../llvm/lib/VMCore/PassManager.cpp:1740 llvm::PassManager::run() #12 0xc3954d .../llvm/tools/llc/llc.cpp:378 compileModule() #13 0xc38001 .../llvm/tools/llc/llc.cpp:194 main #14 0x7fd557d6a11c __libc_start_main git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@169668 91177308-0d34-0410-b5e6-96231b3b80d8
203 lines
6.2 KiB
C++
203 lines
6.2 KiB
C++
//===- lib/MC/ARMELFStreamer.cpp - ELF Object Output for ARM --------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file assembles .s files and emits ARM ELF .o object files. Different
|
|
// from generic ELF streamer in emitting mapping symbols ($a, $t and $d) to
|
|
// delimit regions of data and code.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/MC/MCELFStreamer.h"
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
#include "llvm/ADT/StringExtras.h"
|
|
#include "llvm/MC/MCAssembler.h"
|
|
#include "llvm/MC/MCCodeEmitter.h"
|
|
#include "llvm/MC/MCContext.h"
|
|
#include "llvm/MC/MCSectionELF.h"
|
|
#include "llvm/MC/MCStreamer.h"
|
|
#include "llvm/MC/MCELF.h"
|
|
#include "llvm/MC/MCELFStreamer.h"
|
|
#include "llvm/MC/MCELFSymbolFlags.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
#include "llvm/MC/MCInst.h"
|
|
#include "llvm/MC/MCObjectStreamer.h"
|
|
#include "llvm/MC/MCSection.h"
|
|
#include "llvm/MC/MCSymbol.h"
|
|
#include "llvm/MC/MCValue.h"
|
|
#include "llvm/MC/MCAsmBackend.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/ELF.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
/// Extend the generic ELFStreamer class so that it can emit mapping symbols at
|
|
/// the appropriate points in the object files. These symbols are defined in the
|
|
/// ARM ELF ABI: infocenter.arm.com/help/topic/com.arm.../IHI0044D_aaelf.pdf.
|
|
///
|
|
/// In brief: $a, $t or $d should be emitted at the start of each contiguous
|
|
/// region of ARM code, Thumb code or data in a section. In practice, this
|
|
/// emission does not rely on explicit assembler directives but on inherent
|
|
/// properties of the directives doing the emission (e.g. ".byte" is data, "add
|
|
/// r0, r0, r0" an instruction).
|
|
///
|
|
/// As a result this system is orthogonal to the DataRegion infrastructure used
|
|
/// by MachO. Beware!
|
|
class ARMELFStreamer : public MCELFStreamer {
|
|
public:
|
|
ARMELFStreamer(MCContext &Context, MCAsmBackend &TAB,
|
|
raw_ostream &OS, MCCodeEmitter *Emitter, bool IsThumb)
|
|
: MCELFStreamer(Context, TAB, OS, Emitter),
|
|
IsThumb(IsThumb), MappingSymbolCounter(0), LastEMS(EMS_None) {
|
|
}
|
|
|
|
~ARMELFStreamer() {}
|
|
|
|
virtual void ChangeSection(const MCSection *Section) {
|
|
// We have to keep track of the mapping symbol state of any sections we
|
|
// use. Each one should start off as EMS_None, which is provided as the
|
|
// default constructor by DenseMap::lookup.
|
|
LastMappingSymbols[getPreviousSection()] = LastEMS;
|
|
LastEMS = LastMappingSymbols.lookup(Section);
|
|
|
|
MCELFStreamer::ChangeSection(Section);
|
|
}
|
|
|
|
/// This function is the one used to emit instruction data into the ELF
|
|
/// streamer. We override it to add the appropriate mapping symbol if
|
|
/// necessary.
|
|
virtual void EmitInstruction(const MCInst& Inst) {
|
|
if (IsThumb)
|
|
EmitThumbMappingSymbol();
|
|
else
|
|
EmitARMMappingSymbol();
|
|
|
|
MCELFStreamer::EmitInstruction(Inst);
|
|
}
|
|
|
|
/// This is one of the functions used to emit data into an ELF section, so the
|
|
/// ARM streamer overrides it to add the appropriate mapping symbol ($d) if
|
|
/// necessary.
|
|
virtual void EmitBytes(StringRef Data, unsigned AddrSpace) {
|
|
EmitDataMappingSymbol();
|
|
MCELFStreamer::EmitBytes(Data, AddrSpace);
|
|
}
|
|
|
|
/// This is one of the functions used to emit data into an ELF section, so the
|
|
/// ARM streamer overrides it to add the appropriate mapping symbol ($d) if
|
|
/// necessary.
|
|
virtual void EmitValueImpl(const MCExpr *Value, unsigned Size,
|
|
unsigned AddrSpace) {
|
|
EmitDataMappingSymbol();
|
|
MCELFStreamer::EmitValueImpl(Value, Size, AddrSpace);
|
|
}
|
|
|
|
virtual void EmitAssemblerFlag(MCAssemblerFlag Flag) {
|
|
MCELFStreamer::EmitAssemblerFlag(Flag);
|
|
|
|
switch (Flag) {
|
|
case MCAF_SyntaxUnified:
|
|
return; // no-op here.
|
|
case MCAF_Code16:
|
|
IsThumb = true;
|
|
return; // Change to Thumb mode
|
|
case MCAF_Code32:
|
|
IsThumb = false;
|
|
return; // Change to ARM mode
|
|
case MCAF_Code64:
|
|
return;
|
|
case MCAF_SubsectionsViaSymbols:
|
|
return;
|
|
}
|
|
}
|
|
|
|
private:
|
|
enum ElfMappingSymbol {
|
|
EMS_None,
|
|
EMS_ARM,
|
|
EMS_Thumb,
|
|
EMS_Data
|
|
};
|
|
|
|
void EmitDataMappingSymbol() {
|
|
if (LastEMS == EMS_Data) return;
|
|
EmitMappingSymbol("$d");
|
|
LastEMS = EMS_Data;
|
|
}
|
|
|
|
void EmitThumbMappingSymbol() {
|
|
if (LastEMS == EMS_Thumb) return;
|
|
EmitMappingSymbol("$t");
|
|
LastEMS = EMS_Thumb;
|
|
}
|
|
|
|
void EmitARMMappingSymbol() {
|
|
if (LastEMS == EMS_ARM) return;
|
|
EmitMappingSymbol("$a");
|
|
LastEMS = EMS_ARM;
|
|
}
|
|
|
|
void EmitMappingSymbol(StringRef Name) {
|
|
MCSymbol *Start = getContext().CreateTempSymbol();
|
|
EmitLabel(Start);
|
|
|
|
MCSymbol *Symbol =
|
|
getContext().GetOrCreateSymbol(Name.str() + "." +
|
|
itostr(MappingSymbolCounter++));
|
|
|
|
MCSymbolData &SD = getAssembler().getOrCreateSymbolData(*Symbol);
|
|
MCELF::SetType(SD, ELF::STT_NOTYPE);
|
|
MCELF::SetBinding(SD, ELF::STB_LOCAL);
|
|
SD.setExternal(false);
|
|
Symbol->setSection(*getCurrentSection());
|
|
|
|
const MCExpr *Value = MCSymbolRefExpr::Create(Start, getContext());
|
|
Symbol->setVariableValue(Value);
|
|
}
|
|
|
|
void EmitThumbFunc(MCSymbol *Func) {
|
|
// FIXME: Anything needed here to flag the function as thumb?
|
|
|
|
getAssembler().setIsThumbFunc(Func);
|
|
|
|
MCSymbolData &SD = getAssembler().getOrCreateSymbolData(*Func);
|
|
SD.setFlags(SD.getFlags() | ELF_Other_ThumbFunc);
|
|
}
|
|
|
|
|
|
bool IsThumb;
|
|
int64_t MappingSymbolCounter;
|
|
|
|
DenseMap<const MCSection *, ElfMappingSymbol> LastMappingSymbols;
|
|
ElfMappingSymbol LastEMS;
|
|
|
|
/// @}
|
|
};
|
|
}
|
|
|
|
namespace llvm {
|
|
MCELFStreamer* createARMELFStreamer(MCContext &Context, MCAsmBackend &TAB,
|
|
raw_ostream &OS, MCCodeEmitter *Emitter,
|
|
bool RelaxAll, bool NoExecStack,
|
|
bool IsThumb) {
|
|
ARMELFStreamer *S = new ARMELFStreamer(Context, TAB, OS, Emitter, IsThumb);
|
|
if (RelaxAll)
|
|
S->getAssembler().setRelaxAll(true);
|
|
if (NoExecStack)
|
|
S->getAssembler().setNoExecStack(true);
|
|
return S;
|
|
}
|
|
|
|
}
|
|
|
|
|