mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-27 13:30:05 +00:00
f93662d3d5
When two calls from the same MDLocation are inlined they currently get treated as one inlined function call (creating difficulty debugging, duplicate variables, etc). Clang worked around this by including column information on inline calls which doesn't address LTO inlining or calls to the same function from the same line and column (such as through a macro). It also didn't address ctor and member function calls. By making the inlinedAt locations distinct, every call site has an explicitly distinct location that cannot be coalesced with any other call. This can produce linearly (2x in the worst case where every call is inlined and the call instruction has a non-call instruction at the same location) more debug locations. Any increase beyond that are in cases where the Clang workaround was insufficient and the new scheme is creating necessary distinct nodes that were being erroneously coalesced previously. After this change to LLVM the incomplete workarounds in Clang. That should reduce the number of debug locations (in a build without column info, the default on Darwin, not the default on Linux) by not creating pseudo-distinct locations for every call to an inline function. (oh, and I made the inlined-at chain rebuilding iterative instead of recursive because I was having trouble wrapping my head around it the way it was - open to discussion on the right design for that function (including going back to a recursive solution)) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@226736 91177308-0d34-0410-b5e6-96231b3b80d8
38 lines
977 B
LLVM
38 lines
977 B
LLVM
; RUN: opt < %s -always-inline -S | FileCheck %s
|
|
|
|
; Test that the debug location is preserved when rewriting an inlined call as an invoke
|
|
|
|
; CHECK: invoke void @test()
|
|
; CHECK-NEXT: to label {{.*}} unwind label {{.*}}, !dbg [[INL_LOC:!.*]]
|
|
; CHECK: [[EMPTY:.*]] = !{}
|
|
; CHECK: [[INL_LOC]] = !MDLocation(line: 1, scope: [[EMPTY]], inlinedAt: [[INL_AT:.*]])
|
|
; CHECK: [[INL_AT]] = distinct !MDLocation(line: 2, scope: [[EMPTY]])
|
|
|
|
declare void @test()
|
|
declare i32 @__gxx_personality_v0(...)
|
|
|
|
attributes #0 = { alwaysinline }
|
|
define void @inl() #0 {
|
|
call void @test(), !dbg !3
|
|
ret void
|
|
}
|
|
|
|
define void @caller() {
|
|
invoke void @inl()
|
|
to label %cont unwind label %lpad, !dbg !4
|
|
|
|
cont:
|
|
ret void
|
|
|
|
lpad:
|
|
landingpad { i8*, i32 } personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*)
|
|
cleanup
|
|
ret void
|
|
}
|
|
|
|
!llvm.module.flags = !{!1}
|
|
!1 = !{i32 2, !"Debug Info Version", i32 2}
|
|
!2 = !{}
|
|
!3 = !MDLocation(line: 1, scope: !2)
|
|
!4 = !MDLocation(line: 2, scope: !2)
|