mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-06-29 00:30:47 +00:00
dad20b2ae2
Split `Metadata` away from the `Value` class hierarchy, as part of
PR21532. Assembly and bitcode changes are in the wings, but this is the
bulk of the change for the IR C++ API.
I have a follow-up patch prepared for `clang`. If this breaks other
sub-projects, I apologize in advance :(. Help me compile it on Darwin
I'll try to fix it. FWIW, the errors should be easy to fix, so it may
be simpler to just fix it yourself.
This breaks the build for all metadata-related code that's out-of-tree.
Rest assured the transition is mechanical and the compiler should catch
almost all of the problems.
Here's a quick guide for updating your code:
- `Metadata` is the root of a class hierarchy with three main classes:
`MDNode`, `MDString`, and `ValueAsMetadata`. It is distinct from
the `Value` class hierarchy. It is typeless -- i.e., instances do
*not* have a `Type`.
- `MDNode`'s operands are all `Metadata *` (instead of `Value *`).
- `TrackingVH<MDNode>` and `WeakVH` referring to metadata can be
replaced with `TrackingMDNodeRef` and `TrackingMDRef`, respectively.
If you're referring solely to resolved `MDNode`s -- post graph
construction -- just use `MDNode*`.
- `MDNode` (and the rest of `Metadata`) have only limited support for
`replaceAllUsesWith()`.
As long as an `MDNode` is pointing at a forward declaration -- the
result of `MDNode::getTemporary()` -- it maintains a side map of its
uses and can RAUW itself. Once the forward declarations are fully
resolved RAUW support is dropped on the ground. This means that
uniquing collisions on changing operands cause nodes to become
"distinct". (This already happened fairly commonly, whenever an
operand went to null.)
If you're constructing complex (non self-reference) `MDNode` cycles,
you need to call `MDNode::resolveCycles()` on each node (or on a
top-level node that somehow references all of the nodes). Also,
don't do that. Metadata cycles (and the RAUW machinery needed to
construct them) are expensive.
- An `MDNode` can only refer to a `Constant` through a bridge called
`ConstantAsMetadata` (one of the subclasses of `ValueAsMetadata`).
As a side effect, accessing an operand of an `MDNode` that is known
to be, e.g., `ConstantInt`, takes three steps: first, cast from
`Metadata` to `ConstantAsMetadata`; second, extract the `Constant`;
third, cast down to `ConstantInt`.
The eventual goal is to introduce `MDInt`/`MDFloat`/etc. and have
metadata schema owners transition away from using `Constant`s when
the type isn't important (and they don't care about referring to
`GlobalValue`s).
In the meantime, I've added transitional API to the `mdconst`
namespace that matches semantics with the old code, in order to
avoid adding the error-prone three-step equivalent to every call
site. If your old code was:
MDNode *N = foo();
bar(isa <ConstantInt>(N->getOperand(0)));
baz(cast <ConstantInt>(N->getOperand(1)));
bak(cast_or_null <ConstantInt>(N->getOperand(2)));
bat(dyn_cast <ConstantInt>(N->getOperand(3)));
bay(dyn_cast_or_null<ConstantInt>(N->getOperand(4)));
you can trivially match its semantics with:
MDNode *N = foo();
bar(mdconst::hasa <ConstantInt>(N->getOperand(0)));
baz(mdconst::extract <ConstantInt>(N->getOperand(1)));
bak(mdconst::extract_or_null <ConstantInt>(N->getOperand(2)));
bat(mdconst::dyn_extract <ConstantInt>(N->getOperand(3)));
bay(mdconst::dyn_extract_or_null<ConstantInt>(N->getOperand(4)));
and when you transition your metadata schema to `MDInt`:
MDNode *N = foo();
bar(isa <MDInt>(N->getOperand(0)));
baz(cast <MDInt>(N->getOperand(1)));
bak(cast_or_null <MDInt>(N->getOperand(2)));
bat(dyn_cast <MDInt>(N->getOperand(3)));
bay(dyn_cast_or_null<MDInt>(N->getOperand(4)));
- A `CallInst` -- specifically, intrinsic instructions -- can refer to
metadata through a bridge called `MetadataAsValue`. This is a
subclass of `Value` where `getType()->isMetadataTy()`.
`MetadataAsValue` is the *only* class that can legally refer to a
`LocalAsMetadata`, which is a bridged form of non-`Constant` values
like `Argument` and `Instruction`. It can also refer to any other
`Metadata` subclass.
(I'll break all your testcases in a follow-up commit, when I propagate
this change to assembly.)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@223802 91177308-0d34-0410-b5e6-96231b3b80d8
|
||
|---|---|---|
| .. | ||
| 2002-03-08-NameCollision.ll | ||
| 2002-03-08-NameCollision2.ll | ||
| 2002-04-07-HexFloatConstants.ll | ||
| 2002-04-07-InfConstant.ll | ||
| 2002-04-29-NameBinding.ll | ||
| 2002-05-02-InvalidForwardRef.ll | ||
| 2002-07-14-OpaqueType.ll | ||
| 2002-07-25-QuoteInString.ll | ||
| 2002-07-25-ReturnPtrFunction.ll | ||
| 2002-07-31-SlashInString.ll | ||
| 2002-08-15-CastAmbiguity.ll | ||
| 2002-08-15-ConstantExprProblem.ll | ||
| 2002-08-15-UnresolvedGlobalReference.ll | ||
| 2002-08-16-ConstExprInlined.ll | ||
| 2002-08-19-BytecodeReader.ll | ||
| 2002-08-22-DominanceProblem.ll | ||
| 2002-10-08-LargeArrayPerformance.ll | ||
| 2002-10-13-ConstantEncodingProblem.ll | ||
| 2002-12-15-GlobalResolve.ll | ||
| 2003-01-30-UnsignedString.ll | ||
| 2003-04-15-ConstantInitAssertion.ll | ||
| 2003-04-25-UnresolvedGlobalReference.ll | ||
| 2003-05-03-BytecodeReaderProblem.ll | ||
| 2003-05-12-MinIntProblem.ll | ||
| 2003-05-15-AssemblerProblem.ll | ||
| 2003-05-15-SwitchBug.ll | ||
| 2003-05-21-ConstantShiftExpr.ll | ||
| 2003-05-21-EmptyStructTest.ll | ||
| 2003-05-21-MalformedShiftCrash.ll | ||
| 2003-05-21-MalformedStructCrash.ll | ||
| 2003-08-20-ConstantExprGEP-Fold.ll | ||
| 2003-08-21-ConstantExprCast-Fold.ll | ||
| 2003-11-05-ConstantExprShift.ll | ||
| 2003-11-11-ImplicitRename.ll | ||
| 2003-11-12-ConstantExprCast.ll | ||
| 2003-11-24-SymbolTableCrash.ll | ||
| 2004-01-11-getelementptrfolding.ll | ||
| 2004-01-20-MaxLongLong.ll | ||
| 2004-02-01-NegativeZero.ll | ||
| 2004-02-27-SelfUseAssertError.ll | ||
| 2004-03-07-FunctionAddressAlignment.ll | ||
| 2004-03-30-UnclosedFunctionCrash.ll | ||
| 2004-04-04-GetElementPtrIndexTypes.ll | ||
| 2004-06-07-VerifierBug.ll | ||
| 2004-10-22-BCWriterUndefBug.ll | ||
| 2004-11-28-InvalidTypeCrash.ll | ||
| 2005-01-03-FPConstantDisassembly.ll | ||
| 2005-01-31-CallingAggregateFunction.ll | ||
| 2005-05-05-OpaqueUndefValues.ll | ||
| 2005-12-21-ZeroInitVector.ll | ||
| 2006-09-28-CrashOnInvalid.ll | ||
| 2006-12-09-Cast-To-Bool.ll | ||
| 2007-01-02-Undefined-Arg-Type.ll | ||
| 2007-01-05-Cmp-ConstExpr.ll | ||
| 2007-01-16-CrashOnBadCast.ll | ||
| 2007-01-16-CrashOnBadCast2.ll | ||
| 2007-03-18-InvalidNumberedVar.ll | ||
| 2007-03-19-NegValue.ll | ||
| 2007-04-20-AlignedLoad.ll | ||
| 2007-04-20-AlignedStore.ll | ||
| 2007-04-25-AssemblerFoldExternWeak.ll | ||
| 2007-05-21-Escape.ll | ||
| 2007-07-19-ParamAttrAmbiguity.ll | ||
| 2007-08-06-AliasInvalid.ll | ||
| 2007-09-10-AliasFwdRef.ll | ||
| 2007-09-29-GC.ll | ||
| 2007-11-26-AttributeOverload.ll | ||
| 2007-12-11-AddressSpaces.ll | ||
| 2008-01-11-VarargAttrs.ll | ||
| 2008-02-18-IntPointerCrash.ll | ||
| 2008-07-10-APInt.ll | ||
| 2008-09-02-FunctionNotes.ll | ||
| 2008-09-02-FunctionNotes2.ll | ||
| 2008-09-29-RetAttr.ll | ||
| 2008-10-14-QuoteInName.ll | ||
| 2009-02-01-UnnamedForwardRef.ll | ||
| 2009-02-28-CastOpc.ll | ||
| 2009-02-28-StripOpaqueName.ll | ||
| 2009-03-24-ZextConstantExpr.ll | ||
| 2009-07-24-ZeroArgGEP.ll | ||
| 2010-02-05-FunctionLocalMetadataBecomesNull.ll | ||
| addrspacecast-alias.ll | ||
| aggregate-constant-values.ll | ||
| aggregate-return-single-value.ll | ||
| alias-redefinition.ll | ||
| alias-use-list-order.ll | ||
| align-inst-alloca.ll | ||
| align-inst-load.ll | ||
| align-inst-store.ll | ||
| align-inst.ll | ||
| alignstack.ll | ||
| anon-functions.ll | ||
| atomic.ll | ||
| attribute-builtin.ll | ||
| auto_upgrade_intrinsics.ll | ||
| bcwrap.ll | ||
| comment.ll | ||
| ConstantExprFold.ll | ||
| ConstantExprFoldCast.ll | ||
| ConstantExprFoldSelect.ll | ||
| ConstantExprNoFold.ll | ||
| externally-initialized.ll | ||
| extractvalue-invalid-idx.ll | ||
| fast-math-flags.ll | ||
| flags.ll | ||
| functionlocal-metadata-attachments.ll | ||
| functionlocal-metadata-complex-1.ll | ||
| functionlocal-metadata-complex-2.ll | ||
| functionlocal-metadata-complex-3.ll | ||
| functionlocal-metadata.ll | ||
| getelementptr_struct.ll | ||
| getelementptr_vec_idx1.ll | ||
| getelementptr_vec_idx2.ll | ||
| getelementptr_vec_idx3.ll | ||
| getelementptr_vec_struct.ll | ||
| getelementptr.ll | ||
| getInt.ll | ||
| global-addrspace-forwardref.ll | ||
| half-constprop.ll | ||
| half-conv.ll | ||
| half.ll | ||
| huge-array.ll | ||
| inalloca.ll | ||
| inline-asm-clobber.ll | ||
| insertextractvalue.ll | ||
| insertvalue-invalid-idx.ll | ||
| internal-hidden-alias.ll | ||
| internal-hidden-function.ll | ||
| internal-hidden-variable.ll | ||
| internal-protected-alias.ll | ||
| internal-protected-function.ll | ||
| internal-protected-variable.ll | ||
| invalid_cast.ll | ||
| invalid_cast2.ll | ||
| invalid_cast3.ll | ||
| invalid-attrgrp.ll | ||
| invalid-comdat.ll | ||
| invalid-comdat2.ll | ||
| invalid-fwdref1.ll | ||
| invalid-fwdref2.ll | ||
| invalid-name.ll | ||
| invalid-uselistorder_bb-missing-bb.ll | ||
| invalid-uselistorder_bb-missing-body.ll | ||
| invalid-uselistorder_bb-missing-func.ll | ||
| invalid-uselistorder_bb-not-bb.ll | ||
| invalid-uselistorder_bb-not-func.ll | ||
| invalid-uselistorder_bb-numbered.ll | ||
| invalid-uselistorder-function-between-blocks.ll | ||
| invalid-uselistorder-function-missing-named.ll | ||
| invalid-uselistorder-function-missing-numbered.ll | ||
| invalid-uselistorder-global-missing.ll | ||
| invalid-uselistorder-indexes-duplicated.ll | ||
| invalid-uselistorder-indexes-empty.ll | ||
| invalid-uselistorder-indexes-one.ll | ||
| invalid-uselistorder-indexes-ordered.ll | ||
| invalid-uselistorder-indexes-range.ll | ||
| invalid-uselistorder-indexes-toofew.ll | ||
| invalid-uselistorder-indexes-toomany.ll | ||
| invalid-uselistorder-type.ll | ||
| metadata.ll | ||
| MultipleReturnValueType.ll | ||
| musttail-invalid-1.ll | ||
| musttail-invalid-2.ll | ||
| musttail.ll | ||
| named-metadata.ll | ||
| numbered-values.ll | ||
| private-hidden-alias.ll | ||
| private-hidden-function.ll | ||
| private-hidden-variable.ll | ||
| private-protected-alias.ll | ||
| private-protected-function.ll | ||
| private-protected-variable.ll | ||
| select.ll | ||
| tls-models.ll | ||
| unnamed-addr.ll | ||
| unnamed.ll | ||
| upgrade-loop-metadata.ll | ||
| uselistorder_bb.ll | ||
| uselistorder.ll | ||
| vbool-cmp.ll | ||
| vector-cmp.ll | ||
| vector-select.ll | ||
| vector-shift.ll | ||
| x86mmx.ll | ||