mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-07-21 18:29:45 +00:00
37be0d7c43
This was introduced in a faulty refactoring (r225640, mea culpa): the tests weren't testing the return values, so, for both __strcpy_chk and __stpcpy_chk, we would return the end of the buffer (matching stpcpy) instead of the beginning (for strcpy). The root cause was the prefix "__" being ignored when comparing, which made us always pick LibFunc::stpcpy_chk. Pass the LibFunc::Func directly to avoid this kind of error. Also, make the testcases as explicit as possible to prevent this. The now-useful testcases expose another, entangled, stpcpy problem, with the further simplification. This was introduced in a refactoring (r225640) to match the original behavior. However, this leads to problems when successive simplifications generate several similar instructions, none of which are removed by the custom replaceAllUsesWith. For instance, InstCombine (the main user) doesn't erase the instruction in its custom RAUW. When trying to simplify say __stpcpy_chk: - first, an stpcpy is created (fortified simplifier), - second, a memcpy is created (normal simplifier), but the stpcpy call isn't removed. - third, InstCombine later revisits the instructions, and simplifies the first stpcpy to a memcpy. We now have two memcpys. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@227250 91177308-0d34-0410-b5e6-96231b3b80d8
72 lines
3.0 KiB
LLVM
72 lines
3.0 KiB
LLVM
; Test lib call simplification of __strncpy_chk calls with various values
|
|
; for len and dstlen.
|
|
;
|
|
; RUN: opt < %s -instcombine -S | FileCheck %s
|
|
|
|
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
|
|
|
|
@a = common global [60 x i8] zeroinitializer, align 1
|
|
@b = common global [60 x i8] zeroinitializer, align 1
|
|
@.str = private constant [12 x i8] c"abcdefghijk\00"
|
|
|
|
; Check cases where dstlen >= len
|
|
|
|
define i8* @test_simplify1() {
|
|
; CHECK-LABEL: @test_simplify1(
|
|
%dst = getelementptr inbounds [60 x i8]* @a, i32 0, i32 0
|
|
%src = getelementptr inbounds [12 x i8]* @.str, i32 0, i32 0
|
|
|
|
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* getelementptr inbounds ([60 x i8]* @a, i32 0, i32 0), i8* getelementptr inbounds ([12 x i8]* @.str, i32 0, i32 0), i32 12, i32 1, i1 false)
|
|
; CHECK-NEXT: ret i8* getelementptr inbounds ([60 x i8]* @a, i32 0, i32 0)
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 12, i32 60)
|
|
ret i8* %ret
|
|
}
|
|
|
|
define i8* @test_simplify2() {
|
|
; CHECK-LABEL: @test_simplify2(
|
|
%dst = getelementptr inbounds [60 x i8]* @a, i32 0, i32 0
|
|
%src = getelementptr inbounds [12 x i8]* @.str, i32 0, i32 0
|
|
|
|
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* getelementptr inbounds ([60 x i8]* @a, i32 0, i32 0), i8* getelementptr inbounds ([12 x i8]* @.str, i32 0, i32 0), i32 12, i32 1, i1 false)
|
|
; CHECK-NEXT: ret i8* getelementptr inbounds ([60 x i8]* @a, i32 0, i32 0)
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 12, i32 12)
|
|
ret i8* %ret
|
|
}
|
|
|
|
define i8* @test_simplify3() {
|
|
; CHECK-LABEL: @test_simplify3(
|
|
%dst = getelementptr inbounds [60 x i8]* @a, i32 0, i32 0
|
|
%src = getelementptr inbounds [60 x i8]* @b, i32 0, i32 0
|
|
|
|
; CHECK-NEXT: %strncpy = call i8* @strncpy(i8* getelementptr inbounds ([60 x i8]* @a, i32 0, i32 0), i8* getelementptr inbounds ([60 x i8]* @b, i32 0, i32 0), i32 12)
|
|
; CHECK-NEXT: ret i8* %strncpy
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 12, i32 60)
|
|
ret i8* %ret
|
|
}
|
|
|
|
; Check cases where dstlen < len
|
|
|
|
define i8* @test_no_simplify1() {
|
|
; CHECK-LABEL: @test_no_simplify1(
|
|
%dst = getelementptr inbounds [60 x i8]* @a, i32 0, i32 0
|
|
%src = getelementptr inbounds [12 x i8]* @.str, i32 0, i32 0
|
|
|
|
; CHECK-NEXT: %ret = call i8* @__strncpy_chk(i8* getelementptr inbounds ([60 x i8]* @a, i32 0, i32 0), i8* getelementptr inbounds ([12 x i8]* @.str, i32 0, i32 0), i32 8, i32 4)
|
|
; CHECK-NEXT: ret i8* %ret
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 8, i32 4)
|
|
ret i8* %ret
|
|
}
|
|
|
|
define i8* @test_no_simplify2() {
|
|
; CHECK-LABEL: @test_no_simplify2(
|
|
%dst = getelementptr inbounds [60 x i8]* @a, i32 0, i32 0
|
|
%src = getelementptr inbounds [60 x i8]* @b, i32 0, i32 0
|
|
|
|
; CHECK-NEXT: %ret = call i8* @__strncpy_chk(i8* getelementptr inbounds ([60 x i8]* @a, i32 0, i32 0), i8* getelementptr inbounds ([60 x i8]* @b, i32 0, i32 0), i32 8, i32 0)
|
|
; CHECK-NEXT: ret i8* %ret
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 8, i32 0)
|
|
ret i8* %ret
|
|
}
|
|
|
|
declare i8* @__strncpy_chk(i8*, i8*, i32, i32)
|