mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-12 00:29:20 +00:00
f91f5af802
directly query the function information which this set was representing. This simplifies the interface of the inline cost analysis, and makes the always-inline pass significantly more efficient. Previously, always-inline would first make a single set of every function in the module *except* those marked with the always-inline attribute. It would then query this set at every call site to see if the function was a member of the set, and if so, refuse to inline it. This is quite wasteful. Instead, simply check the function attribute directly when looking at the callsite. The normal inliner also had similar redundancy. It added every function in the module with the noinline attribute to its set to ignore, even though inside the cost analysis function we *already tested* the noinline attribute and produced the same result. The only tricky part of removing this is that we have to be able to correctly remove only the functions inlined by the always-inline pass when finalizing, which requires a bit of a hack. Still, much less of a hack than the set of all non-always-inline functions was. While I was touching this function, I switched a heavy-weight set to a vector with sort+unique. The algorithm already had a two-phase insert and removal pattern, we were just needlessly paying the uniquing cost on every insert. This probably speeds up some compiles by a small amount (-O0 compiles with lots of always-inline, so potentially heavy libc++ users), but I've not tried to measure it. I believe there is no functional change here, but yell if you spot one. None are intended. Finally, the direction this is going in is to greatly simplify the inline cost query interface so that we can replace its implementation with a much more clever one. Along the way, all the APIs get simplified, so it seems incrementally good. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152903 91177308-0d34-0410-b5e6-96231b3b80d8
126 lines
3.9 KiB
C++
126 lines
3.9 KiB
C++
//===- InlineSimple.cpp - Code to perform simple function inlining --------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements bottom-up inlining of functions into callees.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#define DEBUG_TYPE "inline"
|
|
#include "llvm/CallingConv.h"
|
|
#include "llvm/Instructions.h"
|
|
#include "llvm/IntrinsicInst.h"
|
|
#include "llvm/Module.h"
|
|
#include "llvm/Type.h"
|
|
#include "llvm/Analysis/CallGraph.h"
|
|
#include "llvm/Analysis/InlineCost.h"
|
|
#include "llvm/Support/CallSite.h"
|
|
#include "llvm/Transforms/IPO.h"
|
|
#include "llvm/Transforms/IPO/InlinerPass.h"
|
|
#include "llvm/Target/TargetData.h"
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
class SimpleInliner : public Inliner {
|
|
// Functions that are never inlined
|
|
SmallPtrSet<const Function*, 16> NeverInline;
|
|
InlineCostAnalyzer CA;
|
|
public:
|
|
SimpleInliner() : Inliner(ID) {
|
|
initializeSimpleInlinerPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
SimpleInliner(int Threshold) : Inliner(ID, Threshold,
|
|
/*InsertLifetime*/true) {
|
|
initializeSimpleInlinerPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
static char ID; // Pass identification, replacement for typeid
|
|
InlineCost getInlineCost(CallSite CS) {
|
|
// Filter out functions which should never be inlined due to the global
|
|
// 'llvm.noinline'.
|
|
// FIXME: I'm 99% certain that this is an ancient bit of legacy that we
|
|
// no longer need to support, but I don't want to blindly nuke it just
|
|
// yet.
|
|
if (Function *Callee = CS.getCalledFunction())
|
|
if (NeverInline.count(Callee))
|
|
return InlineCost::getNever();
|
|
|
|
return CA.getInlineCost(CS);
|
|
}
|
|
float getInlineFudgeFactor(CallSite CS) {
|
|
return CA.getInlineFudgeFactor(CS);
|
|
}
|
|
void resetCachedCostInfo(Function *Caller) {
|
|
CA.resetCachedCostInfo(Caller);
|
|
}
|
|
void growCachedCostInfo(Function* Caller, Function* Callee) {
|
|
CA.growCachedCostInfo(Caller, Callee);
|
|
}
|
|
virtual bool doInitialization(CallGraph &CG);
|
|
void releaseMemory() {
|
|
CA.clear();
|
|
}
|
|
};
|
|
}
|
|
|
|
char SimpleInliner::ID = 0;
|
|
INITIALIZE_PASS_BEGIN(SimpleInliner, "inline",
|
|
"Function Integration/Inlining", false, false)
|
|
INITIALIZE_AG_DEPENDENCY(CallGraph)
|
|
INITIALIZE_PASS_END(SimpleInliner, "inline",
|
|
"Function Integration/Inlining", false, false)
|
|
|
|
Pass *llvm::createFunctionInliningPass() { return new SimpleInliner(); }
|
|
|
|
Pass *llvm::createFunctionInliningPass(int Threshold) {
|
|
return new SimpleInliner(Threshold);
|
|
}
|
|
|
|
// doInitialization - Initializes the vector of functions that have been
|
|
// annotated with the noinline attribute.
|
|
bool SimpleInliner::doInitialization(CallGraph &CG) {
|
|
CA.setTargetData(getAnalysisIfAvailable<TargetData>());
|
|
|
|
Module &M = CG.getModule();
|
|
|
|
// Get llvm.noinline
|
|
GlobalVariable *GV = M.getNamedGlobal("llvm.noinline");
|
|
|
|
if (GV == 0)
|
|
return false;
|
|
|
|
// Don't crash on invalid code
|
|
if (!GV->hasDefinitiveInitializer())
|
|
return false;
|
|
|
|
const ConstantArray *InitList = dyn_cast<ConstantArray>(GV->getInitializer());
|
|
|
|
if (InitList == 0)
|
|
return false;
|
|
|
|
// Iterate over each element and add to the NeverInline set
|
|
for (unsigned i = 0, e = InitList->getNumOperands(); i != e; ++i) {
|
|
|
|
// Get Source
|
|
const Constant *Elt = InitList->getOperand(i);
|
|
|
|
if (const ConstantExpr *CE = dyn_cast<ConstantExpr>(Elt))
|
|
if (CE->getOpcode() == Instruction::BitCast)
|
|
Elt = CE->getOperand(0);
|
|
|
|
// Insert into set of functions to never inline
|
|
if (const Function *F = dyn_cast<Function>(Elt))
|
|
NeverInline.insert(F);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|