David Peixotto 1edc33b924 ARM integrated assembler generates incorrect nop opcode ... This patch fixes a bug in the assembler that was causing bad code to be emitted. When switching modes in an assembly file (e.g. arm to thumb mode) we would always emit the opcode from the original mode. Consider this small example: $ cat align.s .code 16 foo: add r0, r0 .align 3 add r0, r0 $ llvm-mc -triple armv7-none-linux align.s -filetype=obj -o t.o $ llvm-objdump -triple thumbv7 -d t.o Disassembly of section .text: foo: 0: 00 44 add r0, r0 2: 00 f0 20 e3 blx #4195904 6: 00 00 movs r0, r0 8: 00 44 add r0, r0 This shows that we have actually emitted an arm nop (e320f000) instead of a thumb nop. Unfortunately, this encodes to a thumb branch which causes bad things to happen when compiling assembly code with align directives. The fix is to notify the ARMAsmBackend when we switch mode. The MCMachOStreamer was already doing this correctly. This patch makes the same change for the MCElfStreamer. There is still a bug in the way nops are emitted for alignment because the MCAlignment fragment does not store the correct mode. The ARMAsmBackend will emit nops for the last mode it knew about. In the example above, we still generate an arm nop if we add a `.code 32` to the end of the file. PR18019 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195677 91177308-0d34-0410-b5e6-96231b3b80d8		2013-11-25 19:11:13 +00:00
..
MCDisassembler	[llvm-c][Disassembler] When printing latency information, fall back to the	2013-10-03 17:51:49 +00:00
MCParser	Support multiple COFF sections with the same name but different COMDAT.	2013-11-19 19:52:52 +00:00
CMakeLists.txt	Add a MCAsmInfoELF class and factor some code into it.	2013-10-16 01:34:32 +00:00
ELFObjectWriter.cpp	Move the STT_FILE symbols out of the normal symbol table processing for	2013-10-29 01:06:17 +00:00
LLVMBuild.txt
MachObjectWriter.cpp	MachO: Improve backend diagnostic for overalignment.	2013-09-24 23:56:31 +00:00
Makefile
MCAsmBackend.cpp
MCAsmInfo.cpp	Remove AllowQuotesInName and friends from MCAsmInfo.	2013-11-13 14:01:59 +00:00
MCAsmInfoCOFF.cpp	Remove AllowQuotesInName and friends from MCAsmInfo.	2013-11-13 14:01:59 +00:00
MCAsmInfoDarwin.cpp	Remove AllowQuotesInName and friends from MCAsmInfo.	2013-11-13 14:01:59 +00:00
MCAsmInfoELF.cpp	Add a MCAsmInfoELF class and factor some code into it.	2013-10-16 01:34:32 +00:00
MCAsmStreamer.cpp	MCStreamer: Reimplement the virtual EmitRawText as a protected member, EmitRawTextImpl, to avoid string literal ambiguities	2013-10-24 22:43:10 +00:00
MCAssembler.cpp
MCAtom.cpp	[weak vtables] Remove a bunch of weak vtables	2013-11-19 00:57:56 +00:00
MCCodeEmitter.cpp
MCCodeGenInfo.cpp
MCContext.cpp	Support multiple COFF sections with the same name but different COMDAT.	2013-11-19 19:52:52 +00:00
MCDisassembler.cpp
MCDwarf.cpp	Implements parsing and emitting of .cfi_window_save in MC.	2013-09-26 14:49:40 +00:00
MCELF.cpp	Move the STT_FILE symbols out of the normal symbol table processing for	2013-10-29 01:06:17 +00:00
MCELFObjectTargetWriter.cpp	Provide basic type safety for array_pod_sort comparators.	2013-09-22 14:09:50 +00:00
MCELFStreamer.cpp	ARM integrated assembler generates incorrect nop opcode	2013-11-25 19:11:13 +00:00
MCExpr.cpp
MCExternalSymbolizer.cpp	Add to the disassembler C API output reference types for	2013-11-01 00:00:07 +00:00
MCFunction.cpp	Style cleanup following David's review for r188876.	2013-08-21 19:40:25 +00:00
MCInst.cpp
MCInstPrinter.cpp	[MC] When MCInstPrint::printAnnotation uses a comment stream, it has to ensure	2013-10-01 19:21:24 +00:00
MCInstrAnalysis.cpp
MCLabel.cpp
MCMachObjectTargetWriter.cpp
MCMachOStreamer.cpp	Move .ident handling to MCStreamer.	2013-10-16 01:05:45 +00:00
MCModule.cpp	MC CFG: Split MCBasicBlocks to mirror atom splitting.	2013-08-21 07:28:24 +00:00
MCModuleYAML.cpp	MC CFG: Add YAML MCModule representation to enable MC CFG testing.	2013-08-21 07:29:02 +00:00
MCNullStreamer.cpp	Add a MCTargetStreamer interface.	2013-10-08 13:08:17 +00:00
MCObjectDisassembler.cpp	Create an atom with just the data that failed to disassemble.	2013-10-16 19:03:14 +00:00
MCObjectFileInfo.cpp	Add a method to get the object-file appropriate stack map section.	2013-11-08 22:14:49 +00:00
MCObjectStreamer.cpp	Emit DWARF line entries for all data in the instruction stream.	2013-10-20 02:16:18 +00:00
MCObjectSymbolizer.cpp	Move everything depending on Object/MachOFormat.h over to Support/MachO.h.	2013-09-01 04:28:48 +00:00
MCObjectWriter.cpp
MCPureStreamer.cpp	Move .ident handling to MCStreamer.	2013-10-16 01:05:45 +00:00
MCRegisterInfo.cpp
MCRelocationInfo.cpp
MCSection.cpp
MCSectionCOFF.cpp	Revert "Re-commit r192758 - MC: quote tricky symbol names in asm output"	2013-10-18 02:14:40 +00:00
MCSectionELF.cpp	Remove AllowQuotesInName and friends from MCAsmInfo.	2013-11-13 14:01:59 +00:00
MCSectionMachO.cpp
MCStreamer.cpp	[weak vtables] Remove a bunch of weak vtables	2013-11-19 00:57:56 +00:00
MCSubtargetInfo.cpp	MC: Don't assume incoming StringRef's are null terminated.	2013-10-13 22:09:26 +00:00
MCSymbol.cpp	Don't mangle \n and "	2013-11-14 06:05:49 +00:00
MCSymbolizer.cpp
MCValue.cpp
MCWin64EH.cpp	Fix alignment of unwind data.	2013-09-15 18:01:09 +00:00
SubtargetFeature.cpp	MC: Don't assume incoming StringRef's are null terminated.	2013-10-13 22:09:26 +00:00
WinCOFFObjectWriter.cpp	[weak vtables] Remove a bunch of weak vtables	2013-11-19 00:57:56 +00:00
WinCOFFStreamer.cpp	Fix .comm and .lcomm on COFF.	2013-11-25 16:06:04 +00:00