From 26926a9feb588e3d0da18961dd34e6be7fb79b95 Mon Sep 17 00:00:00 2001 From: Sam M W Date: Mon, 3 Apr 2023 22:44:02 +0100 Subject: [PATCH] set_byte method does not need to return old_value --- src/memory.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/memory.rs b/src/memory.rs index 7194de7..cf987f2 100644 --- a/src/memory.rs +++ b/src/memory.rs @@ -60,7 +60,7 @@ impl Default for Memory { pub trait Bus { fn get_byte(&self, address: u16) -> u8; - fn set_byte(&mut self, address: u16, value: u8) -> u8; + fn set_byte(&mut self, address: u16, value: u8); fn set_bytes(&mut self, start: u16, values: &[u8]) { for i in 0..values.len() as u16 { @@ -84,10 +84,8 @@ impl Bus for Memory { // Sets the byte at the given address to the given value and returns the // previous value at the address. - fn set_byte(&mut self, address: u16, value: u8) -> u8 { - let old_value = self.get_byte(address); + fn set_byte(&mut self, address: u16, value: u8) { self.bytes[address as usize] = value; - old_value } fn set_bytes(&mut self, start: u16, values: &[u8]) {